codelipenghui commented on a change in pull request #11500:
URL: https://github.com/apache/pulsar/pull/11500#discussion_r679348525
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursorMXBean.java
##########
@@ -70,4 +70,33 @@
*/
long getPersistZookeeperErrors();
+ /**
+ * Update write cursor size.
+ *
+ * @param size the size of write to cursor
+ */
+ void updateWriteLedgerSize(long size);
+
+ /**
+ * Update read cursor size.
+ *
+ * @param size the size of read from cursor
+ */
+ void updateReadLedgerSize(long size);
+
+ /**
+ * @return the size of write to ledger size
+ */
+ long getWriteLedgerSize();
Review comment:
```suggestion
long getWriteCursorLedgerSize();
```
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursorMXBean.java
##########
@@ -70,4 +70,33 @@
*/
long getPersistZookeeperErrors();
+ /**
+ * Update write cursor size.
+ *
+ * @param size the size of write to cursor
+ */
+ void updateWriteLedgerSize(long size);
+
+ /**
+ * Update read cursor size.
+ *
+ * @param size the size of read from cursor
+ */
+ void updateReadLedgerSize(long size);
+
+ /**
+ * @return the size of write to ledger size
+ */
+ long getWriteLedgerSize();
+
+ /**
+ * @return the size of write to ledger size (accounting for without
replicas)
+ */
+ long getWriteLedgerLogicalSize();
+
+ /**
+ * @return the size of read from ledger size
+ */
+ long getReadLedgerSize();
Review comment:
```suggestion
long getReadCursorLedgerSize();
```
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursorMXBean.java
##########
@@ -70,4 +70,33 @@
*/
long getPersistZookeeperErrors();
+ /**
+ * Update write cursor size.
+ *
+ * @param size the size of write to cursor
+ */
+ void updateWriteLedgerSize(long size);
+
+ /**
+ * Update read cursor size.
+ *
+ * @param size the size of read from cursor
+ */
+ void updateReadLedgerSize(long size);
+
+ /**
+ * @return the size of write to ledger size
+ */
+ long getWriteLedgerSize();
+
+ /**
+ * @return the size of write to ledger size (accounting for without
replicas)
+ */
+ long getWriteLedgerLogicalSize();
Review comment:
```suggestion
long getWriteCursorLedgerLogicalSize();
```
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursorMXBean.java
##########
@@ -70,4 +70,33 @@
*/
long getPersistZookeeperErrors();
+ /**
+ * Update write cursor size.
+ *
+ * @param size the size of write to cursor
+ */
+ void updateWriteLedgerSize(long size);
+
+ /**
+ * Update read cursor size.
+ *
+ * @param size the size of read from cursor
+ */
+ void updateReadLedgerSize(long size);
Review comment:
```suggestion
void addReadCursorLedgerSize(long size);
```
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursorMXBean.java
##########
@@ -70,4 +70,33 @@
*/
long getPersistZookeeperErrors();
+ /**
+ * Update write cursor size.
+ *
+ * @param size the size of write to cursor
+ */
+ void updateWriteLedgerSize(long size);
Review comment:
```suggestion
void addWriteCursorLedgerSize(long size);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
