Anonymitaet commented on a change in pull request #11500:
URL: https://github.com/apache/pulsar/pull/11500#discussion_r679694043
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursorMXBean.java
##########
@@ -70,4 +70,33 @@
*/
long getPersistZookeeperErrors();
+ /**
+ * Add write cursor size.
+ *
+ * @param size the size of write to cursor
Review comment:
```suggestion
* @param size Size of data written to cursor (in bytes)
```
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursorMXBean.java
##########
@@ -70,4 +70,33 @@
*/
long getPersistZookeeperErrors();
+ /**
+ * Add write cursor size.
+ *
+ * @param size the size of write to cursor
+ */
+ void addWriteCursorLedgerSize(long size);
+
+ /**
+ * Add read cursor size.
+ *
+ * @param size the size of read from cursor
+ */
+ void addReadCursorLedgerSize(long size);
+
+ /**
+ * @return the size of write to ledger size
Review comment:
```suggestion
* @return the size of data written to cursor (in bytes)
```
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursorMXBean.java
##########
@@ -70,4 +70,33 @@
*/
long getPersistZookeeperErrors();
+ /**
+ * Add write cursor size.
+ *
+ * @param size the size of write to cursor
+ */
+ void addWriteCursorLedgerSize(long size);
+
+ /**
+ * Add read cursor size.
+ *
+ * @param size the size of read from cursor
+ */
+ void addReadCursorLedgerSize(long size);
+
+ /**
+ * @return the size of write to ledger size
+ */
+ long getWriteCursorLedgerSize();
+
+ /**
+ * @return the size of write to ledger size (accounting for without
replicas)
+ */
+ long getWriteCursorLedgerLogicalSize();
+
+ /**
+ * @return the size of read from ledger size
Review comment:
```suggestion
* @return the size of data read from cursor (in bytes)
```
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursorMXBean.java
##########
@@ -70,4 +70,33 @@
*/
long getPersistZookeeperErrors();
+ /**
+ * Add write cursor size.
Review comment:
```suggestion
* Add data to a ledger of a cursor (in bytes)
```
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursorMXBean.java
##########
@@ -70,4 +70,33 @@
*/
long getPersistZookeeperErrors();
+ /**
+ * Add write cursor size.
+ *
+ * @param size the size of write to cursor
+ */
+ void addWriteCursorLedgerSize(long size);
+
+ /**
+ * Add read cursor size.
+ *
+ * @param size the size of read from cursor
Review comment:
```suggestion
* @param Size of data read from cursor (in bytes)
```
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursorMXBean.java
##########
@@ -70,4 +70,33 @@
*/
long getPersistZookeeperErrors();
+ /**
+ * Add write cursor size.
+ *
+ * @param size the size of write to cursor
+ */
+ void addWriteCursorLedgerSize(long size);
+
+ /**
+ * Add read cursor size.
+ *
+ * @param size the size of read from cursor
+ */
+ void addReadCursorLedgerSize(long size);
+
+ /**
+ * @return the size of write to ledger size
+ */
+ long getWriteCursorLedgerSize();
+
+ /**
+ * @return the size of write to ledger size (accounting for without
replicas)
Review comment:
```suggestion
* @return the size of data written to cursor without replicas (in bytes)
```
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursorMXBean.java
##########
@@ -70,4 +70,33 @@
*/
long getPersistZookeeperErrors();
+ /**
+ * Add write cursor size.
+ *
+ * @param size the size of write to cursor
+ */
+ void addWriteCursorLedgerSize(long size);
+
+ /**
+ * Add read cursor size.
Review comment:
```suggestion
* Read data from a ledger of a cursor (in bytes)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
