merlimat commented on a change in pull request #12270:
URL: https://github.com/apache/pulsar/pull/12270#discussion_r721651638
##########
File path: pulsar-common/pom.xml
##########
@@ -196,6 +196,24 @@
<build>
<plugins>
+ <plugin>
+ <groupId>org.gaul</groupId>
+ <artifactId>modernizer-maven-plugin</artifactId>
Review comment:
If it's on parent pom, it will mean all the changes have to be done in a
single commit which is not good.
Though the plugin version should be defined in the pluginManagement section
in parent pom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
