MarvinCai commented on a change in pull request #12270:
URL: https://github.com/apache/pulsar/pull/12270#discussion_r727647934
##########
File path: pulsar-common/pom.xml
##########
@@ -196,6 +196,24 @@
<build>
<plugins>
+ <plugin>
+ <groupId>org.gaul</groupId>
+ <artifactId>modernizer-maven-plugin</artifactId>
Review comment:
sure, added Modernizer into parent pom `pluginManagement` to define
version in central place.
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/PersistentOfflineTopicStats.java
##########
@@ -55,8 +55,8 @@
public PersistentOfflineTopicStats(String topicName, String brokerName) {
this.brokerName = brokerName;
this.topicName = topicName;
- this.dataLedgerDetails = Lists.newArrayList();
- this.cursorDetails = Maps.newHashMap();
+ this.dataLedgerDetails = new ArrayList<>();
Review comment:
yeah, as discussed, it's gonna be removed module by module, not all at
a time, most Guava helper newXXX without parameter is just wrapper around the
diamond syntax, so should be any different switching, also it's good to
encourage using native language support whenever possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
