eolivelli commented on a change in pull request #12270:
URL: https://github.com/apache/pulsar/pull/12270#discussion_r721730509
##########
File path: pulsar-common/pom.xml
##########
@@ -196,6 +196,24 @@
<build>
<plugins>
+ <plugin>
+ <groupId>org.gaul</groupId>
+ <artifactId>modernizer-maven-plugin</artifactId>
Review comment:
Yes I meant to use pluginManagement in order to set the version.
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/PersistentOfflineTopicStats.java
##########
@@ -55,8 +55,8 @@
public PersistentOfflineTopicStats(String topicName, String brokerName) {
this.brokerName = brokerName;
this.topicName = topicName;
- this.dataLedgerDetails = Lists.newArrayList();
- this.cursorDetails = Maps.newHashMap();
+ this.dataLedgerDetails = new ArrayList<>();
Review comment:
Correct.
Thanks for the pointer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
