bschofield commented on pull request #663: URL: https://github.com/apache/pulsar-client-go/pull/663#issuecomment-963973621
> The only question I'm still confused is, could you explain following code and its output? Ag! I'm so sorry @BewareMyPower, you're 100% correct: `c.Lock()` and `c.cond.L.Lock()` absolutely are the same lock. I had totally missed that `sync.NewCond` took a `Locker` as an argument. Thanks for clarifying that, and my apologies. > I'm just wondering whether there should be another lock for this. I think that's up to you guys -- it depends what the ultimate intent of the lock is. Is it to protect against all state changes in the connection, or just some of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
