BewareMyPower edited a comment on pull request #663: URL: https://github.com/apache/pulsar-client-go/pull/663#issuecomment-963976311
> I think that's up to you guys -- it depends what the ultimate intent of the lock is. Is it to protect against all state changes in the connection, or just some of them. Yeah, it won't block this PR. Just say it because I've seen the similar case in C++ client that a common mutex is used everywhere. For this PR, I think you can change `c.cond.L.` back to `c.`, then it will LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
