pkumar-singh commented on a change in pull request #13196:
URL: https://github.com/apache/pulsar/pull/13196#discussion_r768282046
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
##########
@@ -804,6 +804,16 @@ protected void handleProducerRemoved(Producer producer) {
if (ex.getCause() instanceof ConsumerBusyException) {
log.warn("[{}][{}] Consumer {} {} already connected",
topic, subscriptionName, consumerId,
consumerName);
+ Consumer consumer = null;
+ try {
+ consumer = subscriptionFuture.isDone() ?
getActiveConsumer(subscriptionFuture.get()) : null;
+ // cleanup consumer if connection is already closed
+ if (consumer != null && !consumer.cnx().isActive()) {
+ consumer.close();
+ }
+ } catch (Exception be) {
+ log.info("Failed to clean up consumer on closed
connection {}, {}", consumer, be.getMessage());
Review comment:
To me. It seems like a bandaid. I think we should see how we landed in
this situation. Perhaps we should have clean the consumer at the connection
close itself. If there is a race condition we should the race condition itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
