rdhabalia commented on a change in pull request #13196:
URL: https://github.com/apache/pulsar/pull/13196#discussion_r770224974
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
##########
@@ -804,6 +804,16 @@ protected void handleProducerRemoved(Producer producer) {
if (ex.getCause() instanceof ConsumerBusyException) {
log.warn("[{}][{}] Consumer {} {} already connected",
topic, subscriptionName, consumerId,
consumerName);
+ Consumer consumer = null;
+ try {
+ consumer = subscriptionFuture.isDone() ?
getActiveConsumer(subscriptionFuture.get()) : null;
+ // cleanup consumer if connection is already closed
+ if (consumer != null && !consumer.cnx().isActive()) {
+ consumer.close();
+ }
+ } catch (Exception be) {
+ log.info("Failed to clean up consumer on closed
connection {}, {}", consumer, be.getMessage());
Review comment:
@Jason918 changed to error log level.
@pkumar-singh this is part handles resiliency to avoid consumer
unavailability due to any kind of race condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
