Jason918 commented on a change in pull request #13196:
URL: https://github.com/apache/pulsar/pull/13196#discussion_r773553165
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
##########
@@ -804,6 +804,16 @@ protected void handleProducerRemoved(Producer producer) {
if (ex.getCause() instanceof ConsumerBusyException) {
log.warn("[{}][{}] Consumer {} {} already connected",
topic, subscriptionName, consumerId,
consumerName);
+ Consumer consumer = null;
+ try {
+ consumer = subscriptionFuture.isDone() ?
getActiveConsumer(subscriptionFuture.get()) : null;
+ // cleanup consumer if connection is already closed
+ if (consumer != null && !consumer.cnx().isActive()) {
+ consumer.close();
Review comment:
> however, in any case it would be safe to call close for already closed
consumer,
Great to know. Thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
