lhotari commented on a change in pull request #13376:
URL: https://github.com/apache/pulsar/pull/13376#discussion_r771172244



##########
File path: docker/pulsar/Dockerfile
##########
@@ -33,7 +33,13 @@ COPY scripts/pulsar-zookeeper-ruok.sh /pulsar/bin
 COPY scripts/watch-znode.py /pulsar/bin
 COPY scripts/install-pulsar-client.sh /pulsar/bin
 
-RUN mkdir /pulsar/data
+# In order to support running this docker image as a container on OpenShift
+# the final image needs to give the root group sufficient permission.
+# The file permissions are preserved when copying files from this builder 
image to the target image.
+RUN chmod -R g+w /pulsar/conf
+RUN mkdir /pulsar/data && chmod -R g+w /pulsar/data
+RUN mkdir /pulsar/logs && chmod -R g+w /pulsar/logs
+RUN chmod -R u-w /pulsar

Review comment:
       Now, when I looked at the full diff, I noticed that an intermediate 
container image is used, so the waste in the disk space doesn't really matter 
that much. I guess it will happen under the covers that 2x diskspace will be 
consumed as a result of `chmod -R u-w /pulsar` call. That won't carry on to the 
final Docker image since this an intermediate container image.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to