timmyyuan commented on a change in pull request #13376:
URL: https://github.com/apache/pulsar/pull/13376#discussion_r772068741



##########
File path: docker/pulsar/Dockerfile
##########
@@ -33,7 +33,13 @@ COPY scripts/pulsar-zookeeper-ruok.sh /pulsar/bin
 COPY scripts/watch-znode.py /pulsar/bin
 COPY scripts/install-pulsar-client.sh /pulsar/bin
 
-RUN mkdir /pulsar/data
+# In order to support running this docker image as a container on OpenShift
+# the final image needs to give the root group sufficient permission.
+# The file permissions are preserved when copying files from this builder 
image to the target image.
+RUN chmod -R g+w /pulsar/conf
+RUN mkdir /pulsar/data && chmod -R g+w /pulsar/data
+RUN mkdir /pulsar/logs && chmod -R g+w /pulsar/logs
+RUN chmod -R u-w /pulsar

Review comment:
       When executing the instruction `RUN chmod -R u-w /pulsar`, Docker will 
record the history of all files in `/pulsar` as an extra layer, which may cause 
the image size to become larger. Could you provide a comparison of the image 
size before and after the changes? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to