michaeljmarshall commented on a change in pull request #13376:
URL: https://github.com/apache/pulsar/pull/13376#discussion_r771527555
##########
File path: conf/bkenv.sh
##########
@@ -18,6 +18,8 @@
# under the License.
#
+# NOTE: this script is intentionally not executable. It is only meant to be
sourced for environment variables.
Review comment:
The `conf/bkenv.sh` file does not currently have execute permissions. It
is used in a few places with commands like:
```bash
source $BK_HOME/conf/bkenv.sh
```
and
```bash
# Check bookkeeper env and load bkenv.sh
if [ -f "$PULSAR_HOME/conf/bkenv.sh" ]
then
. "$PULSAR_HOME/conf/bkenv.sh"
fi
```
I added this note because it surprised me that a `.sh` file was in the
`conf` directory. If the note is obvious/confusing, I can remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
