addisonj opened a new pull request #14054:
URL: https://github.com/apache/pulsar/pull/14054
Previously, the Pulasr Proxy did not allow configuration of the number
of IO threads and acceptor threads in the proxy.
These options can be very important to tune, as is tuneable in the
broker, so this change simply matches the brokers perspective.
Also, we increase the default number of IO threads to 2x number of
processors instead of 1x, as in a single CPU config, it still makes
sense to have 2 threads, at least for now, where some blocking
operatings can happen (such as authn/authz plugins)
*(or if this PR is one task of a github issue, please add `Master Issue:
#<xyz>` to link to the master issue.)*
Master Issue: #<xyz>
### Motivation
Previously, the Pulasr Proxy did not allow configuration of the number
of IO threads and acceptor threads in the proxy.
These options can be very important to tune, as is tuneable in the
broker, so this change simply matches the brokers perspective.
### Modifications
This adds the options to tune threads to the proxy.
It also increases the default number of IO threads to 2x number of
processors instead of 1x, as in a single CPU config, it still makes
sense to have 2 threads, at least for now, where some blocking
operatings can happen (such as authn/authz plugins)
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): n
- The public API:n
- The schema: n
- The default values of configurations: y
- The wire protocol: n
- The rest endpoints: n
- The admin cli options: (n
- Anything that affects deployment: n
### Documentation
Javadoc is updated, but reference docs need updated as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
