addisonj commented on a change in pull request #14054:
URL: https://github.com/apache/pulsar/pull/14054#discussion_r795241678
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyService.java
##########
@@ -145,8 +143,10 @@ public ProxyService(ProxyConfiguration proxyConfig,
} else {
proxyLogLevel = 0;
}
- this.acceptorGroup = EventLoopUtil.newEventLoopGroup(1, false,
acceptorThreadFactory);
- this.workerGroup = EventLoopUtil.newEventLoopGroup(numThreads, false,
workersThreadFactory);
+ this.acceptorGroup =
EventLoopUtil.newEventLoopGroup(proxyConfig.getNumAcceptorThreads(),
+ false, acceptorThreadFactory);
+ this.workerGroup =
EventLoopUtil.newEventLoopGroup(proxyConfig.getNumIOThreads(),
Review comment:
I think we should move to the same default as the broker... primarily
because I don't think having a single IO thread is generally something we want
to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
