hangc0276 commented on a change in pull request #14054:
URL: https://github.com/apache/pulsar/pull/14054#discussion_r795141407
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyService.java
##########
@@ -145,8 +143,10 @@ public ProxyService(ProxyConfiguration proxyConfig,
} else {
proxyLogLevel = 0;
}
- this.acceptorGroup = EventLoopUtil.newEventLoopGroup(1, false,
acceptorThreadFactory);
- this.workerGroup = EventLoopUtil.newEventLoopGroup(numThreads, false,
workersThreadFactory);
+ this.acceptorGroup =
EventLoopUtil.newEventLoopGroup(proxyConfig.getNumAcceptorThreads(),
+ false, acceptorThreadFactory);
+ this.workerGroup =
EventLoopUtil.newEventLoopGroup(proxyConfig.getNumIOThreads(),
Review comment:
The previous default `numThreads` is
`Runtime.getRuntime().availableProcessors()`, but the current default
`numThreads` is `Runtime.getRuntime().availableProcessors()`. It has break the
default behavior. Do we need to keep the default value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
