ivankelly commented on a change in pull request #1059: Issue 1014: Rename
"global zookeeper" to "configuration-store"(change in code, conf and cli)
URL: https://github.com/apache/incubator-pulsar/pull/1059#discussion_r173124892
##########
File path: bin/pulsar
##########
@@ -209,6 +217,11 @@ elif [ $COMMAND == "global-zookeeper" ]; then
# Allow global ZK to turn into read-only mode when it cannot reach the
quorum
OPTS="${OPTS} -Dreadonlymode.enabled=true"
exec $JAVA $OPTS -Dpulsar.log.file=$PULSAR_LOG_FILE
org.apache.pulsar.zookeeper.GlobalZooKeeperStarter $PULSAR_GLOBAL_ZK_CONF $@
+elif [ $COMMAND == "configuration-store" ]; then
Review comment:
The only real difference between "global-zookeeper" and
"configuration-store" is that the log file changes. Do we care about keeping it
the same? In any case, they should both call ConfigurationStoreStarter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
