ivankelly commented on a change in pull request #1059: Issue 1014: Rename
"global zookeeper" to "configuration-store"(change in code, conf and cli)
URL: https://github.com/apache/incubator-pulsar/pull/1059#discussion_r173454361
##########
File path:
pulsar-discovery-service/src/main/java/org/apache/pulsar/discovery/service/server/DiscoveryServiceStarter.java
##########
@@ -40,6 +40,15 @@
*/
public class DiscoveryServiceStarter {
+ public static void checkConfig(ServiceConfig config) {
+ checkArgument(!isEmpty(config.getZookeeperServers()),
"zookeeperServers must be provided");
+ if(!isEmpty(config.getGlobalZookeeperServers()) &&
isEmpty(config.getConfigurationStoreServers())) {
Review comment:
This will never evaluate to true though, so you'd be better off putting it
in a checkArgument.
```
checkArgument(!isEmpty(config.getConfigurationStoreServers()) ||
isEmpty(config.getGlobalZookeeperServers()))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
