ivankelly commented on a change in pull request #1059: Issue 1014: Rename 
"global zookeeper" to "configuration-store"(change in code, conf and cli)
URL: https://github.com/apache/incubator-pulsar/pull/1059#discussion_r173123693
 
 

 ##########
 File path: 
pulsar-discovery-service/src/main/java/org/apache/pulsar/discovery/service/server/ServiceConfig.java
 ##########
 @@ -99,14 +102,24 @@ public void setZookeeperServers(String zookeeperServers) {
         this.zookeeperServers = zookeeperServers;
     }
 
+    @Deprecated
     public String getGlobalZookeeperServers() {
         return globalZookeeperServers;
     }
 
+    @Deprecated
     public void setGlobalZookeeperServers(String globalZookeeperServers) {
         this.globalZookeeperServers = globalZookeeperServers;
     }
 
+    public String getConfigurationStoreServers() {
+        return null == configurationStoreServers? getGlobalZookeeperServers() 
: configurationStoreServers;
 
 Review comment:
   add space before ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to