sijie commented on a change in pull request #1904: Introduce kinesis sink on
function
URL: https://github.com/apache/incubator-pulsar/pull/1904#discussion_r193205542
##########
File path: pulsar-broker/pom.xml
##########
@@ -274,6 +274,14 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>
+
+ <dependency>
Review comment:
it looks a bit strange to put connector in broker for testing purpose.
if you need some test cases from pulsar-broker, it would be much better that
pulsar-broker generates a test-jar. so pulsar-io-kinesis can use that test-jar
to write its test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
