sijie commented on a change in pull request #1904: Introduce kinesis sink on
function
URL: https://github.com/apache/incubator-pulsar/pull/1904#discussion_r193205692
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/FunctionsBase.java
##########
@@ -79,6 +79,28 @@ public Response registerFunction(final @PathParam("tenant")
String tenant,
return functions.registerFunction(
tenant, namespace, functionName, uploadedInputStream, fileDetail,
functionDetailsJson);
}
+
+
+ @POST
+ @ApiOperation(value = "Creates a new Pulsar Function in cluster mode")
+ @ApiResponses(value = {
+ @ApiResponse(code = 403, message = "The requester doesn't have
admin permissions"),
+ @ApiResponse(code = 400, message = "Invalid request (function
already exists, etc.)"),
+ @ApiResponse(code = 408, message = "Request timeout"),
+ @ApiResponse(code = 200, message = "Pulsar Function successfully
created")
+ })
+ @Path("/{tenant}/{namespace}/{functionName}/url")
+ @Consumes(MediaType.MULTIPART_FORM_DATA)
+ public Response registerFunction(final @PathParam("tenant") String tenant,
Review comment:
this change seems to be based on other PRs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services