sijie commented on a change in pull request #1904: Introduce kinesis sink on
function
URL: https://github.com/apache/incubator-pulsar/pull/1904#discussion_r193247608
##########
File path: pulsar-broker/pom.xml
##########
@@ -274,6 +274,14 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>
+
+ <dependency>
Review comment:
> having this e2e test help to find out many unknown issues and also help
testing while development.
yes, we need to have this e2e test. actually internally we have developed
the e2e tests using testcontainers (driven by @aahmed-se ), we will start
pushing out the integration tests to apache soon.
I think functions/proxy/websocket are kind of different from a specific
connector implementation. functions/proxy/websocket are generic components for
pulsar, which they are okay to be included in broker since they provides
different functionalities of pulsar. however kinesis connector is an
implementation of the pulsar I/O framework, which doesn't really belong to
broker component.
image you are a connector developer, you develop a connector system `xyz`.
are you expecting to put this connector into broker module and test it? or does
it sound better if the connector framework provides a test base, that you can
include in your connector code and test the connector using the test base.
hope this clarify my points here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
