jerrypeng commented on a change in pull request #1903: Support pulsar source to
start consumer with topic patterns
URL: https://github.com/apache/incubator-pulsar/pull/1903#discussion_r193257223
##########
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/JavaInstanceMain.java
##########
@@ -172,6 +175,7 @@ public void start() throws Exception {
}
sourceDetailsBuilder.setSubscriptionType(Function.SubscriptionType.valueOf(sourceSubscriptionType));
sourceDetailsBuilder.putAllTopicsToSerDeClassName(new
Gson().fromJson(sourceTopicsSerdeClassName, Map.class));
+ sourceDetailsBuilder.setTopicsPattern(topicsPattern);
Review comment:
since topicPattern is not set as a required field, this can be null. Can we
do a null check before setting?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
