jerrypeng commented on a change in pull request #1903: Support pulsar source to
start consumer with topic patterns
URL: https://github.com/apache/incubator-pulsar/pull/1903#discussion_r193257036
##########
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/ProcessRuntime.java
##########
@@ -169,6 +169,8 @@
args.add(instanceConfig.getFunctionDetails().getSource().getSubscriptionType().toString());
args.add("--source_topics_serde_classname");
args.add(new
Gson().toJson(instanceConfig.getFunctionDetails().getSource().getTopicsToSerDeClassNameMap()));
+ args.add("--topics_pattern");
Review comment:
can we do a empty string check here. No point adding this argument if its
empty
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
