jerrypeng commented on a change in pull request #1903: Support pulsar source to
start consumer with topic patterns
URL: https://github.com/apache/incubator-pulsar/pull/1903#discussion_r193610549
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -406,6 +413,10 @@ protected void validateFunctionConfigs(FunctionConfig
functionConfig) {
}
// make sure the function class loader is accessible
thread-locally
Thread.currentThread().setContextClassLoader(userJarLoader);
+ } else if (functionConfig.getRuntime() ==
FunctionConfig.Runtime.PYTHON) {
Review comment:
small nit:
can we move this check to here:
https://github.com/apache/incubator-pulsar/blob/master/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/validation/ValidatorImpls.java#L442
trying to put all the validation code as much in one place as we can so it
will be easier to find what is all checked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
