merlimat commented on a change in pull request #1996: Cpp client: add
multiTopicsConsumer
URL: https://github.com/apache/incubator-pulsar/pull/1996#discussion_r196844066
##########
File path: pulsar-client-cpp/include/pulsar/MessageId.h
##########
@@ -34,6 +34,16 @@ class MessageId {
MessageId& operator=(const MessageId&);
MessageId();
+ /**
+ * Only for MultiTopicsConsumer to set a valid topicName
+ */
+ void setTopicName(std::string topicName);
+
+ /**
+ * Only for MultiTopicsConsumer to get a valid topicName
+ */
+ std::string& getTopicName() const;
Review comment:
I wouldn't expose this in public API for `MessageId`. It's useful for
`Message` but, unless strictly needed, I'd leave it out from `MessasgeId`
interface
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
