merlimat commented on a change in pull request #1996: Cpp client: add
multiTopicsConsumer
URL: https://github.com/apache/incubator-pulsar/pull/1996#discussion_r196844496
##########
File path: pulsar-client-cpp/lib/MessageIdImpl.h
##########
@@ -22,15 +22,21 @@
#include <cstdint>
namespace pulsar {
+const static std::string emptyString = "";
class MessageIdImpl {
public:
- MessageIdImpl() : ledgerId_(-1), entryId_(-1), partition_(-1),
batchIndex_(-1) {}
+ MessageIdImpl() : ledgerId_(-1), entryId_(-1), partition_(-1),
batchIndex_(-1), topicName_(emptyString) {}
Review comment:
no need to use `emptyString`. initializing with `topicName_()` will have
same effect
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
