merlimat commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer URL: https://github.com/apache/incubator-pulsar/pull/1996#discussion_r197869634
########## File path: pulsar-client-cpp/include/pulsar/MessageId.h ########## @@ -22,13 +22,12 @@ #include <iosfwd> #include <stdint.h> #include <boost/shared_ptr.hpp> +#include <lib/MessageIdImpl.h> Review comment: We cannot include `lib/*.h` headers from public API. We need to just do the forward declaration ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
