merlimat commented on a change in pull request #1996: Cpp client: add
multiTopicsConsumer
URL: https://github.com/apache/incubator-pulsar/pull/1996#discussion_r197870965
##########
File path: pulsar-client-cpp/lib/MessageImpl.h
##########
@@ -43,13 +43,24 @@ class MessageImpl {
SharedBuffer payload;
MessageId messageId;
ClientConnection* cnx_;
+ std::string topicName_;
Review comment:
As an optimization, to avoid to create (and copy) the topic string object
for each message id, we could use a `std::string*` to store the name. This
would work if we pass a reference of the topic name held by the consumer
instance, which will be valid.
The `getTopicName()` would still have the same signature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
