ivankelly commented on a change in pull request #2151: GCS offload support(3): add configs to support GCS driver URL: https://github.com/apache/incubator-pulsar/pull/2151#discussion_r204673118
########## File path: conf/broker.conf ########## @@ -487,6 +487,8 @@ schemaRegistryStorageClassName=org.apache.pulsar.broker.service.schema.Bookkeepe ### --- Ledger Offloading --- ### # Driver to use to offload old data to long term storage (Possible values: S3, aws-s3, google-cloud-storage) +# When using gcs, Make sure both Google Cloud Storage and Google Cloud Storage JSON API are enabled for Review comment: nit: gcs -> google-cloud-storage, though maybe it would be better to rename the driver gcs, as the options for it are prefixed with gcs. nit: Make -> make ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
