ivankelly commented on a change in pull request #2151: GCS offload support(3):
add configs to support GCS driver
URL: https://github.com/apache/incubator-pulsar/pull/2151#discussion_r204691510
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/offload/impl/BlobStoreManagedLedgerOffloaderTest.java
##########
@@ -179,6 +180,56 @@ public void testSmallBlockSizeConfigured() throws
Exception {
}
}
+ @Test
+ public void testGcsNoKeyPath() throws Exception {
+ ServiceConfiguration conf = new ServiceConfiguration();
+ conf.setManagedLedgerOffloadDriver("google-cloud-storage");
+ conf.setGcsManagedLedgerOffloadBucket(BUCKET);
+
+ try {
+ BlobStoreManagedLedgerOffloader.create(conf, scheduler);
+ Assert.fail("Should have thrown exception");
+ } catch (PulsarServerException pse) {
+ // correct
+ log.error("expect pse", pse);
+ }
+ }
+
+ @Test
+ public void testGcsNoBucketConfigured() throws Exception {
+ ServiceConfiguration conf = new ServiceConfiguration();
+ conf.setManagedLedgerOffloadDriver("google-cloud-storage");
+
//conf.setGcsManagedLedgerOffloadServiceAccountKeyFile("~/Downloads/project-804d5e6a6f33.json");
Review comment:
Don't commit commented out code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
