ivankelly commented on a change in pull request #2151: GCS offload support(3):
add configs to support GCS driver
URL: https://github.com/apache/incubator-pulsar/pull/2151#discussion_r204688029
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -502,6 +502,24 @@
@FieldContext(minValue = 1024)
private int s3ManagedLedgerOffloadReadBufferSizeInBytes = 1024 * 1024; //
1MB
+ // For Google Cloud Storage ledger offload, AWS region
+ private String gcsManagedLedgerOffloadRegion = null;
+
+ // For Google Cloud Storage ledger offload, Bucket to place offloaded
ledger into
+ private String gcsManagedLedgerOffloadBucket = null;
+
+ // For Google Cloud Storage ledger offload, Max block size in bytes.
+ @FieldContext(minValue = 5242880) // 5MB
+ private int gcsManagedLedgerOffloadMaxBlockSizeInBytes = 64 * 1024 * 1024;
// 64MB
+
+ // For Google Cloud Storage ledger offload, Read buffer size in bytes.
+ @FieldContext(minValue = 1024)
+ private int gcsManagedLedgerOffloadReadBufferSizeInBytes = 1024 * 1024; //
1MB
+
+ // For Google Cloud Storage credentials of service account key path
+ // reference this page for more details of service account key:
https://support.google.com/googleapi/answer/6158849
Review comment:
All comments from conf file also apply here, though I'm not sure if this
comments are even useful. We should probably just group them all together and
point user to broker.conf if they want details, as they will never update the
values in this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
