http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/MergingIterator.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/MergingIterator.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/MergingIterator.java index 1cc685a..a0a80f2 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/MergingIterator.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/MergingIterator.java @@ -28,12 +28,12 @@ import java.util.PriorityQueue; public class MergingIterator<T> implements Iterator<T> { private final PriorityQueue<Tuple<T, Iterator<T>>> heap; - public MergingIterator(final Comparator<T> c, Iterator<T>[] its) { + public MergingIterator(final Comparator<T> c, final Iterator<T>[] its) { this.heap = new PriorityQueue<Tuple<T, Iterator<T>>>(11, new TupleKeyComparator<T, Iterator<T>>(c)); - for (Iterator<T> it : its) { - T b = it.hasNext() ? it.next() : null; + for (final Iterator<T> it : its) { + final T b = it.hasNext() ? it.next() : null; if (b != null) { heap.add(new Tuple<>(b, it)); } @@ -47,7 +47,7 @@ public class MergingIterator<T> implements Iterator<T> { @Override public T next() { - Tuple<T, Iterator<T>> ret = heap.remove(); + final Tuple<T, Iterator<T>> ret = heap.remove(); if (ret.getValue().hasNext()) { heap.add(new Tuple<>(ret.getValue().next(), ret.getValue())); }
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/LocalScratchSpace.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/LocalScratchSpace.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/LocalScratchSpace.java index feee1e9..a3ea45f 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/LocalScratchSpace.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/LocalScratchSpace.java @@ -35,13 +35,13 @@ public class LocalScratchSpace implements ScratchSpace { */ private long quota; - public LocalScratchSpace(String jobName, String evaluatorName) { + public LocalScratchSpace(final String jobName, final String evaluatorName) { this.jobName = jobName; this.evaluatorName = evaluatorName; this.quota = 0; } - public LocalScratchSpace(String jobName, String evaluatorName, long quota) { + public LocalScratchSpace(final String jobName, final String evaluatorName, final long quota) { this.jobName = jobName; this.evaluatorName = evaluatorName; this.quota = quota; @@ -52,7 +52,7 @@ public class LocalScratchSpace implements ScratchSpace { try { ret = File.createTempFile("reef-" + jobName + "-" + evaluatorName, "tmp"); - } catch (IOException e) { + } catch (final IOException e) { throw new RuntimeException(e); } tempFiles.add(ret); @@ -67,7 +67,7 @@ public class LocalScratchSpace implements ScratchSpace { @Override public long usedSpace() { long ret = 0; - for (File f : tempFiles) { + for (final File f : tempFiles) { // TODO: Error handling... ret += f.length(); } @@ -78,7 +78,7 @@ public class LocalScratchSpace implements ScratchSpace { public void delete() { // TODO: Error handling. Files.delete() would give us an exception. We // should pass a set of Exceptions into a ReefRuntimeException. - for (File f : tempFiles) { + for (final File f : tempFiles) { f.delete(); } tempFiles.clear(); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/LocalStorageService.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/LocalStorageService.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/LocalStorageService.java index 3dc55c3..f51b657 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/LocalStorageService.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/LocalStorageService.java @@ -29,7 +29,7 @@ public class LocalStorageService implements StorageService { private final LocalScratchSpace scratchSpace; - public LocalStorageService(String jobName, String evaluatorName) { + public LocalStorageService(final String jobName, final String evaluatorName) { this.jobName = jobName; this.evaluatorName = evaluatorName; this.scratchSpace = new LocalScratchSpace(jobName, evaluatorName); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/SerializerFileSpool.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/SerializerFileSpool.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/SerializerFileSpool.java index aa46aa7..fd77c36 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/SerializerFileSpool.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/SerializerFileSpool.java @@ -47,7 +47,7 @@ public final class SerializerFileSpool<T> implements Spool<T> { final Serializer<T, OutputStream> out, final Deserializer<T, InputStream> in) throws ServiceException { this.file = service.getScratchSpace().newFile(); - Accumulable<T> accumulable; + final Accumulable<T> accumulable; try { accumulable = out.create(new BufferedOutputStream(new FileOutputStream( file))); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/CodecRamMap.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/CodecRamMap.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/CodecRamMap.java index d93750e..b4885a5 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/CodecRamMap.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/CodecRamMap.java @@ -36,7 +36,7 @@ public class CodecRamMap<T> implements ExternalMap<T> { private final ConcurrentSkipListMap<CharSequence, byte[]> map; @Inject - public CodecRamMap(RamStorageService ramStore, + public CodecRamMap(final RamStorageService ramStore, @Parameter(RamMapCodec.class) final Codec<T> c) { this.c = c; this.map = new ConcurrentSkipListMap<CharSequence, byte[]>(); @@ -54,7 +54,7 @@ public class CodecRamMap<T> implements ExternalMap<T> { } @Override - public T put(final CharSequence key, T value) { + public T put(final CharSequence key, final T value) { final byte[] ret = map.put(key, c.encode(value)); return ret != null ? c.decode(ret) : null; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/RamMap.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/RamMap.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/RamMap.java index 5c3e14c..5636c9e 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/RamMap.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/RamMap.java @@ -37,36 +37,36 @@ public class RamMap<T> implements ExternalMap<T> { private final ConcurrentSkipListMap<CharSequence, T> map = new ConcurrentSkipListMap<CharSequence, T>(); @Inject - public RamMap(RamStorageService ramStore) { + public RamMap(final RamStorageService ramStore) { } @Override - public boolean containsKey(CharSequence key) { + public boolean containsKey(final CharSequence key) { return map.containsKey(key); } @Override - public T get(CharSequence key) { + public T get(final CharSequence key) { return map.get(key); } @Override - public T put(CharSequence key, T value) { + public T put(final CharSequence key, final T value) { return map.put(key, value); } @Override - public T remove(CharSequence key) { + public T remove(final CharSequence key) { return map.remove(key); } @Override - public void putAll(Map<? extends CharSequence, ? extends T> m) { + public void putAll(final Map<? extends CharSequence, ? extends T> m) { map.putAll(m); } @Override - public Iterable<Entry<CharSequence, T>> getAll(Set<? extends CharSequence> keys) { + public Iterable<Entry<CharSequence, T>> getAll(final Set<? extends CharSequence> keys) { return new GetAllIterable<>(keys, this); } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/RamSpool.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/RamSpool.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/RamSpool.java index 8b7f9eb..1b82739 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/RamSpool.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/RamSpool.java @@ -39,7 +39,7 @@ public final class RamSpool<T> implements Spool<T> { private boolean canGetAccumulator = true; @Inject - public RamSpool(RamStorageService ramStore) { + public RamSpool(final RamStorageService ramStore) { } @Override @@ -56,7 +56,7 @@ public final class RamSpool<T> implements Spool<T> { canGetAccumulator = false; return new Accumulator<T>() { @Override - public void add(T datum) { + public void add(final T datum) { if (!canAppend) { throw new ConcurrentModificationException("Attempt to append after creating iterator!"); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/SortingRamSpool.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/SortingRamSpool.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/SortingRamSpool.java index 1ba55f4..b8c4711 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/SortingRamSpool.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/SortingRamSpool.java @@ -31,7 +31,7 @@ public class SortingRamSpool<T> implements Spool<T> { private boolean ready = false; private Accumulator<T> acc = new Accumulator<T>() { @Override - public void add(T datum) throws StorageException { + public void add(final T datum) throws StorageException { if (ready) { throw new IllegalStateException("add called after close!"); } @@ -67,7 +67,7 @@ public class SortingRamSpool<T> implements Spool<T> { heap = new PriorityQueue<>(); } - public SortingRamSpool(Comparator<T> c) { + public SortingRamSpool(final Comparator<T> c) { heap = new PriorityQueue<>(11, c); } @@ -76,14 +76,14 @@ public class SortingRamSpool<T> implements Spool<T> { if (!ready) { throw new IllegalStateException("Cannot call iterator() while accumulator is still open!"); } - Iterator<T> ret = it; + final Iterator<T> ret = it; it = null; return ret; } @Override public Accumulator<T> accumulator() throws StorageException { - Accumulator<T> ret = acc; + final Accumulator<T> ret = acc; acc = null; return ret; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/GetAllIterable.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/GetAllIterable.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/GetAllIterable.java index 8be1b37..a8d1665 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/GetAllIterable.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/GetAllIterable.java @@ -30,7 +30,7 @@ public class GetAllIterable<T> implements private final Set<? extends CharSequence> keys; private final ExternalMap<T> map; - public GetAllIterable(Set<? extends CharSequence> keys, ExternalMap<T> map) { + public GetAllIterable(final Set<? extends CharSequence> keys, final ExternalMap<T> map) { this.keys = keys; this.map = map; } @@ -44,7 +44,7 @@ public class GetAllIterable<T> implements private CharSequence findNextKey() { while (k.hasNext()) { - CharSequence next = k.next(); + final CharSequence next = k.next(); if (map.containsKey(next)) { return next; } @@ -80,7 +80,7 @@ public class GetAllIterable<T> implements } @Override - public T setValue(T v) { + public T setValue(final T v) { throw new UnsupportedOperationException( "No support for mutating values via iterator"); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerCodec.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerCodec.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerCodec.java index 65d760d..94b496a 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerCodec.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerCodec.java @@ -23,12 +23,12 @@ import org.apache.reef.io.serialization.Codec; public class IntegerCodec implements Codec<Integer> { @Override - public byte[] encode(Integer obj) { + public byte[] encode(final Integer obj) { return Integer.toString(obj).getBytes(); } @Override - public Integer decode(byte[] buf) { + public Integer decode(final byte[] buf) { return Integer.decode(new String(buf)); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerDeserializer.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerDeserializer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerDeserializer.java index 1d81111..a404bed 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerDeserializer.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerDeserializer.java @@ -29,7 +29,7 @@ import java.util.Iterator; public class IntegerDeserializer implements Deserializer<Integer, InputStream> { @Override - public Iterable<Integer> create(InputStream arg) { + public Iterable<Integer> create(final InputStream arg) { final DataInputStream dis = new DataInputStream(arg); return new Iterable<Integer>() { @@ -46,7 +46,7 @@ public class IntegerDeserializer implements public Integer next() { try { return dis.readInt(); - } catch (IOException e) { + } catch (final IOException e) { throw new ServiceRuntimeException(e); } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerSerializer.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerSerializer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerSerializer.java index 4b27f7c..44b4eff 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerSerializer.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerSerializer.java @@ -30,7 +30,7 @@ import java.io.OutputStream; public class IntegerSerializer implements Serializer<Integer, OutputStream> { @Override - public Accumulable<Integer> create(OutputStream arg) { + public Accumulable<Integer> create(final OutputStream arg) { final DataOutputStream dos = new DataOutputStream(arg); return new Accumulable<Integer>() { @@ -38,10 +38,10 @@ public class IntegerSerializer implements public Accumulator<Integer> accumulator() throws ServiceException { return new Accumulator<Integer>() { @Override - public void add(Integer datum) throws ServiceException { + public void add(final Integer datum) throws ServiceException { try { dos.writeInt(datum); - } catch (IOException e) { + } catch (final IOException e) { throw new ServiceException(e); } } @@ -50,7 +50,7 @@ public class IntegerSerializer implements public void close() throws ServiceException { try { dos.close(); - } catch (IOException e) { + } catch (final IOException e) { throw new ServiceException(e); } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/StringDeserializer.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/StringDeserializer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/StringDeserializer.java index 5f0c31a..1016016 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/StringDeserializer.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/StringDeserializer.java @@ -29,7 +29,7 @@ import java.util.Iterator; public class StringDeserializer implements Deserializer<String, InputStream> { @Override - public Iterable<String> create(InputStream arg) { + public Iterable<String> create(final InputStream arg) { final DataInputStream dis = new DataInputStream(arg); return new Iterable<String>() { @@ -47,10 +47,10 @@ public class StringDeserializer implements int len = 0; try { len = dis.readInt(); - byte[] b = new byte[len]; + final byte[] b = new byte[len]; dis.readFully(b); return new String(b); - } catch (IOException e) { + } catch (final IOException e) { throw new ServiceRuntimeException(e); } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/StringSerializer.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/StringSerializer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/StringSerializer.java index da06486..cc61ea6 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/StringSerializer.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/StringSerializer.java @@ -30,7 +30,7 @@ import java.io.OutputStream; public class StringSerializer implements Serializer<String, OutputStream> { @Override - public Accumulable<String> create(OutputStream arg) { + public Accumulable<String> create(final OutputStream arg) { final DataOutputStream dos = new DataOutputStream(arg); return new Accumulable<String>() { @@ -39,12 +39,12 @@ public class StringSerializer implements return new Accumulator<String>() { @Override - public void add(String datum) throws ServiceException { - byte[] b = datum.getBytes(); + public void add(final String datum) throws ServiceException { + final byte[] b = datum.getBytes(); try { dos.writeInt(b.length); dos.write(b); - } catch (IOException e) { + } catch (final IOException e) { throw new ServiceException(e); } @@ -54,7 +54,7 @@ public class StringSerializer implements public void close() throws ServiceException { try { dos.close(); - } catch (IOException e) { + } catch (final IOException e) { throw new ServiceException(e); } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/TupleKeyComparator.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/TupleKeyComparator.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/TupleKeyComparator.java index 8951e4a..13c2b15 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/TupleKeyComparator.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/TupleKeyComparator.java @@ -26,12 +26,12 @@ public final class TupleKeyComparator<K, V> implements Comparator<Tuple<K, V>> { private final Comparator<K> c; - public TupleKeyComparator(Comparator<K> c) { + public TupleKeyComparator(final Comparator<K> c) { this.c = c; } @Override - public int compare(Tuple<K, V> o1, Tuple<K, V> o2) { + public int compare(final Tuple<K, V> o1, final Tuple<K, V> o2) { return c.compare(o1.getKey(), o2.getKey()); } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NameClientTest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NameClientTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NameClientTest.java index d4afd3e..a0b7997 100644 --- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NameClientTest.java +++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NameClientTest.java @@ -50,11 +50,11 @@ public class NameClientTest { static int retryCount, retryTimeout; static { - Tang tang = Tang.Factory.getTang(); + final Tang tang = Tang.Factory.getTang(); try { retryCount = tang.newInjector().getNamedInstance(NameResolverRetryCount.class); retryTimeout = tang.newInjector().getNamedInstance(NameResolverRetryTimeout.class); - } catch (InjectionException e1) { + } catch (final InjectionException e1) { throw new RuntimeException("Exception while trying to find default values for retryCount & Timeout", e1); } } @@ -87,7 +87,7 @@ public class NameClientTest { injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider); try (final NameServer server = injector.getInstance(NameServer.class)) { - int serverPort = server.getPort(); + final int serverPort = server.getPort(); final Configuration nameResolverConf = NameResolverConfiguration.CONF .set(NameResolverConfiguration.NAME_SERVER_HOSTNAME, localAddress) .set(NameResolverConfiguration.NAME_SERVICE_PORT, serverPort) @@ -122,7 +122,7 @@ public class NameClientTest { injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider); try (final NameServer server = injector.getInstance(NameServer.class)) { - int serverPort = server.getPort(); + final int serverPort = server.getPort(); final Configuration nameResolverConf = NameResolverConfiguration.CONF .set(NameResolverConfiguration.NAME_SERVER_HOSTNAME, localAddress) .set(NameResolverConfiguration.NAME_SERVICE_PORT, serverPort) @@ -147,7 +147,7 @@ public class NameClientTest { //resulting in NamingException and the test passes addr = client.lookup(id); Assert.assertNull("client.lookup(id)", addr); - } catch (Exception e) { + } catch (final Exception e) { if (e instanceof ExecutionException) { Assert.assertTrue("Execution Exception cause is instanceof NamingException", e.getCause() instanceof NamingException); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NamingTest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NamingTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NamingTest.java index 6137155..472dde3 100644 --- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NamingTest.java +++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NamingTest.java @@ -110,9 +110,9 @@ public class NamingTest { final Identifier id2 = this.factory.getNewInstance("task2"); final Map<Identifier, InetSocketAddress> respMap = new HashMap<Identifier, InetSocketAddress>(); - InetSocketAddress addr1 = client.lookup(id1); + final InetSocketAddress addr1 = client.lookup(id1); respMap.put(id1, addr1); - InetSocketAddress addr2 = client.lookup(id2); + final InetSocketAddress addr2 = client.lookup(id2); respMap.put(id2, addr2); for (final Identifier id : respMap.keySet()) { @@ -311,7 +311,7 @@ public class NamingTest { // registration // invoke registration from the client side - Configuration nameResolverConf = NameResolverConfiguration.CONF + final Configuration nameResolverConf = NameResolverConfiguration.CONF .set(NameResolverConfiguration.NAME_SERVER_HOSTNAME, localAddress) .set(NameResolverConfiguration.NAME_SERVICE_PORT, this.port) .set(NameResolverConfiguration.CACHE_TIMEOUT, this.TTL) http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NetworkConnectionServiceTest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NetworkConnectionServiceTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NetworkConnectionServiceTest.java index e9c903c..6bc0ac9 100644 --- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NetworkConnectionServiceTest.java +++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NetworkConnectionServiceTest.java @@ -61,7 +61,7 @@ public class NetworkConnectionServiceTest { @Rule public TestName name = new TestName(); - private void runMessagingNetworkConnectionService(Codec<String> codec) throws Exception { + private void runMessagingNetworkConnectionService(final Codec<String> codec) throws Exception { final int numMessages = 2000; final Monitor monitor = new Monitor(); try (final NetworkMessagingTestService messagingTestService = new NetworkMessagingTestService(localAddress)) { @@ -75,7 +75,7 @@ public class NetworkConnectionServiceTest { conn.write("hello" + count); } monitor.mwait(); - } catch (NetworkException e) { + } catch (final NetworkException e) { e.printStackTrace(); throw new RuntimeException(e); } @@ -101,7 +101,8 @@ public class NetworkConnectionServiceTest { runMessagingNetworkConnectionService(new StreamingStringCodec()); } - public void runNetworkConnServiceWithMultipleConnFactories(Codec<String> stringCodec, Codec<Integer> integerCodec) + public void runNetworkConnServiceWithMultipleConnFactories(final Codec<String> stringCodec, + final Codec<Integer> integerCodec) throws Exception { final ExecutorService executor = Executors.newFixedThreadPool(5); @@ -126,7 +127,7 @@ public class NetworkConnectionServiceTest { conn.write("hello" + count); } monitor.mwait(); - } catch (Exception e) { + } catch (final Exception e) { e.printStackTrace(); throw new RuntimeException(e); } @@ -144,7 +145,7 @@ public class NetworkConnectionServiceTest { conn.write(count); } monitor2.mwait(); - } catch (Exception e) { + } catch (final Exception e) { e.printStackTrace(); throw new RuntimeException(e); } @@ -183,7 +184,7 @@ public class NetworkConnectionServiceTest { LOG.log(Level.FINEST, name.getMethodName()); final int[] messageSizes = {1, 16, 32, 64, 512, 64 * 1024, 1024 * 1024}; - for (int size : messageSizes) { + for (final int size : messageSizes) { final int numMessages = 300000 / (Math.max(1, size / 512)); final Monitor monitor = new Monitor(); final Codec<String> codec = new StringCodec(); @@ -200,7 +201,7 @@ public class NetworkConnectionServiceTest { try (final Connection<String> conn = messagingTestService.getConnectionFromSenderToReceiver(groupCommClientId)) { - long start = System.currentTimeMillis(); + final long start = System.currentTimeMillis(); try { conn.open(); for (int count = 0; count < numMessages; ++count) { @@ -208,7 +209,7 @@ public class NetworkConnectionServiceTest { conn.write(message); } monitor.mwait(); - } catch (NetworkException e) { + } catch (final NetworkException e) { e.printStackTrace(); throw new RuntimeException(e); } @@ -263,12 +264,12 @@ public class NetworkConnectionServiceTest { conn.write(message); } monitor.mwait(); - } catch (NetworkException e) { + } catch (final NetworkException e) { e.printStackTrace(); throw new RuntimeException(e); } } - } catch (Exception e) { + } catch (final Exception e) { throw new RuntimeException(e); } } @@ -294,7 +295,7 @@ public class NetworkConnectionServiceTest { LOG.log(Level.FINEST, name.getMethodName()); final int[] messageSizes = {2000}; // {1,16,32,64,512,64*1024,1024*1024}; - for (int size : messageSizes) { + for (final int size : messageSizes) { final int numMessages = 300000 / (Math.max(1, size / 512)); final int numThreads = 2; final int totalNumMessages = numMessages * numThreads; @@ -326,7 +327,7 @@ public class NetworkConnectionServiceTest { // send messages to the receiver. conn.write(message); } - } catch (Exception e) { + } catch (final Exception e) { throw new RuntimeException(e); } } @@ -355,7 +356,7 @@ public class NetworkConnectionServiceTest { final int batchSize = 1024 * 1024; final int[] messageSizes = {32, 64, 512}; - for (int size : messageSizes) { + for (final int size : messageSizes) { final int numMessages = 300 / (Math.max(1, size / 512)); final Monitor monitor = new Monitor(); final Codec<String> codec = new StringCodec(); @@ -382,7 +383,7 @@ public class NetworkConnectionServiceTest { conn.write(sb.toString()); } monitor.mwait(); - } catch (NetworkException e) { + } catch (final NetworkException e) { e.printStackTrace(); throw new RuntimeException(e); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NetworkServiceTest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NetworkServiceTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NetworkServiceTest.java index 85b2860..6045be2 100644 --- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NetworkServiceTest.java +++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NetworkServiceTest.java @@ -70,14 +70,14 @@ public class NetworkServiceTest { public void testMessagingNetworkService() throws Exception { LOG.log(Level.FINEST, name.getMethodName()); - IdentifierFactory factory = new StringIdentifierFactory(); + final IdentifierFactory factory = new StringIdentifierFactory(); final Injector injector = Tang.Factory.getTang().newInjector(); injector.bindVolatileParameter(NameServerParameters.NameServerIdentifierFactory.class, factory); injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider); try (final NameServer server = injector.getInstance(NameServer.class)) { - int nameServerPort = server.getPort(); + final int nameServerPort = server.getPort(); final int numMessages = 10; final Monitor monitor = new Monitor(); @@ -121,7 +121,7 @@ public class NetworkServiceTest { } monitor.mwait(); - } catch (NetworkException e) { + } catch (final NetworkException e) { e.printStackTrace(); throw new RuntimeException(e); } @@ -136,18 +136,18 @@ public class NetworkServiceTest { public void testMessagingNetworkServiceRate() throws Exception { LOG.log(Level.FINEST, name.getMethodName()); - IdentifierFactory factory = new StringIdentifierFactory(); + final IdentifierFactory factory = new StringIdentifierFactory(); final Injector injector = Tang.Factory.getTang().newInjector(); injector.bindVolatileParameter(NameServerParameters.NameServerIdentifierFactory.class, factory); injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider); try (final NameServer server = injector.getInstance(NameServer.class)) { - int nameServerPort = server.getPort(); + final int nameServerPort = server.getPort(); final int[] messageSizes = {1, 16, 32, 64, 512, 64 * 1024, 1024 * 1024}; - for (int size : messageSizes) { + for (final int size : messageSizes) { final int numMessages = 300000 / (Math.max(1, size / 512)); final Monitor monitor = new Monitor(); @@ -181,28 +181,28 @@ public class NetworkServiceTest { final int port1 = ns1.getTransport().getListeningPort(); server.register(factory.getNewInstance("task1"), new InetSocketAddress(this.localAddress, port1)); - Identifier destId = factory.getNewInstance(name2); + final Identifier destId = factory.getNewInstance(name2); // build the message - StringBuilder msb = new StringBuilder(); + final StringBuilder msb = new StringBuilder(); for (int i = 0; i < size; i++) { msb.append("1"); } - String message = msb.toString(); + final String message = msb.toString(); - long start = System.currentTimeMillis(); + final long start = System.currentTimeMillis(); try (Connection<String> conn = ns1.newConnection(destId)) { for (int i = 0; i < numMessages; i++) { conn.open(); conn.write(message); } monitor.mwait(); - } catch (NetworkException e) { + } catch (final NetworkException e) { e.printStackTrace(); throw new RuntimeException(e); } - long end = System.currentTimeMillis(); - double runtime = ((double) end - start) / 1000; + final long end = System.currentTimeMillis(); + final double runtime = ((double) end - start) / 1000; LOG.log(Level.FINEST, "size: " + size + "; messages/s: " + numMessages / runtime + " bandwidth(bytes/s): " + ((double) numMessages * 2 * size) / runtime); // x2 for unicode chars } @@ -226,14 +226,14 @@ public class NetworkServiceTest { try (final NameServer server = injector.getInstance(NameServer.class)) { final int nameServerPort = server.getPort(); - BlockingQueue<Object> barrier = new LinkedBlockingQueue<Object>(); + final BlockingQueue<Object> barrier = new LinkedBlockingQueue<Object>(); - int numThreads = 4; + final int numThreads = 4; final int size = 2000; final int numMessages = 300000 / (Math.max(1, size / 512)); final int totalNumMessages = numMessages * numThreads; - ExecutorService e = Executors.newCachedThreadPool(); + final ExecutorService e = Executors.newCachedThreadPool(); for (int t = 0; t < numThreads; t++) { final int tt = t; @@ -241,7 +241,7 @@ public class NetworkServiceTest { @Override public void run() { try { - Monitor monitor = new Monitor(); + final Monitor monitor = new Monitor(); // network service final String name2 = "task2-" + tt; @@ -274,14 +274,14 @@ public class NetworkServiceTest { final int port1 = ns1.getTransport().getListeningPort(); server.register(factory.getNewInstance(name1), new InetSocketAddress(localAddress, port1)); - Identifier destId = factory.getNewInstance(name2); + final Identifier destId = factory.getNewInstance(name2); // build the message - StringBuilder msb = new StringBuilder(); + final StringBuilder msb = new StringBuilder(); for (int i = 0; i < size; i++) { msb.append("1"); } - String message = msb.toString(); + final String message = msb.toString(); try (Connection<String> conn = ns1.newConnection(destId)) { for (int i = 0; i < numMessages; i++) { @@ -289,12 +289,12 @@ public class NetworkServiceTest { conn.write(message); } monitor.mwait(); - } catch (NetworkException e) { + } catch (final NetworkException e) { e.printStackTrace(); throw new RuntimeException(e); } } - } catch (Exception e) { + } catch (final Exception e) { e.printStackTrace(); throw new RuntimeException(e); } @@ -303,16 +303,16 @@ public class NetworkServiceTest { } // start and time - long start = System.currentTimeMillis(); - Object ignore = new Object(); + final long start = System.currentTimeMillis(); + final Object ignore = new Object(); for (int i = 0; i < numThreads; i++) { barrier.add(ignore); } e.shutdown(); e.awaitTermination(100, TimeUnit.SECONDS); - long end = System.currentTimeMillis(); + final long end = System.currentTimeMillis(); - double runtime = ((double) end - start) / 1000; + final double runtime = ((double) end - start) / 1000; LOG.log(Level.FINEST, "size: " + size + "; messages/s: " + totalNumMessages / runtime + " bandwidth(bytes/s): " + ((double) totalNumMessages * 2 * size) / runtime); // x2 for unicode chars } @@ -322,20 +322,20 @@ public class NetworkServiceTest { public void testMultithreadedSharedConnMessagingNetworkServiceRate() throws Exception { LOG.log(Level.FINEST, name.getMethodName()); - IdentifierFactory factory = new StringIdentifierFactory(); + final IdentifierFactory factory = new StringIdentifierFactory(); final Injector injector = Tang.Factory.getTang().newInjector(); injector.bindVolatileParameter(NameServerParameters.NameServerIdentifierFactory.class, factory); injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider); try (final NameServer server = injector.getInstance(NameServer.class)) { - int nameServerPort = server.getPort(); + final int nameServerPort = server.getPort(); final int[] messageSizes = {2000}; // {1,16,32,64,512,64*1024,1024*1024}; - for (int size : messageSizes) { + for (final int size : messageSizes) { final int numMessages = 300000 / (Math.max(1, size / 512)); - int numThreads = 2; - int totalNumMessages = numMessages * numThreads; + final int numThreads = 2; + final int totalNumMessages = numMessages * numThreads; final Monitor monitor = new Monitor(); @@ -370,21 +370,21 @@ public class NetworkServiceTest { final int port1 = ns1.getTransport().getListeningPort(); server.register(factory.getNewInstance("task1"), new InetSocketAddress(this.localAddress, port1)); - Identifier destId = factory.getNewInstance(name2); + final Identifier destId = factory.getNewInstance(name2); try (final Connection<String> conn = ns1.newConnection(destId)) { conn.open(); // build the message - StringBuilder msb = new StringBuilder(); + final StringBuilder msb = new StringBuilder(); for (int i = 0; i < size; i++) { msb.append("1"); } final String message = msb.toString(); - ExecutorService e = Executors.newCachedThreadPool(); + final ExecutorService e = Executors.newCachedThreadPool(); - long start = System.currentTimeMillis(); + final long start = System.currentTimeMillis(); for (int i = 0; i < numThreads; i++) { e.submit(new Runnable() { @@ -402,8 +402,8 @@ public class NetworkServiceTest { e.awaitTermination(30, TimeUnit.SECONDS); monitor.mwait(); - long end = System.currentTimeMillis(); - double runtime = ((double) end - start) / 1000; + final long end = System.currentTimeMillis(); + final double runtime = ((double) end - start) / 1000; LOG.log(Level.FINEST, "size: " + size + "; messages/s: " + totalNumMessages / runtime + " bandwidth(bytes/s): " + ((double) totalNumMessages * 2 * size) / runtime); // x2 for unicode chars @@ -420,19 +420,19 @@ public class NetworkServiceTest { public void testMessagingNetworkServiceBatchingRate() throws Exception { LOG.log(Level.FINEST, name.getMethodName()); - IdentifierFactory factory = new StringIdentifierFactory(); + final IdentifierFactory factory = new StringIdentifierFactory(); final Injector injector = Tang.Factory.getTang().newInjector(); injector.bindVolatileParameter(NameServerParameters.NameServerIdentifierFactory.class, factory); injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider); try (final NameServer server = injector.getInstance(NameServer.class)) { - int nameServerPort = server.getPort(); + final int nameServerPort = server.getPort(); final int batchSize = 1024 * 1024; final int[] messageSizes = {32, 64, 512}; - for (int size : messageSizes) { + for (final int size : messageSizes) { final int numMessages = 300 / (Math.max(1, size / 512)); final Monitor monitor = new Monitor(); @@ -466,19 +466,19 @@ public class NetworkServiceTest { final int port1 = ns1.getTransport().getListeningPort(); server.register(factory.getNewInstance("task1"), new InetSocketAddress(this.localAddress, port1)); - Identifier destId = factory.getNewInstance(name2); + final Identifier destId = factory.getNewInstance(name2); // build the message - StringBuilder msb = new StringBuilder(); + final StringBuilder msb = new StringBuilder(); for (int i = 0; i < size; i++) { msb.append("1"); } - String message = msb.toString(); + final String message = msb.toString(); - long start = System.currentTimeMillis(); + final long start = System.currentTimeMillis(); try (Connection<String> conn = ns1.newConnection(destId)) { for (int i = 0; i < numMessages; i++) { - StringBuilder sb = new StringBuilder(); + final StringBuilder sb = new StringBuilder(); for (int j = 0; j < batchSize / size; j++) { sb.append(message); } @@ -486,13 +486,13 @@ public class NetworkServiceTest { conn.write(sb.toString()); } monitor.mwait(); - } catch (NetworkException e) { + } catch (final NetworkException e) { e.printStackTrace(); throw new RuntimeException(e); } - long end = System.currentTimeMillis(); - double runtime = ((double) end - start) / 1000; - long numAppMessages = numMessages * batchSize / size; + final long end = System.currentTimeMillis(); + final double runtime = ((double) end - start) / 1000; + final long numAppMessages = numMessages * batchSize / size; LOG.log(Level.FINEST, "size: " + size + "; messages/s: " + numAppMessages / runtime + " bandwidth(bytes/s): " + ((double) numAppMessages * 2 * size) / runtime); // x2 for unicode chars } @@ -510,14 +510,14 @@ public class NetworkServiceTest { private final Monitor monitor; private AtomicInteger count = new AtomicInteger(0); - MessageHandler(String name, Monitor monitor, int expected) { + MessageHandler(final String name, final Monitor monitor, final int expected) { this.name = name; this.monitor = monitor; this.expected = expected; } @Override - public void onNext(Message<T> value) { + public void onNext(final Message<T> value) { count.incrementAndGet(); @@ -540,7 +540,7 @@ public class NetworkServiceTest { */ class ExceptionHandler implements EventHandler<Exception> { @Override - public void onNext(Exception error) { + public void onNext(final Exception error) { System.err.println(error); } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/TestEvent.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/TestEvent.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/TestEvent.java index 494f2e0..92ba655 100644 --- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/TestEvent.java +++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/TestEvent.java @@ -28,7 +28,7 @@ public class TestEvent implements Serializable { private static final long serialVersionUID = 1L; private String message; - public TestEvent(String message) { + public TestEvent(final String message) { this.message = message; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/LoggingUtils.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/LoggingUtils.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/LoggingUtils.java index d27f4cf..b10d876 100644 --- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/LoggingUtils.java +++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/LoggingUtils.java @@ -24,10 +24,10 @@ import java.util.logging.Level; import java.util.logging.Logger; public final class LoggingUtils { - public static void setLoggingLevel(Level level) { - Handler[] handlers = Logger.getLogger("").getHandlers(); + public static void setLoggingLevel(final Level level) { + final Handler[] handlers = Logger.getLogger("").getHandlers(); ConsoleHandler ch = null; - for (Handler h : handlers) { + for (final Handler h : handlers) { if (h instanceof ConsoleHandler) { ch = (ConsoleHandler) h; break; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/NetworkMessagingTestService.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/NetworkMessagingTestService.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/NetworkMessagingTestService.java index ccc2e4b..ebc8608 100644 --- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/NetworkMessagingTestService.java +++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/NetworkMessagingTestService.java @@ -117,7 +117,7 @@ public final class NetworkMessagingTestService implements AutoCloseable { } @Override - public void onNext(Message<T> value) { + public void onNext(final Message<T> value) { count.incrementAndGet(); LOG.log(Level.FINE, "Count: {0}", count.get()); LOG.log(Level.FINE, @@ -136,11 +136,11 @@ public final class NetworkMessagingTestService implements AutoCloseable { public static final class TestListener<T> implements LinkListener<Message<T>> { @Override - public void onSuccess(Message<T> message) { + public void onSuccess(final Message<T> message) { LOG.log(Level.FINE, "success: " + message); } @Override - public void onException(Throwable cause, SocketAddress remoteAddress, Message<T> message) { + public void onException(final Throwable cause, final SocketAddress remoteAddress, final Message<T> message) { LOG.log(Level.WARNING, "exception: " + cause + message); throw new RuntimeException(cause); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StreamingIntegerCodec.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StreamingIntegerCodec.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StreamingIntegerCodec.java index eaec90f..757a803 100644 --- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StreamingIntegerCodec.java +++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StreamingIntegerCodec.java @@ -28,30 +28,30 @@ import java.io.IOException; public class StreamingIntegerCodec implements StreamingCodec<Integer> { @Override - public void encodeToStream(Integer obj, DataOutputStream stream) { + public void encodeToStream(final Integer obj, final DataOutputStream stream) { try { stream.writeInt(obj); - } catch (IOException e) { + } catch (final IOException e) { throw new RuntimeException(e); } } @Override - public Integer decodeFromStream(DataInputStream stream) { + public Integer decodeFromStream(final DataInputStream stream) { try { return stream.readInt(); - } catch (IOException e) { + } catch (final IOException e) { throw new RuntimeException(e); } } @Override - public Integer decode(byte[] data) { + public Integer decode(final byte[] data) { return null; } @Override - public byte[] encode(Integer obj) { + public byte[] encode(final Integer obj) { return new byte[0]; } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StreamingStringCodec.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StreamingStringCodec.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StreamingStringCodec.java index 497c7fa..43efaf6 100644 --- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StreamingStringCodec.java +++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StreamingStringCodec.java @@ -27,29 +27,29 @@ import java.io.IOException; public class StreamingStringCodec implements StreamingCodec<String> { @Override - public byte[] encode(String obj) { + public byte[] encode(final String obj) { return obj.getBytes(); } @Override - public String decode(byte[] buf) { + public String decode(final byte[] buf) { return new String(buf); } @Override - public void encodeToStream(String obj, DataOutputStream stream) { + public void encodeToStream(final String obj, final DataOutputStream stream) { try { stream.writeUTF(obj); - } catch (IOException e) { + } catch (final IOException e) { throw new RuntimeException(e); } } @Override - public String decodeFromStream(DataInputStream stream) { + public String decodeFromStream(final DataInputStream stream) { try { return stream.readUTF(); - } catch (IOException e) { + } catch (final IOException e) { throw new RuntimeException(e); } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StringCodec.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StringCodec.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StringCodec.java index cee8421..d939b8e 100644 --- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StringCodec.java +++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StringCodec.java @@ -23,12 +23,12 @@ import org.apache.reef.wake.remote.Codec; public class StringCodec implements Codec<String> { @Override - public byte[] encode(String obj) { + public byte[] encode(final String obj) { return obj.getBytes(); } @Override - public String decode(byte[] buf) { + public String decode(final byte[] buf) { return new String(buf); } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/TimeoutHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/TimeoutHandler.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/TimeoutHandler.java index 5f13deb..146a6db 100644 --- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/TimeoutHandler.java +++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/TimeoutHandler.java @@ -25,12 +25,12 @@ public class TimeoutHandler implements EventHandler<PeriodicEvent> { private final Monitor monitor; - public TimeoutHandler(Monitor monitor) { + public TimeoutHandler(final Monitor monitor) { this.monitor = monitor; } @Override - public void onNext(PeriodicEvent event) { + public void onNext(final PeriodicEvent event) { monitor.mnotify(); } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/ExternalMapTest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/ExternalMapTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/ExternalMapTest.java index 27f4e5c..38655c0 100644 --- a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/ExternalMapTest.java +++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/ExternalMapTest.java @@ -33,23 +33,23 @@ import java.util.*; public class ExternalMapTest { @Test public void testCodecRamMap() { - RamStorageService ramStore = new RamStorageService(); - Codec<Integer> c = new IntegerCodec(); - ExternalMap<Integer> m = new CodecRamMap<>(ramStore, c); + final RamStorageService ramStore = new RamStorageService(); + final Codec<Integer> c = new IntegerCodec(); + final ExternalMap<Integer> m = new CodecRamMap<>(ramStore, c); genericTest(m); } @Test public void testRamMap() { - RamStorageService ramStore = new RamStorageService(); - ExternalMap<Integer> m = new RamMap<>(ramStore); + final RamStorageService ramStore = new RamStorageService(); + final ExternalMap<Integer> m = new RamMap<>(ramStore); genericTest(m); } - void genericTest(ExternalMap<Integer> m) { + void genericTest(final ExternalMap<Integer> m) { m.put("foo", 42); - Map<String, Integer> smallMap = new HashMap<>(); + final Map<String, Integer> smallMap = new HashMap<>(); smallMap.put("bar", 43); smallMap.put("baz", 44); @@ -63,19 +63,19 @@ public class ExternalMapTest { Assert.assertTrue(m.containsKey("bar")); Assert.assertFalse(m.containsKey("quuz")); - Set<String> barBaz = new HashSet<>(); + final Set<String> barBaz = new HashSet<>(); barBaz.add("bar"); barBaz.add("baz"); barBaz.add("quuz"); - Iterable<Map.Entry<CharSequence, Integer>> it = m.getAll(barBaz); + final Iterable<Map.Entry<CharSequence, Integer>> it = m.getAll(barBaz); - Map<CharSequence, Integer> found = new TreeMap<>(); + final Map<CharSequence, Integer> found = new TreeMap<>(); - for (Map.Entry<CharSequence, Integer> e : it) { + for (final Map.Entry<CharSequence, Integer> e : it) { found.put(e.getKey(), e.getValue()); } - Iterator<CharSequence> it2 = found.keySet().iterator(); + final Iterator<CharSequence> it2 = found.keySet().iterator(); Assert.assertTrue(it2.hasNext()); CharSequence s = it2.next(); Assert.assertEquals(s, "bar"); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/FramingTest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/FramingTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/FramingTest.java index cf6199e..e8722de 100644 --- a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/FramingTest.java +++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/FramingTest.java @@ -34,14 +34,14 @@ public class FramingTest { @Test public void frameRoundTripTest() throws IOException, ServiceException { - ByteArrayOutputStream baos = new ByteArrayOutputStream(); - ByteArrayOutputStream baos2 = new ByteArrayOutputStream(); - FramingOutputStream o = new FramingOutputStream(baos); - FramingOutputStream o2 = new FramingOutputStream(baos2); - Accumulator<byte[]> a = o2.accumulator(); + final ByteArrayOutputStream baos = new ByteArrayOutputStream(); + final ByteArrayOutputStream baos2 = new ByteArrayOutputStream(); + final FramingOutputStream o = new FramingOutputStream(baos); + final FramingOutputStream o2 = new FramingOutputStream(baos2); + final Accumulator<byte[]> a = o2.accumulator(); int offset = 0; for (int i = 0; i < 256; i++) { - byte[] b = new byte[i]; + final byte[] b = new byte[i]; Arrays.fill(b, (byte) i); o.write(b); if (i == 255) { @@ -56,16 +56,16 @@ public class FramingTest { } a.close(); o2.close(); - byte[] b1 = baos.toByteArray(); - byte[] b2 = baos2.toByteArray(); + final byte[] b1 = baos.toByteArray(); + final byte[] b2 = baos2.toByteArray(); Assert.assertArrayEquals(b1, b2); - FramingInputStream inA1 = new FramingInputStream(new ByteArrayInputStream(b1)); - FramingInputStream inA2 = new FramingInputStream(new ByteArrayInputStream(b2)); + final FramingInputStream inA1 = new FramingInputStream(new ByteArrayInputStream(b1)); + final FramingInputStream inA2 = new FramingInputStream(new ByteArrayInputStream(b2)); for (int i = 0; i <= 256; i++) { - byte[] b = new byte[i]; + final byte[] b = new byte[i]; Arrays.fill(b, (byte) i); - byte[] f = inA1.readFrame(); - byte[] g = inA2.readFrame(); + final byte[] f = inA1.readFrame(); + final byte[] g = inA2.readFrame(); if (i == 256) { Assert.assertNull(f); Assert.assertNull(g); @@ -77,10 +77,10 @@ public class FramingTest { inA2.close(); inA1.close(); - FramingInputStream inB1 = new FramingInputStream(new ByteArrayInputStream(b1)); + final FramingInputStream inB1 = new FramingInputStream(new ByteArrayInputStream(b1)); int i = 0; - for (byte[] bin : inB1) { - byte[] b = new byte[i]; + for (final byte[] bin : inB1) { + final byte[] b = new byte[i]; Arrays.fill(b, (byte) i); Assert.assertArrayEquals(b, bin); i++; @@ -88,10 +88,10 @@ public class FramingTest { Assert.assertEquals(256, i); inB1.close(); - FramingInputStream inB2 = new FramingInputStream(new ByteArrayInputStream(b2)); + final FramingInputStream inB2 = new FramingInputStream(new ByteArrayInputStream(b2)); i = 0; - for (byte[] bin : inB2) { - byte[] b = new byte[i]; + for (final byte[] bin : inB2) { + final byte[] b = new byte[i]; Arrays.fill(b, (byte) i); Assert.assertArrayEquals(b, bin); i++; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/MergingIteratorTest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/MergingIteratorTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/MergingIteratorTest.java index f859921..bfab073 100644 --- a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/MergingIteratorTest.java +++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/MergingIteratorTest.java @@ -33,7 +33,7 @@ public class MergingIteratorTest { Comparator<Integer> cmp = new Comparator<Integer>() { @Override - public int compare(Integer o1, Integer o2) { + public int compare(final Integer o1, final Integer o2) { return Integer.compare(o1, o2); } }; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/SortingSpoolTest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/SortingSpoolTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/SortingSpoolTest.java index b7c0e09..6e43683 100644 --- a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/SortingSpoolTest.java +++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/SortingSpoolTest.java @@ -34,7 +34,7 @@ public class SortingSpoolTest { genericTest(new SortingRamSpool<Integer>(), new Comparator<Integer>() { @Override - public int compare(Integer o1, Integer o2) { + public int compare(final Integer o1, final Integer o2) { return Integer.compare(o1, o2); } @@ -43,10 +43,10 @@ public class SortingSpoolTest { @Test public void testRamSpoolComparator() throws ServiceException { - Comparator<Integer> backwards = new Comparator<Integer>() { + final Comparator<Integer> backwards = new Comparator<Integer>() { @Override - public int compare(Integer o1, Integer o2) { + public int compare(final Integer o1, final Integer o2) { return -1 * o1.compareTo(o2); } @@ -56,60 +56,60 @@ public class SortingSpoolTest { @Test(expected = IllegalStateException.class) public void testRamSpoolAddAfterClose() throws ServiceException { - Spool<Integer> s = new SortingRamSpool<>(); + final Spool<Integer> s = new SortingRamSpool<>(); genericAddAfterCloseTest(s); } @Test(expected = UnsupportedOperationException.class) public void testRamSpoolCantRemove() throws ServiceException { - Spool<Integer> s = new SortingRamSpool<>(); + final Spool<Integer> s = new SortingRamSpool<>(); genericCantRemove(s); } @Test(expected = IllegalStateException.class) public void testIteratorBeforeClose() throws ServiceException { - Spool<Integer> s = new SortingRamSpool<>(); + final Spool<Integer> s = new SortingRamSpool<>(); genericIteratorBeforeClose(s); } - void genericTest(Spool<Integer> s, Comparator<Integer> comparator) + void genericTest(final Spool<Integer> s, final Comparator<Integer> comparator) throws ServiceException { - List<Integer> l = new ArrayList<Integer>(); - Random r = new Random(42); + final List<Integer> l = new ArrayList<Integer>(); + final Random r = new Random(42); while (l.size() < 100) { l.add(r.nextInt(75)); } - Accumulator<Integer> a = s.accumulator(); + final Accumulator<Integer> a = s.accumulator(); for (int i = 0; i < 100; i++) { a.add(l.get(i)); } a.close(); - List<Integer> m = new ArrayList<Integer>(); - for (int i : s) { + final List<Integer> m = new ArrayList<Integer>(); + for (final int i : s) { m.add(i); } - Integer[] sorted = l.toArray(new Integer[0]); + final Integer[] sorted = l.toArray(new Integer[0]); Arrays.sort(sorted, 0, sorted.length, comparator); - Integer[] shouldBeSorted = m.toArray(new Integer[0]); + final Integer[] shouldBeSorted = m.toArray(new Integer[0]); Assert.assertArrayEquals(sorted, shouldBeSorted); } - void genericAddAfterCloseTest(Spool<?> s) throws ServiceException { - Accumulator<?> a = s.accumulator(); + void genericAddAfterCloseTest(final Spool<?> s) throws ServiceException { + final Accumulator<?> a = s.accumulator(); a.close(); a.add(null); } - void genericCantRemove(Spool<Integer> s) throws ServiceException { - Accumulator<Integer> a = s.accumulator(); + void genericCantRemove(final Spool<Integer> s) throws ServiceException { + final Accumulator<Integer> a = s.accumulator(); a.add(10); a.close(); - Iterator<?> it = s.iterator(); + final Iterator<?> it = s.iterator(); it.remove(); } - void genericIteratorBeforeClose(Spool<Integer> s) throws ServiceException { - Accumulator<Integer> a = s.accumulator(); + void genericIteratorBeforeClose(final Spool<Integer> s) throws ServiceException { + final Accumulator<Integer> a = s.accumulator(); a.add(10); s.iterator(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/SpoolFileTest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/SpoolFileTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/SpoolFileTest.java index 9a76b27..2ff6744 100644 --- a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/SpoolFileTest.java +++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/SpoolFileTest.java @@ -59,12 +59,12 @@ public class SpoolFileTest { return new Accumulator<Integer>() { @Override - public void add(Integer datum) { + public void add(final Integer datum) { try { - int d = datum; + final int d = datum; out.write(new byte[]{(byte) (d >>> 24), (byte) (d >>> 16), (byte) (d >>> 8), (byte) d}); - } catch (IOException e) { + } catch (final IOException e) { throw new IllegalStateException(e); } } @@ -73,7 +73,7 @@ public class SpoolFileTest { public void close() { try { out.flush(); - } catch (IOException e) { + } catch (final IOException e) { throw new IllegalStateException(e); } } @@ -88,7 +88,7 @@ public class SpoolFileTest { return new Iterable<Integer>() { @Override public Iterator<Integer> iterator() { - Iterator<Integer> it = new Iterator<Integer>() { + final Iterator<Integer> it = new Iterator<Integer>() { final byte[] inb = new byte[4]; Integer nextInt; @@ -98,10 +98,10 @@ public class SpoolFileTest { } private void prime() { - int read; + final int read; try { read = in.read(inb); - } catch (IOException e) { + } catch (final IOException e) { throw new IllegalStateException(e); } if (read != 4) { @@ -115,7 +115,7 @@ public class SpoolFileTest { @Override public Integer next() { - Integer ret = nextInt; + final Integer ret = nextInt; prime(); return ret; } @@ -150,8 +150,8 @@ public class SpoolFileTest { @Test public void testFile() throws ServiceException { - LocalStorageService service = new LocalStorageService("spoolTest", "file"); - Spool<Integer> f = new SerializerFileSpool<Integer>(service, serializer, + final LocalStorageService service = new LocalStorageService("spoolTest", "file"); + final Spool<Integer> f = new SerializerFileSpool<Integer>(service, serializer, deserializer); test(f); service.getScratchSpace().delete(); @@ -159,23 +159,23 @@ public class SpoolFileTest { @Test public void testInterop() throws ServiceException { - LocalStorageService service = new LocalStorageService("spoolTest", "file"); - Codec<Integer> c = new IntegerCodec(); + final LocalStorageService service = new LocalStorageService("spoolTest", "file"); + final Codec<Integer> c = new IntegerCodec(); - CodecFileAccumulable<Integer, Codec<Integer>> f = new CodecFileAccumulable<Integer, Codec<Integer>>( + final CodecFileAccumulable<Integer, Codec<Integer>> f = new CodecFileAccumulable<Integer, Codec<Integer>>( service, c); - CodecFileIterable<Integer, Codec<Integer>> g = new CodecFileIterable<Integer, Codec<Integer>>( + final CodecFileIterable<Integer, Codec<Integer>> g = new CodecFileIterable<Integer, Codec<Integer>>( new File(f.getName()), c); test(f, g); service.getScratchSpace().delete(); } - protected void test(Spool<Integer> f) throws ServiceException { + protected void test(final Spool<Integer> f) throws ServiceException { test(f, f); } - protected void test(Accumulable<Integer> f, Iterable<Integer> g) throws ServiceException { + protected void test(final Accumulable<Integer> f, final Iterable<Integer> g) throws ServiceException { try (Accumulator<Integer> acc = f.accumulator()) { for (int i = 0; i < 1000; i++) { @@ -183,12 +183,12 @@ public class SpoolFileTest { } } int i = 0; - for (int j : g) { + for (final int j : g) { Assert.assertEquals(i, j); i++; } - Iterator<Integer> itA = g.iterator(); - Iterator<Integer> itB = g.iterator(); + final Iterator<Integer> itA = g.iterator(); + final Iterator<Integer> itB = g.iterator(); for (i = 0; i < 1000; i++) { Assert.assertEquals((int) itA.next(), i); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/TupleSerializerTest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/TupleSerializerTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/TupleSerializerTest.java index 9fab5af..1c4e48a 100644 --- a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/TupleSerializerTest.java +++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/TupleSerializerTest.java @@ -60,7 +60,7 @@ public class TupleSerializerTest { keySerializer, valSerializer); baos = new ByteArrayOutputStream(); - Accumulator<Tuple<Integer, String>> acc = fts.create(baos).accumulator(); + final Accumulator<Tuple<Integer, String>> acc = fts.create(baos).accumulator(); for (int i = 0; i < 100; i++) { acc.add(new Tuple<>(i, i + "")); } @@ -74,8 +74,8 @@ public class TupleSerializerTest { @Test public void testFramingSerializer() throws ServiceException, IOException { int i = 0; - for (Tuple<Integer, String> t : iterable) { - Tuple<Integer, String> u = new Tuple<>(i, i + ""); + for (final Tuple<Integer, String> t : iterable) { + final Tuple<Integer, String> u = new Tuple<>(i, i + ""); Assert.assertEquals(u, t); i++; } @@ -84,13 +84,13 @@ public class TupleSerializerTest { @Test(expected = NoSuchElementException.class) public void testReadOffEnd() { - Iterator<Tuple<Integer, String>> it = iterable.iterator(); + final Iterator<Tuple<Integer, String>> it = iterable.iterator(); try { while (it.hasNext()) { it.next(); it.hasNext(); } - } catch (NoSuchElementException e) { + } catch (final NoSuchElementException e) { throw new IllegalStateException("Errored out too early!", e); } it.next(); @@ -98,7 +98,7 @@ public class TupleSerializerTest { @Test(expected = UnsupportedOperationException.class) public void testCantRemove() { - Iterator<Tuple<Integer, String>> it = iterable.iterator(); + final Iterator<Tuple<Integer, String>> it = iterable.iterator(); it.next(); it.remove(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/sslhacks/UnsafeHostNameVerifier.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/sslhacks/UnsafeHostNameVerifier.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/sslhacks/UnsafeHostNameVerifier.java index f20fa9a..e706d64 100644 --- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/sslhacks/UnsafeHostNameVerifier.java +++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/sslhacks/UnsafeHostNameVerifier.java @@ -29,22 +29,22 @@ import java.security.cert.X509Certificate; final class UnsafeHostNameVerifier implements X509HostnameVerifier { @Override - public void verify(String host, SSLSocket ssl) throws IOException { + public void verify(final String host, final SSLSocket ssl) throws IOException { } @Override - public void verify(String host, X509Certificate cert) throws SSLException { + public void verify(final String host, final X509Certificate cert) throws SSLException { } @Override - public void verify(String host, String[] cns, String[] subjectAlts) throws SSLException { + public void verify(final String host, final String[] cns, final String[] subjectAlts) throws SSLException { } @Override - public boolean verify(String s, SSLSession sslSession) { + public boolean verify(final String s, final SSLSession sslSession) { return true; } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/AmContainerSpec.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/AmContainerSpec.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/AmContainerSpec.java index 5249f69..9c743dc 100644 --- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/AmContainerSpec.java +++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/AmContainerSpec.java @@ -161,12 +161,12 @@ public final class AmContainerSpec { @Override public String toString() { - StringWriter writer = new StringWriter(); - String objectString; + final StringWriter writer = new StringWriter(); + final String objectString; try { OBJECT_MAPPER.writeValue(writer, this); objectString = writer.toString(); - } catch (IOException e) { + } catch (final IOException e) { return null; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationID.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationID.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationID.java index 6c9a18e..a14c7ee 100644 --- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationID.java +++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationID.java @@ -59,12 +59,12 @@ public final class ApplicationID { @Override public String toString() { - StringWriter writer = new StringWriter(); - String objectString; + final StringWriter writer = new StringWriter(); + final String objectString; try { OBJECT_MAPPER.writeValue(writer, this); objectString = writer.toString(); - } catch (IOException e) { + } catch (final IOException e) { return null; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationResponse.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationResponse.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationResponse.java index 25041fd..bde2aab 100644 --- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationResponse.java +++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationResponse.java @@ -54,12 +54,12 @@ public final class ApplicationResponse { @Override public String toString() { - StringWriter writer = new StringWriter(); - String objectString; + final StringWriter writer = new StringWriter(); + final String objectString; try { OBJECT_MAPPER.writeValue(writer, this); objectString = writer.toString(); - } catch (IOException e) { + } catch (final IOException e) { return null; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationState.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationState.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationState.java index 92bea8e..7e9e1db 100644 --- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationState.java +++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationState.java @@ -66,7 +66,7 @@ public final class ApplicationState { return finishedTime; } - public void setFinishedTime(long finishedTime) { + public void setFinishedTime(final long finishedTime) { this.finishedTime = finishedTime; } @@ -75,7 +75,7 @@ public final class ApplicationState { return amContainerLogs; } - public void setAmContainerLogs(String amContainerLogs) { + public void setAmContainerLogs(final String amContainerLogs) { this.amContainerLogs = amContainerLogs; } @@ -84,7 +84,7 @@ public final class ApplicationState { return trackingUI; } - public void setTrackingUI(String trackingUI) { + public void setTrackingUI(final String trackingUI) { this.trackingUI = trackingUI; } @@ -93,7 +93,7 @@ public final class ApplicationState { return state; } - public void setState(String state) { + public void setState(final String state) { this.state = state; } @@ -102,7 +102,7 @@ public final class ApplicationState { return user; } - public void setUser(String user) { + public void setUser(final String user) { this.user = user; } @@ -111,7 +111,7 @@ public final class ApplicationState { return id; } - public void setId(String id) { + public void setId(final String id) { this.id = id; } @@ -120,7 +120,7 @@ public final class ApplicationState { return clusterId; } - public void setClusterId(String clusterId) { + public void setClusterId(final String clusterId) { this.clusterId = clusterId; } @@ -129,7 +129,7 @@ public final class ApplicationState { return finalStatus; } - public void setFinalStatus(String finalStatus) { + public void setFinalStatus(final String finalStatus) { this.finalStatus = finalStatus; } @@ -138,7 +138,7 @@ public final class ApplicationState { return amHostHttpAddress; } - public void setAmHostHttpAddress(String amHostHttpAddress) { + public void setAmHostHttpAddress(final String amHostHttpAddress) { this.amHostHttpAddress = amHostHttpAddress; } @@ -147,7 +147,7 @@ public final class ApplicationState { return progress; } - public void setProgress(String progress) { + public void setProgress(final String progress) { this.progress = progress; } @@ -156,7 +156,7 @@ public final class ApplicationState { return name; } - public void setName(String name) { + public void setName(final String name) { this.name = name; } @@ -165,7 +165,7 @@ public final class ApplicationState { return applicationType; } - public void setApplicationType(String applicationType) { + public void setApplicationType(final String applicationType) { this.applicationType = applicationType; } @@ -174,7 +174,7 @@ public final class ApplicationState { return startedTime; } - public void setStartedTime(long startedTime) { + public void setStartedTime(final long startedTime) { this.startedTime = startedTime; } @@ -183,7 +183,7 @@ public final class ApplicationState { return elapsedTime; } - public void setElapsedTime(long elapsedTime) { + public void setElapsedTime(final long elapsedTime) { this.elapsedTime = elapsedTime; } @@ -192,7 +192,7 @@ public final class ApplicationState { return diagnostics; } - public void setDiagnostics(String diagnostics) { + public void setDiagnostics(final String diagnostics) { this.diagnostics = diagnostics; } @@ -201,7 +201,7 @@ public final class ApplicationState { return trackingUrl; } - public void setTrackingUrl(String trackingUrl) { + public void setTrackingUrl(final String trackingUrl) { this.trackingUrl = trackingUrl; } @@ -210,7 +210,7 @@ public final class ApplicationState { return queue; } - public void setQueue(String queue) { + public void setQueue(final String queue) { this.queue = queue; } @@ -219,7 +219,7 @@ public final class ApplicationState { return allocatedMB; } - public void setAllocatedMB(int allocatedMB) { + public void setAllocatedMB(final int allocatedMB) { this.allocatedMB = allocatedMB; } @@ -228,7 +228,7 @@ public final class ApplicationState { return allocatedVCores; } - public void setAllocatedVCores(int allocatedVCores) { + public void setAllocatedVCores(final int allocatedVCores) { this.allocatedVCores = allocatedVCores; } @@ -237,7 +237,7 @@ public final class ApplicationState { return runningContainers; } - public void setRunningContainers(int runningContainers) { + public void setRunningContainers(final int runningContainers) { this.runningContainers = runningContainers; } @@ -246,7 +246,7 @@ public final class ApplicationState { return memorySeconds; } - public void setMemorySeconds(long memorySeconds) { + public void setMemorySeconds(final long memorySeconds) { this.memorySeconds = memorySeconds; } @@ -256,18 +256,18 @@ public final class ApplicationState { } @SuppressWarnings("checkstyle:hiddenfield") - public void setVCoreSeconds(long vCoreSeconds) { + public void setVCoreSeconds(final long vCoreSeconds) { this.vCoreSeconds = vCoreSeconds; } @Override public String toString() { - StringWriter writer = new StringWriter(); - String objectString; + final StringWriter writer = new StringWriter(); + final String objectString; try { OBJECT_MAPPER.writeValue(writer, this); objectString = writer.toString(); - } catch (IOException e) { + } catch (final IOException e) { return null; }
