Repository: incubator-reef Updated Branches: refs/heads/master e5aef1616 -> 141c7fa08
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteTest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteTest.java index 06936fd..e2eacc9 100644 --- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteTest.java +++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteTest.java @@ -66,18 +66,18 @@ public class RemoteTest { public void testRemoteEventCodec() throws UnknownHostException { System.out.println(LOG_PREFIX + name.getMethodName()); - ObjectSerializableCodec<TestEvent> codec = new ObjectSerializableCodec<TestEvent>(); + final ObjectSerializableCodec<TestEvent> codec = new ObjectSerializableCodec<TestEvent>(); - RemoteEventCodec<TestEvent> reCodec = new RemoteEventCodec<TestEvent>(codec); - SocketAddress localAddr = new InetSocketAddress(this.localAddressProvider.getLocalAddress(), 8000); - SocketAddress remoteAddr = new InetSocketAddress(this.localAddressProvider.getLocalAddress(), 9000); + final RemoteEventCodec<TestEvent> reCodec = new RemoteEventCodec<TestEvent>(codec); + final SocketAddress localAddr = new InetSocketAddress(this.localAddressProvider.getLocalAddress(), 8000); + final SocketAddress remoteAddr = new InetSocketAddress(this.localAddressProvider.getLocalAddress(), 9000); - RemoteEvent<TestEvent> e1 = new RemoteEvent<TestEvent>( + final RemoteEvent<TestEvent> e1 = new RemoteEvent<TestEvent>( localAddr, remoteAddr, "stage1", "stage2", 1, new TestEvent("hello", 0.0)); System.out.println(e1); - byte[] data = reCodec.encode(e1); - RemoteEvent<TestEvent> e2 = reCodec.decode(data); + final byte[] data = reCodec.encode(e1); + final RemoteEvent<TestEvent> e2 = reCodec.decode(data); System.out.println(e2); Assert.assertEquals(e1.getSink(), e2.getSink()); @@ -95,11 +95,11 @@ public class RemoteTest { final String hostAddress = this.localAddressProvider.getLocalAddress(); // transport - Transport transport1 = tpFactory.newInstance(hostAddress, 0, reRecvStage, reRecvStage, 1, 10000); - int port1 = transport1.getListeningPort(); + final Transport transport1 = tpFactory.newInstance(hostAddress, 0, reRecvStage, reRecvStage, 1, 10000); + final int port1 = transport1.getListeningPort(); - Transport transport2 = tpFactory.newInstance(hostAddress, 0, reRecvStage, reRecvStage, 1, 10000); - int port2 = transport2.getListeningPort(); + final Transport transport2 = tpFactory.newInstance(hostAddress, 0, reRecvStage, reRecvStage, 1, 10000); + final int port2 = transport2.getListeningPort(); transport1.close(); transport2.close(); @@ -112,26 +112,26 @@ public class RemoteTest { System.out.println(LOG_PREFIX + name.getMethodName()); LoggingUtils.setLoggingLevel(Level.FINEST); - Monitor monitor = new Monitor(); - TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 5000, 5000); + final Monitor monitor = new Monitor(); + final TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 5000, 5000); // port - int port = 9101; + final int port = 9101; // receiver stage // decoder map - Map<Class<?>, Decoder<?>> clazzToDecoderMap = new HashMap<Class<?>, Decoder<?>>(); + final Map<Class<?>, Decoder<?>> clazzToDecoderMap = new HashMap<Class<?>, Decoder<?>>(); clazzToDecoderMap.put(TestEvent.class, new ObjectSerializableCodec<TestEvent>()); clazzToDecoderMap.put(TestEvent2.class, new ObjectSerializableCodec<TestEvent2>()); - Decoder<Object> decoder = new MultiDecoder<Object>(clazzToDecoderMap); + final Decoder<Object> decoder = new MultiDecoder<Object>(clazzToDecoderMap); // receive handlers - int finalSize = 6; // 6 events will be sent - Map<Class<?>, EventHandler<?>> clazzToHandlerMap = new HashMap<Class<?>, EventHandler<?>>(); - Set<Object> set = Collections.synchronizedSet(new HashSet<Object>()); + final int finalSize = 6; // 6 events will be sent + final Map<Class<?>, EventHandler<?>> clazzToHandlerMap = new HashMap<Class<?>, EventHandler<?>>(); + final Set<Object> set = Collections.synchronizedSet(new HashSet<Object>()); clazzToHandlerMap.put(TestEvent.class, new ConsoleEventHandler<TestEvent>("recvEH1", set, finalSize, monitor)); clazzToHandlerMap.put(TestEvent2.class, new ConsoleEventHandler<TestEvent2>("recvEH2", set, finalSize, monitor)); - EventHandler<Object> handler = new MultiEventHandler<Object>(clazzToHandlerMap); + final EventHandler<Object> handler = new MultiEventHandler<Object>(clazzToHandlerMap); // receiver stage final RemoteReceiverStage reRecvStage = new RemoteReceiverStage( @@ -140,34 +140,34 @@ public class RemoteTest { final String hostAddress = this.localAddressProvider.getLocalAddress(); // transport - Transport transport = tpFactory.newInstance(hostAddress, port, reRecvStage, reRecvStage, 1, 10000); + final Transport transport = tpFactory.newInstance(hostAddress, port, reRecvStage, reRecvStage, 1, 10000); // mux encoder with encoder map - Map<Class<?>, Encoder<?>> clazzToEncoderMap = new HashMap<Class<?>, Encoder<?>>(); + final Map<Class<?>, Encoder<?>> clazzToEncoderMap = new HashMap<Class<?>, Encoder<?>>(); clazzToEncoderMap.put(TestEvent.class, new ObjectSerializableCodec<TestEvent>()); clazzToEncoderMap.put(TestEvent2.class, new ObjectSerializableCodec<TestEvent2>()); - Encoder<Object> encoder = new MultiEncoder<Object>(clazzToEncoderMap); + final Encoder<Object> encoder = new MultiEncoder<Object>(clazzToEncoderMap); // sender stage final RemoteSenderStage reSendStage = new RemoteSenderStage(encoder, transport, 10); - RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation(); - RemoteIdentifier myId = factory.getNewInstance("socket://" + hostAddress + ":" + 8000); - RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + port); + final RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation(); + final RemoteIdentifier myId = factory.getNewInstance("socket://" + hostAddress + ":" + 8000); + final RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + port); - RemoteSeqNumGenerator seqGen = new RemoteSeqNumGenerator(); + final RemoteSeqNumGenerator seqGen = new RemoteSeqNumGenerator(); // proxy handler for a remotely running handler - ProxyEventHandler<TestEvent> proxyHandler1 = new ProxyEventHandler<TestEvent>( + final ProxyEventHandler<TestEvent> proxyHandler1 = new ProxyEventHandler<TestEvent>( myId, remoteId, "recvEH1", reSendStage.<TestEvent>getHandler(), seqGen); proxyHandler1.onNext(new TestEvent("hello1", 0.0)); proxyHandler1.onNext(new TestEvent("hello2", 0.0)); - ProxyEventHandler<TestEvent2> proxyHandler2 = new ProxyEventHandler<TestEvent2>( + final ProxyEventHandler<TestEvent2> proxyHandler2 = new ProxyEventHandler<TestEvent2>( myId, remoteId, "recvEH2", reSendStage.<TestEvent2>getHandler(), seqGen); proxyHandler2.onNext(new TestEvent2("hello1", 1.0)); proxyHandler2.onNext(new TestEvent2("hello2", 1.0)); - ProxyEventHandler<TestEvent> proxyHandler3 = new ProxyEventHandler<TestEvent>( + final ProxyEventHandler<TestEvent> proxyHandler3 = new ProxyEventHandler<TestEvent>( myId, remoteId, "recvEH3", reSendStage.<TestEvent>getHandler(), seqGen); proxyHandler3.onNext(new TestEvent("hello1", 1.0)); proxyHandler3.onNext(new TestEvent("hello2", 1.0)); @@ -191,13 +191,13 @@ public class RemoteTest { private final Decoder<Object> decoder; private final EventHandler<Object> handler; - RemoteEventHandler(Decoder<Object> decoder, EventHandler<Object> handler) { + RemoteEventHandler(final Decoder<Object> decoder, final EventHandler<Object> handler) { this.decoder = decoder; this.handler = handler; } @Override - public void onNext(RemoteEvent<byte[]> value) { + public void onNext(final RemoteEvent<byte[]> value) { handler.onNext(decoder.decode(value.getEvent())); } } @@ -209,7 +209,7 @@ public class RemoteTest { private final int finalSize; private final Monitor monitor; - ConsoleEventHandler(String name, Set<Object> set, int finalSize, Monitor monitor) { + ConsoleEventHandler(final String name, final Set<Object> set, final int finalSize, final Monitor monitor) { this.name = name; this.set = set; this.finalSize = finalSize; @@ -217,7 +217,7 @@ public class RemoteTest { } @Override - public void onNext(T value) { + public void onNext(final T value) { System.out.println(name + " " + value); set.add(value); if (set.size() == finalSize) { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/SmallMessagesTest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/SmallMessagesTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/SmallMessagesTest.java index fcaf182..461308f 100644 --- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/SmallMessagesTest.java +++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/SmallMessagesTest.java @@ -63,27 +63,27 @@ public class SmallMessagesTest { System.out.println(LOG_PREFIX + name.getMethodName()); LoggingUtils.setLoggingLevel(Level.FINEST); - Monitor monitor = new Monitor(); - TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 60000, 60000); + final Monitor monitor = new Monitor(); + final TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 60000, 60000); // port - int port = 9101; + final int port = 9101; // receiver stage // decoder map - Map<Class<?>, Decoder<?>> clazzToDecoderMap = new HashMap<Class<?>, Decoder<?>>(); + final Map<Class<?>, Decoder<?>> clazzToDecoderMap = new HashMap<Class<?>, Decoder<?>>(); clazzToDecoderMap.put(TestEvent.class, new ObjectSerializableCodec<TestEvent>()); clazzToDecoderMap.put(TestEvent2.class, new ObjectSerializableCodec<TestEvent2>()); - Decoder<Object> decoder = new MultiDecoder<Object>(clazzToDecoderMap); + final Decoder<Object> decoder = new MultiDecoder<Object>(clazzToDecoderMap); // receive handlers - int finalSize = 6; // 6 events will be sent + final int finalSize = 6; // 6 events will be sent //int finalSize = 200000; // 6 events will be sent - Map<Class<?>, EventHandler<?>> clazzToHandlerMap = new HashMap<Class<?>, EventHandler<?>>(); - Set<Object> set = Collections.synchronizedSet(new HashSet<Object>()); + final Map<Class<?>, EventHandler<?>> clazzToHandlerMap = new HashMap<Class<?>, EventHandler<?>>(); + final Set<Object> set = Collections.synchronizedSet(new HashSet<Object>()); clazzToHandlerMap.put(TestEvent.class, new ConsoleEventHandler<TestEvent>("recvEH1", set, finalSize, monitor)); clazzToHandlerMap.put(TestEvent2.class, new ConsoleEventHandler<TestEvent2>("recvEH2", set, finalSize, monitor)); - EventHandler<Object> handler = new MultiEventHandler<Object>(clazzToHandlerMap); + final EventHandler<Object> handler = new MultiEventHandler<Object>(clazzToHandlerMap); // receiver stage final RemoteReceiverStage reRecvStage = new RemoteReceiverStage( @@ -92,34 +92,34 @@ public class SmallMessagesTest { final String hostAddress = this.localAddressProvider.getLocalAddress(); // transport - Transport transport = tpFactory.newInstance(hostAddress, port, reRecvStage, reRecvStage, 1, 10000); + final Transport transport = tpFactory.newInstance(hostAddress, port, reRecvStage, reRecvStage, 1, 10000); // mux encoder with encoder map - Map<Class<?>, Encoder<?>> clazzToEncoderMap = new HashMap<Class<?>, Encoder<?>>(); + final Map<Class<?>, Encoder<?>> clazzToEncoderMap = new HashMap<Class<?>, Encoder<?>>(); clazzToEncoderMap.put(TestEvent.class, new ObjectSerializableCodec<TestEvent>()); clazzToEncoderMap.put(TestEvent2.class, new ObjectSerializableCodec<TestEvent2>()); - Encoder<Object> encoder = new MultiEncoder<Object>(clazzToEncoderMap); + final Encoder<Object> encoder = new MultiEncoder<Object>(clazzToEncoderMap); // sender stage final RemoteSenderStage reSendStage = new RemoteSenderStage(encoder, transport, 10); - RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation(); - RemoteIdentifier myId = factory.getNewInstance("socket://" + hostAddress + ":" + 8000); - RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + port); + final RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation(); + final RemoteIdentifier myId = factory.getNewInstance("socket://" + hostAddress + ":" + 8000); + final RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + port); // proxy handler for a remotely running handler - ProxyEventHandler<TestEvent> proxyHandler1 = new ProxyEventHandler<TestEvent>( + final ProxyEventHandler<TestEvent> proxyHandler1 = new ProxyEventHandler<TestEvent>( myId, remoteId, "recvEH1", reSendStage.<TestEvent>getHandler(), new RemoteSeqNumGenerator()); - long start = System.nanoTime(); + final long start = System.nanoTime(); for (int i = 0; i < finalSize; i++) { proxyHandler1.onNext(new TestEvent("0", i)); } monitor.mwait(); - long end = System.nanoTime(); - long runtimeNs = end - start; - double runtimeS = ((double) runtimeNs) / (1000 * 1000 * 1000); + final long end = System.nanoTime(); + final long runtimeNs = end - start; + final double runtimeS = ((double) runtimeNs) / (1000 * 1000 * 1000); System.out.println("msgs/s: " + finalSize / runtimeS); // most time is spent in netty.channel.socket.nio.SelectorUtil.select() @@ -140,13 +140,13 @@ public class SmallMessagesTest { private final Decoder<Object> decoder; private final EventHandler<Object> handler; - RemoteEventHandler(Decoder<Object> decoder, EventHandler<Object> handler) { + RemoteEventHandler(final Decoder<Object> decoder, final EventHandler<Object> handler) { this.decoder = decoder; this.handler = handler; } @Override - public void onNext(RemoteEvent<byte[]> value) { + public void onNext(final RemoteEvent<byte[]> value) { handler.onNext(decoder.decode(value.getEvent())); } } @@ -158,7 +158,7 @@ public class SmallMessagesTest { private final int finalSize; private final Monitor monitor; - ConsoleEventHandler(String name, Set<Object> set, int finalSize, Monitor monitor) { + ConsoleEventHandler(final String name, final Set<Object> set, final int finalSize, final Monitor monitor) { this.name = name; this.set = set; this.finalSize = finalSize; @@ -166,7 +166,7 @@ public class SmallMessagesTest { } @Override - public void onNext(T event) { + public void onNext(final T event) { //System.out.println(name + " " + event); set.add(event); if (set.size() == finalSize) { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent.java index 6731108..101590a 100644 --- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent.java +++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent.java @@ -27,7 +27,7 @@ public class TestEvent implements Serializable { private double load; - public TestEvent(String message, double load) { + public TestEvent(final String message, final double load) { this.message = message; this.load = load; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent1.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent1.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent1.java index e51242f..522bcf8 100644 --- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent1.java +++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent1.java @@ -22,7 +22,7 @@ public class TestEvent1 extends TestEvent { private static final long serialVersionUID = 1L; - public TestEvent1(String message, double load) { + public TestEvent1(final String message, final double load) { super(message, load); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent2.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent2.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent2.java index 1ec2a95..b2ffb77 100644 --- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent2.java +++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent2.java @@ -22,7 +22,7 @@ public class TestEvent2 extends TestEvent { private static final long serialVersionUID = 1L; - public TestEvent2(String message, double load) { + public TestEvent2(final String message, final double load) { super(message, load); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEventCodec.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEventCodec.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEventCodec.java index 6541c3f..f362a9e 100644 --- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEventCodec.java +++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEventCodec.java @@ -29,19 +29,19 @@ import org.apache.reef.wake.test.proto.TestProtos.TestEventPBuf; public class TestEventCodec implements Codec<TestEvent> { @Override - public byte[] encode(TestEvent obj) { - TestEventPBuf.Builder builder = TestEventPBuf.newBuilder(); + public byte[] encode(final TestEvent obj) { + final TestEventPBuf.Builder builder = TestEventPBuf.newBuilder(); builder.setMessage(obj.getMessage()); builder.setLoad(obj.getLoad()); return builder.build().toByteArray(); } @Override - public TestEvent decode(byte[] data) { - TestEventPBuf pbuf; + public TestEvent decode(final byte[] data) { + final TestEventPBuf pbuf; try { pbuf = TestEventPBuf.parseFrom(data); - } catch (InvalidProtocolBufferException e) { + } catch (final InvalidProtocolBufferException e) { e.printStackTrace(); throw new RemoteRuntimeException(e); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemote.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemote.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemote.java index 3b97dc5..086a408 100644 --- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemote.java +++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemote.java @@ -43,28 +43,28 @@ public class TestRemote implements Runnable { @Override public void run() { final String hostAddress = localAddressProvider.getLocalAddress(); - int myPort = 10011; - int remotePort = 10001; - Codec<TestEvent> codec = new TestEventCodec(); + final int myPort = 10011; + final int remotePort = 10001; + final Codec<TestEvent> codec = new TestEventCodec(); try (RemoteManager rm = remoteManagerFactory.getInstance("name", myPort, codec, new LoggingEventHandler<Throwable>())) { // proxy handler - RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation(); - RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + remotePort); - EventHandler<TestEvent> proxyHandler = rm.getHandler(remoteId, TestEvent.class); + final RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation(); + final RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + remotePort); + final EventHandler<TestEvent> proxyHandler = rm.getHandler(remoteId, TestEvent.class); proxyHandler.onNext(new TestEvent("hello", 1.0)); // register a handler rm.registerHandler(TestEvent.class, new TestEventHandler(proxyHandler)); - } catch (UnknownHostException e) { + } catch (final UnknownHostException e) { e.printStackTrace(); - } catch (Exception e) { + } catch (final Exception e) { e.printStackTrace(); } } - public static void main(String[] args) throws InjectionException { + public static void main(final String[] args) throws InjectionException { Tang.Factory.getTang().newInjector().getInstance(TestRemote.class).run(); } } @@ -73,12 +73,12 @@ class TestEventHandler implements EventHandler<RemoteMessage<TestEvent>> { private final EventHandler<TestEvent> proxy; - public TestEventHandler(EventHandler<TestEvent> proxy) { + public TestEventHandler(final EventHandler<TestEvent> proxy) { this.proxy = proxy; } @Override - public void onNext(RemoteMessage<TestEvent> value) { + public void onNext(final RemoteMessage<TestEvent> value) { System.out.println(value.getMessage().getMessage() + " " + value.getMessage().getLoad()); proxy.onNext(value.getMessage()); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemoteIdentifier.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemoteIdentifier.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemoteIdentifier.java index 2b28997..bece0df 100644 --- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemoteIdentifier.java +++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemoteIdentifier.java @@ -23,7 +23,7 @@ import org.apache.reef.wake.remote.RemoteIdentifier; public class TestRemoteIdentifier implements RemoteIdentifier { private final String str; - public TestRemoteIdentifier(String str) { + public TestRemoteIdentifier(final String str) { this.str = str; } @@ -31,7 +31,7 @@ public class TestRemoteIdentifier implements RemoteIdentifier { return str; } - public boolean equals(Object o) { + public boolean equals(final Object o) { return str.equals(((TestRemoteIdentifier) o).getString()); } @@ -40,7 +40,7 @@ public class TestRemoteIdentifier implements RemoteIdentifier { } public String toString() { - StringBuilder builder = new StringBuilder(); + final StringBuilder builder = new StringBuilder(); builder.append("test://"); builder.append(str); return builder.toString(); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TransportRaceTest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TransportRaceTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TransportRaceTest.java index 5a84cff..c8daf12 100644 --- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TransportRaceTest.java +++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TransportRaceTest.java @@ -55,21 +55,21 @@ public class TransportRaceTest { @Test public void testRace() throws Exception { LoggingUtils.setLoggingLevel(Level.FINE); - Monitor monitor = new Monitor(); - TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 5000, 5000); - EStage<TransportEvent> clientStage = new ThreadPoolStage<>("client1", + final Monitor monitor = new Monitor(); + final TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 5000, 5000); + final EStage<TransportEvent> clientStage = new ThreadPoolStage<>("client1", new LoggingEventHandler<TransportEvent>(), 1, new LoggingEventHandler<Throwable>()); - int msgsSent = 100; + final int msgsSent = 100; final ServerHandler serverHandler = new ServerHandler(monitor, msgsSent); - EStage<TransportEvent> serverStage = new ThreadPoolStage<>("server@7001", + final EStage<TransportEvent> serverStage = new ThreadPoolStage<>("server@7001", serverHandler, 1, new LoggingEventHandler<Throwable>()); final String hostAddress = this.localAddressProvider.getLocalAddress(); - int port = 7001; - Transport transport = tpFactory.newInstance( + final int port = 7001; + final Transport transport = tpFactory.newInstance( hostAddress, port, clientStage, serverStage, 1, 10000); - String value = "Test Race"; + final String value = "Test Race"; for (int i = 0; i < msgsSent; i++) { final Link<byte[]> link = transport.open(new InetSocketAddress( @@ -78,7 +78,7 @@ public class TransportRaceTest { } monitor.mwait(); - int msgsRcvd = serverHandler.getAccSize(); + final int msgsRcvd = serverHandler.getAccSize(); if (msgsRcvd != msgsSent) { Assert.assertEquals("Num Msgs transmitted==Num Msgs received", msgsSent, msgsRcvd); } @@ -94,7 +94,7 @@ public class TransportRaceTest { private final int expectedSize; private int accSize; - ServerHandler(Monitor monitor, int expectedSize) { + ServerHandler(final Monitor monitor, final int expectedSize) { this.monitor = monitor; this.expectedSize = expectedSize; this.accSize = 0; @@ -105,7 +105,7 @@ public class TransportRaceTest { } @Override - public void onNext(TransportEvent value) { + public void onNext(final TransportEvent value) { ++accSize; if (accSize == expectedSize) { monitor.mnotify(); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TransportTest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TransportTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TransportTest.java index d3ae9b3..f62d3c9 100644 --- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TransportTest.java +++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TransportTest.java @@ -63,19 +63,20 @@ public class TransportTest { System.out.println(LOG_PREFIX + name.getMethodName()); LoggingUtils.setLoggingLevel(Level.INFO); - Monitor monitor = new Monitor(); - TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 2000, 2000); + final Monitor monitor = new Monitor(); + final TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 2000, 2000); final int expected = 2; final String hostAddress = this.localAddressProvider.getLocalAddress(); final int port = 9100; // Codec<String> - ReceiverStage<String> stage = new ReceiverStage<String>(new ObjectSerializableCodec<String>(), monitor, expected); - Transport transport = tpFactory.newInstance(hostAddress, port, stage, stage, 1, 10000); + final ReceiverStage<String> stage = + new ReceiverStage<String>(new ObjectSerializableCodec<String>(), monitor, expected); + final Transport transport = tpFactory.newInstance(hostAddress, port, stage, stage, 1, 10000); // sending side - Link<String> link = transport.open( + final Link<String> link = transport.open( new InetSocketAddress(hostAddress, port), new ObjectSerializableCodec<String>(), new LoggingLinkListener<String>()); @@ -94,20 +95,20 @@ public class TransportTest { System.out.println(LOG_PREFIX + name.getMethodName()); LoggingUtils.setLoggingLevel(Level.INFO); - Monitor monitor = new Monitor(); - TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 2000, 2000); + final Monitor monitor = new Monitor(); + final TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 2000, 2000); final int expected = 2; final String hostAddress = this.localAddressProvider.getLocalAddress(); final int port = 9100; // Codec<TestEvent> - ReceiverStage<TestEvent> stage = + final ReceiverStage<TestEvent> stage = new ReceiverStage<TestEvent>(new ObjectSerializableCodec<TestEvent>(), monitor, expected); - Transport transport = tpFactory.newInstance(hostAddress, port, stage, stage, 1, 10000); + final Transport transport = tpFactory.newInstance(hostAddress, port, stage, stage, 1, 10000); // sending side - Link<TestEvent> link = transport.open( + final Link<TestEvent> link = transport.open( new InetSocketAddress(hostAddress, port), new ObjectSerializableCodec<TestEvent>(), new LoggingLinkListener<TestEvent>()); @@ -128,7 +129,7 @@ public class TransportTest { private final int expected; private AtomicInteger count = new AtomicInteger(0); - ReceiverStage(Codec<T> codec, Monitor monitor, int expected) { + ReceiverStage(final Codec<T> codec, final Monitor monitor, final int expected) { this.codec = codec; this.monitor = monitor; this.expected = expected; @@ -139,7 +140,7 @@ public class TransportTest { } @Override - public void onNext(TransportEvent value) { + public void onNext(final TransportEvent value) { codec.decode(value.getData()); //System.out.println(value + " " + obj); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/RxTest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/RxTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/RxTest.java index bb3d112..79ca91c 100644 --- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/RxTest.java +++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/RxTest.java @@ -35,7 +35,7 @@ public class RxTest { public void testRx() throws Exception { System.out.println(name.getMethodName()); - RxStage<TestEvent> stage = new RxThreadPoolStage<TestEvent>(new TestObserver("o1"), 1); + final RxStage<TestEvent> stage = new RxThreadPoolStage<TestEvent>(new TestObserver("o1"), 1); int i = 0; try { @@ -43,7 +43,7 @@ public class RxTest { stage.onNext(new TestEvent(i)); } stage.onCompleted(); - } catch (Exception e) { + } catch (final Exception e) { stage.onError(e); } @@ -53,7 +53,7 @@ public class RxTest { class TestEvent { private int n; - TestEvent(int n) { + TestEvent(final int n) { this.n = n; } @@ -66,17 +66,17 @@ public class RxTest { private final String name; - TestObserver(String name) { + TestObserver(final String name) { this.name = name; } @Override - public void onNext(TestEvent value) { + public void onNext(final TestEvent value) { System.out.println(name + " Value: " + value + " " + value.get()); } @Override - public void onError(Exception error) { + public void onError(final Exception error) { System.out.println(name + " Error: " + error); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/RxThreadPoolStageTest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/RxThreadPoolStageTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/RxThreadPoolStageTest.java index 5c8adbc..ca5b165 100644 --- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/RxThreadPoolStageTest.java +++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/RxThreadPoolStageTest.java @@ -41,8 +41,8 @@ public class RxThreadPoolStageTest { public void testOne() throws Exception { System.out.println(name.getMethodName()); - TestObserver to = new TestObserver("o1"); - RxStage<TestEvent> stage = new RxThreadPoolStage<TestEvent>(to, 1); + final TestObserver to = new TestObserver("o1"); + final RxStage<TestEvent> stage = new RxThreadPoolStage<TestEvent>(to, 1); int i = 0; int sum = 0; @@ -52,7 +52,7 @@ public class RxThreadPoolStageTest { sum += i; } stage.onCompleted(); - } catch (Exception e) { + } catch (final Exception e) { stage.onError(e); } @@ -67,8 +67,8 @@ public class RxThreadPoolStageTest { public void testMultipleThreads() throws Exception { System.out.println(name.getMethodName()); - TestObserver to = new TestObserver("o1"); - RxStage<TestEvent> stage = new RxThreadPoolStage<TestEvent>(to, 11); + final TestObserver to = new TestObserver("o1"); + final RxStage<TestEvent> stage = new RxThreadPoolStage<TestEvent>(to, 11); int i = 0; int sum = 0; @@ -78,7 +78,7 @@ public class RxThreadPoolStageTest { sum += i; } stage.onCompleted(); - } catch (Exception e) { + } catch (final Exception e) { stage.onError(e); } @@ -93,12 +93,12 @@ public class RxThreadPoolStageTest { public void testMultipleCallers() throws Exception { System.out.println(name.getMethodName()); - TestObserver to = new TestObserver("o1"); + final TestObserver to = new TestObserver("o1"); final RxStage<TestEvent> stage = new RxThreadPoolStage<TestEvent>(to, 11); final int tn = 7; - ExecutorService taskmaster = Executors.newFixedThreadPool(tn); - List<Future<Integer>> handles = new ArrayList<>(); + final ExecutorService taskmaster = Executors.newFixedThreadPool(tn); + final List<Future<Integer>> handles = new ArrayList<>(); for (int t = 0; t < tn; t++) { handles.add(taskmaster.submit(new Callable<Integer>() { @Override @@ -113,7 +113,7 @@ public class RxThreadPoolStageTest { })); } int sum = 0; - for (Future<Integer> h : handles) { + for (final Future<Integer> h : handles) { try { sum += h.get(); } catch (InterruptedException | ExecutionException e1) { @@ -124,7 +124,7 @@ public class RxThreadPoolStageTest { try { stage.onCompleted(); - } catch (Exception e) { + } catch (final Exception e) { stage.onError(e); } @@ -138,7 +138,7 @@ public class RxThreadPoolStageTest { class TestEvent { private int n; - TestEvent(int n) { + TestEvent(final int n) { this.n = n; } @@ -154,7 +154,7 @@ public class RxThreadPoolStageTest { private final AtomicInteger completes = new AtomicInteger(0); private final String name; - TestObserver(String name) { + TestObserver(final String name) { this.name = name; } @@ -171,13 +171,13 @@ public class RxThreadPoolStageTest { } @Override - public void onNext(TestEvent value) { + public void onNext(final TestEvent value) { System.out.println(name + " Value: " + value + " " + value.get()); events.addAndGet(value.get()); } @Override - public void onError(Exception error) { + public void onError(final Exception error) { System.out.println(name + " Error: " + error); errors.incrementAndGet(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/TimeoutSubjectTest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/TimeoutSubjectTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/TimeoutSubjectTest.java index 5cc6c71..0fc0b0d 100644 --- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/TimeoutSubjectTest.java +++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/TimeoutSubjectTest.java @@ -38,15 +38,15 @@ public class TimeoutSubjectTest { final AtomicInteger nexts = new AtomicInteger(0); final AtomicInteger completes = new AtomicInteger(0); final int delta = 400; - Subject<Integer, Integer> dut = new TimeoutSubject<>(10000, new Observer<Integer>() { + final Subject<Integer, Integer> dut = new TimeoutSubject<>(10000, new Observer<Integer>() { @Override - public void onNext(Integer value) { + public void onNext(final Integer value) { nexts.addAndGet(delta); } @Override - public void onError(Exception error) { + public void onError(final Exception error) { fail(error.toString()); } @@ -70,12 +70,12 @@ public class TimeoutSubjectTest { final Subject<Integer, Integer> dut = new TimeoutSubject<>(10000, new Observer<Integer>() { @Override - public void onNext(Integer value) { + public void onNext(final Integer value) { nexts.addAndGet(delta); } @Override - public void onError(Exception error) { + public void onError(final Exception error) { fail(error.toString()); } @@ -86,7 +86,7 @@ public class TimeoutSubjectTest { } }); - ExecutorService e = Executors.newSingleThreadExecutor(); + final ExecutorService e = Executors.newSingleThreadExecutor(); e.submit(new Runnable() { @Override public void run() { @@ -97,7 +97,7 @@ public class TimeoutSubjectTest { e.shutdown(); try { e.awaitTermination(11000, TimeUnit.MILLISECONDS); - } catch (InterruptedException e1) { + } catch (final InterruptedException e1) { e1.printStackTrace(); fail(e1.toString()); } @@ -111,15 +111,15 @@ public class TimeoutSubjectTest { final int timeout = 1; final int sleep = 500; final AtomicInteger errors = new AtomicInteger(0); - Subject<Integer, Integer> dut = new TimeoutSubject<>(timeout, new Observer<Integer>() { + final Subject<Integer, Integer> dut = new TimeoutSubject<>(timeout, new Observer<Integer>() { @Override - public void onNext(Integer value) { + public void onNext(final Integer value) { fail("Should not get called"); } @Override - public void onError(Exception error) { + public void onError(final Exception error) { assertTrue(error instanceof TimeoutException); errors.incrementAndGet(); } @@ -132,7 +132,7 @@ public class TimeoutSubjectTest { try { Thread.sleep(sleep); - } catch (InterruptedException e) { + } catch (final InterruptedException e) { e.printStackTrace(); fail(e.toString()); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/time/ClockTest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/time/ClockTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/time/ClockTest.java index eb80884..f08f16b 100644 --- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/time/ClockTest.java +++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/time/ClockTest.java @@ -180,7 +180,7 @@ public class ClockTest { final EventRecorder alarmRecorder = new EventRecorder(eventCountLatch); try { - long[] expected = new long[numAlarms]; + final long[] expected = new long[numAlarms]; for (int i = 0; i < numAlarms; ++i) { clock.scheduleAlarm(i * 100, alarmRecorder); expected[i] = i * 100; @@ -188,9 +188,9 @@ public class ClockTest { eventCountLatch.await(10, TimeUnit.SECONDS); - Long[] actualLong = new Long[numAlarms]; + final Long[] actualLong = new Long[numAlarms]; alarmRecorder.getTimestamps().toArray(actualLong); - long[] actual = new long[numAlarms]; + final long[] actual = new long[numAlarms]; for (int i = 0; i < numAlarms; ++i) { actual[i] = actualLong[i]; } @@ -217,7 +217,7 @@ public class ClockTest { this(null); } - public EventRecorder(CountDownLatch latch) { + public EventRecorder(final CountDownLatch latch) { eventCountLatch = latch; } @@ -245,7 +245,7 @@ public class ClockTest { private final CountDownLatch eventCountLatch; private final Random rand; - public RandomAlarmProducer(RuntimeClock clock, CountDownLatch latch) { + public RandomAlarmProducer(final RuntimeClock clock, final CountDownLatch latch) { this.clock = clock; this.eventCountLatch = latch; this.rand = new Random(); @@ -253,7 +253,7 @@ public class ClockTest { @Override public void onNext(final Alarm value) { - int duration = rand.nextInt(100) + 1; + final int duration = rand.nextInt(100) + 1; clock.scheduleAlarm(duration, this); eventCountLatch.countDown(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/util/PassThroughEncoder.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/util/PassThroughEncoder.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/util/PassThroughEncoder.java index 390e3c9..ae47b3e 100644 --- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/util/PassThroughEncoder.java +++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/util/PassThroughEncoder.java @@ -29,7 +29,7 @@ public class PassThroughEncoder implements Encoder<byte[]> { * @see org.apache.reef.wake.remote.Encoder#encode(java.lang.Object) */ @Override - public byte[] encode(byte[] obj) { + public byte[] encode(final byte[] obj) { return obj; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/util/TimeoutHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/util/TimeoutHandler.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/util/TimeoutHandler.java index ad3da25..4864192 100644 --- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/util/TimeoutHandler.java +++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/util/TimeoutHandler.java @@ -25,12 +25,12 @@ public class TimeoutHandler implements EventHandler<PeriodicEvent> { private final Monitor monitor; - public TimeoutHandler(Monitor monitor) { + public TimeoutHandler(final Monitor monitor) { this.monitor = monitor; } @Override - public void onNext(PeriodicEvent event) { + public void onNext(final PeriodicEvent event) { monitor.mnotify(); } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServerReefEventHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServerReefEventHandler.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServerReefEventHandler.java index 1d0e35e..df654a2 100644 --- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServerReefEventHandler.java +++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServerReefEventHandler.java @@ -178,7 +178,7 @@ public final class HttpServerReefEventHandler implements HttpHandler { try { final byte[] outputBody = readFile((String) names.get(0)).getBytes(Charset.forName("UTF-8")); response.getOutputStream().write(outputBody); - } catch(IOException e) { + } catch(final IOException e) { response.getWriter().println(String.format("Cannot find the log file: [%s].", fileName)); } break; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/ReefEventStateManager.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/ReefEventStateManager.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/ReefEventStateManager.java index 6143bc2..5ea15a0 100644 --- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/ReefEventStateManager.java +++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/ReefEventStateManager.java @@ -148,7 +148,7 @@ public final class ReefEventStateManager { return this.serviceInfoList; } - public void registerServiceInfo(AvroReefServiceInfo serviceInfo) { + public void registerServiceInfo(final AvroReefServiceInfo serviceInfo) { synchronized (this.serviceInfoList) { serviceInfoList.add(serviceInfo); LOG.log(Level.INFO, "Registered Service [{0}] with Info [{1}]", http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestAvroHttpSerializer.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestAvroHttpSerializer.java b/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestAvroHttpSerializer.java index ac69ca1..4c57133 100644 --- a/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestAvroHttpSerializer.java +++ b/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestAvroHttpSerializer.java @@ -40,7 +40,7 @@ public final class TestAvroHttpSerializer { private AvroHttpRequest avroRequest; private AvroHttpSerializer avroHttpSerializer; - public static String readStream(InputStream is) { + public static String readStream(final InputStream is) { final StringBuilder sb = new StringBuilder(512); try { final Reader r = new InputStreamReader(is, "UTF-8"); @@ -48,7 +48,7 @@ public final class TestAvroHttpSerializer { while ((c = r.read()) != -1) { sb.append((char) c); } - } catch (IOException e) { + } catch (final IOException e) { throw new RuntimeException(e); } return sb.toString();
