[REEF-513] Add FinalParameters to checkstyle This addressed the issue by * Adding FinalParameters to checkstyle.xml. * Fixing checkstyle violations.
JIRA: [REEF-513](https://issues.apache.org/jira/browse/REEF-513) Pull Request: This closes #317 Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/141c7fa0 Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/141c7fa0 Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/141c7fa0 Branch: refs/heads/master Commit: 141c7fa08cbcaf4930f6456d13297ef89ebd7b94 Parents: e5aef16 Author: Andrew Chung <[email protected]> Authored: Mon Jul 27 16:07:19 2015 -0700 Committer: Brian Cho <[email protected]> Committed: Tue Jul 28 13:56:39 2015 +0900 ---------------------------------------------------------------------- .../apache/reef/bridge/client/LocalClient.java | 12 +- .../bridge/client/YarnJobSubmissionClient.java | 8 +- .../javabridge/AllocatedEvaluatorBridge.java | 19 +- .../reef/javabridge/ClosedContextBridge.java | 2 +- .../javabridge/CompletedEvaluatorBridge.java | 2 +- .../reef/javabridge/ContextMessageBridge.java | 2 +- .../reef/javabridge/FailedContextBridge.java | 2 +- .../reef/javabridge/FailedEvaluatorBridge.java | 6 +- .../apache/reef/javabridge/InteropLogger.java | 4 +- .../reef/javabridge/InteropReturnInfo.java | 4 +- .../org/apache/reef/javabridge/JavaBridge.java | 2 +- .../org/apache/reef/javabridge/LibLoader.java | 2 +- .../apache/reef/javabridge/NativeBridge.java | 2 +- .../apache/reef/javabridge/NativeInterop.java | 90 +++---- .../reef/javabridge/TaskMessageBridge.java | 2 +- .../org/apache/reef/javabridge/Utilities.java | 6 +- .../reef/javabridge/generic/JobClient.java | 14 +- .../reef/javabridge/generic/JobDriver.java | 40 +-- .../apache/reef/javabridge/generic/Launch.java | 2 +- .../reef/javabridge/generic/LaunchHeadless.java | 2 +- .../util/logging/CLRBufferedLogHandler.java | 4 +- .../reef/io/checkpoint/fs/FSCheckpointID.java | 8 +- .../io/checkpoint/fs/FSCheckpointService.java | 8 +- .../io/WorkingDirectoryTempFileCreator.java | 2 +- .../reef/runtime/common/REEFLauncher.java | 8 +- .../common/client/JobStatusMessageHandler.java | 2 +- .../runtime/common/client/RunningJobsImpl.java | 3 +- .../resourcemanager/NodeDescriptorHandler.java | 2 +- .../resourcemanager/ResourceManagerStatus.java | 2 +- .../resourcemanager/ResourceStatusHandler.java | 2 +- .../common/evaluator/EvaluatorRuntime.java | 2 +- .../common/launch/CLRLaunchCommandBuilder.java | 2 +- .../org/apache/reef/util/EnvironmentUtils.java | 7 +- .../java/org/apache/reef/util/REEFVersion.java | 2 +- .../org/apache/reef/util/logging/LogParser.java | 12 +- .../src/main/resources/checkstyle.xml | 1 + .../org/apache/reef/util/DeadlockInfoTest.java | 8 +- .../apache/reef/examples/helloCLR/HelloCLR.java | 2 +- .../bgd/loss/SquaredErrorLossFunction.java | 4 +- .../bgd/loss/WeightedLogisticLossFunction.java | 4 +- .../examples/group/utils/math/VectorCodec.java | 16 +- .../reef/examples/group/utils/math/Window.java | 15 +- .../reef/examples/hello/HelloReefYarnTcp.java | 6 +- .../hellohttp/HttpServerShellCmdtHandler.java | 2 +- .../apache/reef/examples/library/ShellTask.java | 2 +- .../reef/examples/scheduler/Scheduler.java | 2 +- .../examples/scheduler/SchedulerDriver.java | 8 +- .../scheduler/SchedulerHttpHandler.java | 4 +- .../reef/examples/scheduler/SchedulerREEF.java | 2 +- .../examples/scheduler/SchedulerREEFYarn.java | 2 +- .../reef/examples/scheduler/TaskEntity.java | 4 +- .../examples/suspend/ObjectWritableCodec.java | 4 +- .../reef/examples/suspend/SuspendTestTask.java | 2 +- .../utils/wake/LoggingEventHandler.java | 2 +- .../impl/InMemoryInputFormatDataSet.java | 2 +- ...iDataCenterEvaluatorToPartitionStrategy.java | 15 +- .../data/loading/impl/WritableSerializer.java | 20 +- .../io/network/NetworkConnectionService.java | 3 +- .../exception/NetworkRuntimeException.java | 6 +- .../group/impl/driver/GroupCommDriverImpl.java | 2 +- .../group/impl/operators/BroadcastReceiver.java | 2 +- .../network/group/impl/task/NodeStructImpl.java | 2 +- .../impl/task/OperatorTopologyStructImpl.java | 2 +- .../reef/io/network/impl/NSConnection.java | 2 +- .../reef/io/network/impl/NSMessageCodec.java | 2 +- .../reef/io/network/impl/NetworkConnection.java | 2 +- .../impl/NetworkConnectionServiceImpl.java | 4 +- .../impl/NetworkConnectionServiceMessage.java | 4 +- .../reef/io/network/impl/NetworkService.java | 2 +- .../impl/NetworkServiceClosingHandler.java | 4 +- .../io/network/naming/NameAssignmentTuple.java | 2 +- .../reef/io/network/naming/NameCache.java | 8 +- .../reef/io/network/naming/NameClient.java | 8 +- .../io/network/naming/NameRegistryClient.java | 16 +- .../reef/io/network/naming/NameServerImpl.java | 4 +- .../io/network/naming/NamingCodecFactory.java | 18 +- .../naming/exception/NamingException.java | 6 +- .../exception/NamingRuntimeException.java | 6 +- .../network/naming/serialization/AvroUtils.java | 2 +- .../serialization/NamingLookupRequest.java | 2 +- .../serialization/NamingLookupResponse.java | 2 +- .../NamingLookupResponseCodec.java | 2 +- .../naming/serialization/NamingMessage.java | 2 +- .../serialization/NamingRegisterRequest.java | 2 +- .../NamingRegisterRequestCodec.java | 6 +- .../serialization/NamingRegisterResponse.java | 2 +- .../NamingRegisterResponseCodec.java | 6 +- .../serialization/NamingUnregisterRequest.java | 2 +- .../NamingUnregisterRequestCodec.java | 4 +- .../reef/io/network/util/StringCodec.java | 4 +- .../reef/io/network/util/StringIdentifier.java | 6 +- .../network/util/StringIdentifierFactory.java | 2 +- .../reef/io/storage/FramingInputStream.java | 12 +- .../reef/io/storage/FramingOutputStream.java | 18 +- .../io/storage/FramingTupleDeserializer.java | 16 +- .../reef/io/storage/FramingTupleSerializer.java | 4 +- .../apache/reef/io/storage/MergingIterator.java | 8 +- .../io/storage/local/LocalScratchSpace.java | 10 +- .../io/storage/local/LocalStorageService.java | 2 +- .../io/storage/local/SerializerFileSpool.java | 2 +- .../apache/reef/io/storage/ram/CodecRamMap.java | 4 +- .../org/apache/reef/io/storage/ram/RamMap.java | 14 +- .../apache/reef/io/storage/ram/RamSpool.java | 4 +- .../reef/io/storage/ram/SortingRamSpool.java | 8 +- .../reef/io/storage/util/GetAllIterable.java | 6 +- .../reef/io/storage/util/IntegerCodec.java | 4 +- .../io/storage/util/IntegerDeserializer.java | 4 +- .../reef/io/storage/util/IntegerSerializer.java | 8 +- .../io/storage/util/StringDeserializer.java | 6 +- .../reef/io/storage/util/StringSerializer.java | 10 +- .../io/storage/util/TupleKeyComparator.java | 4 +- .../reef/services/network/NameClientTest.java | 10 +- .../reef/services/network/NamingTest.java | 6 +- .../network/NetworkConnectionServiceTest.java | 29 +-- .../services/network/NetworkServiceTest.java | 104 ++++---- .../apache/reef/services/network/TestEvent.java | 2 +- .../services/network/util/LoggingUtils.java | 6 +- .../util/NetworkMessagingTestService.java | 6 +- .../network/util/StreamingIntegerCodec.java | 12 +- .../network/util/StreamingStringCodec.java | 12 +- .../reef/services/network/util/StringCodec.java | 4 +- .../services/network/util/TimeoutHandler.java | 4 +- .../reef/services/storage/ExternalMapTest.java | 24 +- .../reef/services/storage/FramingTest.java | 38 +-- .../services/storage/MergingIteratorTest.java | 2 +- .../reef/services/storage/SortingSpoolTest.java | 42 ++-- .../reef/services/storage/SpoolFileTest.java | 38 +-- .../services/storage/TupleSerializerTest.java | 12 +- .../client/sslhacks/UnsafeHostNameVerifier.java | 8 +- .../client/yarnrest/AmContainerSpec.java | 6 +- .../client/yarnrest/ApplicationID.java | 6 +- .../client/yarnrest/ApplicationResponse.java | 6 +- .../client/yarnrest/ApplicationState.java | 50 ++-- .../client/yarnrest/ApplicationSubmission.java | 28 +-- .../hdinsight/client/yarnrest/Commands.java | 6 +- .../hdinsight/client/yarnrest/Credentials.java | 10 +- .../yarnrest/ListApplicationResponse.java | 6 +- .../client/yarnrest/LocalResource.java | 6 +- .../client/yarnrest/LocalResourcesEntry.java | 6 +- .../hdinsight/client/yarnrest/Resource.java | 6 +- .../hdinsight/client/yarnrest/StringEntry.java | 6 +- .../TestHDInsightRESTJsonSerialization.java | 64 ++--- .../client/PreparedDriverFolderLauncher.java | 3 +- .../local/driver/ResourceManagerTest.java | 2 +- .../mesos/client/MesosJobSubmissionHandler.java | 2 +- .../driver/MesosResourceLaunchHandler.java | 2 +- .../runtime/mesos/driver/REEFScheduler.java | 6 +- .../yarn/client/YarnJobSubmissionHandler.java | 4 +- .../yarn/client/uploader/JobUploader.java | 2 +- .../yarn/driver/EvaluatorSetupHelper.java | 2 +- .../runtime/yarn/driver/GlobalJarUploader.java | 2 +- .../JobSubmissionDirectoryProviderImpl.java | 2 +- .../yarn/driver/YarnContainerManager.java | 4 +- .../org/apache/reef/tang/InjectionFuture.java | 12 +- .../org/apache/reef/tang/examples/Timer.java | 18 +- .../org/apache/reef/tang/examples/TimerV1.java | 16 +- .../reef/tang/examples/timer/TimerImpl.java | 2 +- .../reef/tang/examples/timer/TimerMock.java | 8 +- .../reef/tang/exceptions/BindException.java | 4 +- .../exceptions/ClassHierarchyException.java | 6 +- .../tang/exceptions/InjectionException.java | 4 +- .../exceptions/NameResolutionException.java | 2 +- .../reef/tang/exceptions/ParseException.java | 4 +- .../formats/AvroConfigurationSerializer.java | 2 +- .../apache/reef/tang/formats/CommandLine.java | 2 +- .../reef/tang/formats/ConfigurationFile.java | 48 ++-- .../reef/tang/formats/ConfigurationModule.java | 84 +++---- .../formats/ConfigurationModuleBuilder.java | 141 +++++------ .../reef/tang/formats/ParameterParser.java | 30 +-- .../ConfigurationBuilderImpl.java | 108 ++++---- .../tang/implementation/ConfigurationImpl.java | 6 +- .../implementation/InjectionFuturePlan.java | 2 +- .../reef/tang/implementation/InjectionPlan.java | 10 +- .../tang/implementation/ListInjectionPlan.java | 16 +- .../tang/implementation/SetInjectionPlan.java | 16 +- .../tang/implementation/StackBindLocation.java | 6 +- .../reef/tang/implementation/Subplan.java | 22 +- .../reef/tang/implementation/TangImpl.java | 41 ++-- .../implementation/avro/AvroClassHierarchy.java | 8 +- .../avro/AvroClassHierarchySerializer.java | 2 +- .../implementation/java/ClassHierarchyImpl.java | 113 +++++---- .../tang/implementation/java/InjectorImpl.java | 203 ++++++++------- .../java/JavaConfigurationBuilderImpl.java | 44 ++-- .../tang/implementation/java/JavaInstance.java | 2 +- .../implementation/java/JavaNodeFactory.java | 69 +++--- .../protobuf/ProtocolBufferClassHierarchy.java | 157 ++++++------ .../protobuf/ProtocolBufferInjectionPlan.java | 33 +-- .../tang/implementation/types/AbstractNode.java | 20 +- .../implementation/types/ClassNodeImpl.java | 28 +-- .../types/ConstructorArgImpl.java | 6 +- .../types/ConstructorDefImpl.java | 22 +- .../types/NamedParameterNodeImpl.java | 9 +- .../implementation/types/PackageNodeImpl.java | 4 +- .../tang/util/AbstractMonotonicMultiMap.java | 44 ++-- .../apache/reef/tang/util/MonotonicHashMap.java | 12 +- .../apache/reef/tang/util/MonotonicHashSet.java | 20 +- .../org/apache/reef/tang/util/MonotonicSet.java | 20 +- .../apache/reef/tang/util/MonotonicTreeMap.java | 10 +- .../reef/tang/util/ReflectionUtilities.java | 87 +++---- .../java/org/apache/reef/tang/util/Tint.java | 227 ++++++++--------- .../reef/tang/util/TracingMonotonicTreeMap.java | 22 +- .../reef/tang/util/ValidateConfiguration.java | 26 +- .../walk/graphviz/GraphvizConfigVisitor.java | 4 +- .../tang/ClassHierarchyDeserializationTest.java | 4 +- .../org/apache/reef/tang/TestBindSingleton.java | 76 +++--- .../org/apache/reef/tang/TestClassLoaders.java | 28 +-- .../apache/reef/tang/TestConfFileParser.java | 24 +- .../reef/tang/TestImplicitConversions.java | 36 +-- .../apache/reef/tang/TestInjectionFuture.java | 60 +++-- .../org/apache/reef/tang/TestListInjection.java | 111 +++++---- .../reef/tang/TestNamedParameterRoundTrip.java | 2 +- .../org/apache/reef/tang/TestSetInjection.java | 64 ++--- .../java/org/apache/reef/tang/TestTang.java | 246 +++++++++---------- .../org/apache/reef/tang/TestTweetExample.java | 8 +- ...urationSerializerByteArrayRoundtripTest.java | 5 +- ...onfigurationSerializerFileRoundtripTest.java | 5 +- ...gurationSerializerTextFileRoundtripTest.java | 5 +- .../tang/formats/TestConfigurationModule.java | 67 +++-- .../tang/implementation/TestClassHierarchy.java | 54 ++-- .../avro/TestClassHierarchyRoundTrip.java | 8 +- .../java/TestConfigurationBuilder.java | 2 +- .../java/TestParameterParser.java | 54 ++-- .../tang/test/AnInterfaceImplementation.java | 4 +- .../apache/reef/tang/test/CyclicDependency.java | 4 +- .../tang/test/CyclicDependencyClassOne.java | 4 +- .../tang/test/CyclicDependencyClassTwo.java | 4 +- .../apache/reef/tang/test/InjectableClass.java | 4 +- .../reef/tang/test/ListInterfaceImplOne.java | 4 +- .../reef/tang/test/ListInterfaceImplTwo.java | 6 +- .../apache/reef/tang/test/ListOfBaseTypes.java | 4 +- .../reef/tang/test/ListOfImplementations.java | 4 +- .../reef/tang/test/RootImplementation.java | 10 +- .../test/RootImplementationWithoutList.java | 10 +- .../reef/tang/test/SetInterfaceImplOne.java | 4 +- .../reef/tang/test/SetInterfaceImplTwo.java | 6 +- .../apache/reef/tang/test/SetOfBaseTypes.java | 4 +- .../reef/tang/test/SetOfImplementations.java | 4 +- .../org/apache/reef/tang/test/UnitClass.java | 12 +- .../EvaluatorReuseTestDriver.java | 2 +- .../apache/reef/tests/fail/driver/NoopTask.java | 2 +- .../driver/OnDriverStartedAllocateOne.java | 2 +- .../exceptions/ExpectedTaskException.java | 8 +- .../reef/tests/library/tasks/EchoTask.java | 2 +- .../reef/tests/library/tasks/NoopTask.java | 2 +- .../tests/messaging/task/TaskMessagingTask.java | 2 +- .../tests/statepassing/StatePassingTask.java | 2 +- .../java/org/apache/reef/tests/TestUtils.java | 7 +- .../ConfigurationProviderTestDriver.java | 2 +- .../EvaluatorFailureDuringAlarmDriver.java | 2 +- .../FailureSchedulingContextStartHandler.java | 2 +- .../reef/tests/files/FileResourceTestTask.java | 2 +- .../ActiveContextHandler.java | 6 +- .../ClosedContextHandler.java | 2 +- .../CompletedEvaluatorHandler.java | 2 +- .../CompletedTaskHandler.java | 2 +- .../EmptyTask.java | 2 +- .../RunningTaskHandler.java | 2 +- .../StartHandler.java | 2 +- .../apache/reef/util/cache/WrappedValue.java | 4 +- .../util/cache/CacheImplConcurrentTest.java | 12 +- .../org/apache/reef/wake/AbstractEStage.java | 2 +- .../org/apache/reef/wake/IdentifierParser.java | 4 +- .../org/apache/reef/wake/WakeConfiguration.java | 8 +- .../wake/examples/accumulate/CombinerStage.java | 18 +- .../reef/wake/examples/join/BlockingJoin.java | 12 +- .../reef/wake/examples/join/EventPrinter.java | 4 +- .../wake/examples/join/NonBlockingJoin.java | 10 +- .../reef/wake/examples/join/TupleEvent.java | 6 +- .../reef/wake/examples/join/TupleSource.java | 2 +- .../reef/wake/impl/BlockingEventHandler.java | 4 +- .../wake/impl/BlockingSignalEventHandler.java | 2 +- .../wake/impl/DefaultIdentifierFactory.java | 16 +- .../reef/wake/impl/DefaultThreadFactory.java | 14 +- .../apache/reef/wake/impl/ForkPoolStage.java | 12 +- .../IndependentIterationsThreadPoolStage.java | 5 +- .../reef/wake/impl/LoggingEventHandler.java | 2 +- .../org/apache/reef/wake/impl/LoggingUtils.java | 6 +- .../reef/wake/impl/LoggingVoidEventHandler.java | 2 +- .../reef/wake/impl/MergingEventHandler.java | 2 +- .../reef/wake/impl/MultiEventHandler.java | 6 +- .../reef/wake/impl/PubSubEventHandler.java | 8 +- .../reef/wake/impl/SingleThreadStage.java | 11 +- .../org/apache/reef/wake/impl/SyncStage.java | 2 +- .../apache/reef/wake/impl/ThreadPoolStage.java | 4 +- .../org/apache/reef/wake/impl/TimerStage.java | 2 +- .../apache/reef/wake/impl/WakeSharedPool.java | 8 +- .../wake/impl/WakeUncaughtExceptionHandler.java | 4 +- .../java/org/apache/reef/wake/metrics/EWMA.java | 6 +- .../org/apache/reef/wake/metrics/Meter.java | 4 +- .../reef/wake/metrics/UniformHistogram.java | 6 +- .../org/apache/reef/wake/profiler/Vertex.java | 11 +- .../apache/reef/wake/profiler/WakeProfiler.java | 92 +++---- .../reef/wake/remote/DefaultErrorHandler.java | 2 +- .../address/LegacyLocalAddressProvider.java | 20 +- .../address/LocalAddressProviderFactory.java | 2 +- .../exception/RemoteRuntimeException.java | 6 +- .../apache/reef/wake/remote/impl/ByteCodec.java | 4 +- .../wake/remote/impl/ConnectFutureTask.java | 2 +- ...ltRemoteIdentifierFactoryImplementation.java | 5 +- .../impl/DefaultRemoteManagerFactory.java | 3 +- .../wake/remote/impl/DefaultRemoteMessage.java | 2 +- .../remote/impl/DefaultTransportEStage.java | 2 +- .../reef/wake/remote/impl/MultiCodec.java | 12 +- .../reef/wake/remote/impl/MultiDecoder.java | 16 +- .../reef/wake/remote/impl/MultiEncoder.java | 8 +- .../remote/impl/OrderedRemoteReceiverStage.java | 29 +-- .../wake/remote/impl/ProxyEventHandler.java | 8 +- .../reef/wake/remote/impl/RemoteEvent.java | 13 +- .../reef/wake/remote/impl/RemoteEventCodec.java | 6 +- .../wake/remote/impl/RemoteEventComparator.java | 2 +- .../wake/remote/impl/RemoteEventDecoder.java | 8 +- .../wake/remote/impl/RemoteEventEncoder.java | 8 +- .../remote/impl/RemoteReceiverEventHandler.java | 6 +- .../wake/remote/impl/RemoteReceiverStage.java | 4 +- .../remote/impl/RemoteSenderEventHandler.java | 20 +- .../wake/remote/impl/RemoteSeqNumGenerator.java | 2 +- .../remote/impl/SocketRemoteIdentifier.java | 16 +- .../reef/wake/remote/impl/StringCodec.java | 4 +- .../reef/wake/remote/impl/Subscription.java | 2 +- .../reef/wake/remote/impl/TransportEvent.java | 4 +- .../apache/reef/wake/remote/impl/Tuple2.java | 6 +- .../wake/remote/ports/RandomRangeIterator.java | 2 +- .../exception/TransportRuntimeException.java | 6 +- .../netty/AbstractNettyEventListener.java | 4 +- .../remote/transport/netty/ByteEncoder.java | 2 +- .../netty/ChunkedReadWriteHandler.java | 10 +- .../transport/netty/LoggingLinkListener.java | 4 +- .../netty/MessagingTransportFactory.java | 12 +- .../netty/NettyChannelInitializer.java | 2 +- .../wake/remote/transport/netty/NettyLink.java | 4 +- .../netty/NettyMessagingTransport.java | 33 +-- .../apache/reef/wake/rx/AbstractRxStage.java | 2 +- .../apache/reef/wake/rx/impl/RxSyncStage.java | 8 +- .../reef/wake/rx/impl/RxThreadPoolStage.java | 6 +- .../apache/reef/wake/rx/impl/SimpleSubject.java | 6 +- .../reef/wake/rx/impl/TimeoutSubject.java | 10 +- .../reef/wake/storage/FileHandlePool.java | 4 +- .../reef/wake/storage/FileIdentifier.java | 4 +- .../apache/reef/wake/storage/ReadRequest.java | 2 +- .../reef/wake/storage/SequentialFileReader.java | 8 +- .../java/org/apache/reef/wake/time/Time.java | 4 +- .../reef/wake/time/runtime/LogicalTimer.java | 4 +- .../reef/wake/time/runtime/RuntimeClock.java | 8 +- .../wake/test/BlockingEventHandlerTest.java | 50 ++-- .../test/BlockingSignalEventHandlerTest.java | 40 +-- .../reef/wake/test/ForkPoolStageTest.java | 72 +++--- ...ndependentIterationsThreadPoolStageTest.java | 14 +- .../org/apache/reef/wake/test/MetricsTest.java | 4 +- .../wake/test/PubSubThreadPoolStageTest.java | 22 +- .../apache/reef/wake/test/StageManagerTest.java | 2 +- .../apache/reef/wake/test/SyncStageTest.java | 30 +-- .../reef/wake/test/ThreadPoolStageTest.java | 62 ++--- .../apache/reef/wake/test/TimerStageTest.java | 12 +- .../reef/wake/test/examples/SkipListTest.java | 136 +++++----- .../wake/test/examples/TestBlockingJoin.java | 8 +- .../reef/wake/test/examples/TestCombiner.java | 28 +-- .../reef/wake/test/examples/TestJoin.java | 8 +- .../wake/test/examples/TestTupleSource.java | 4 +- .../reef/wake/test/remote/LargeMsgTest.java | 24 +- .../remote/RemoteIdentifierFactoryTest.java | 8 +- .../wake/test/remote/RemoteManagerTest.java | 175 ++++++------- .../reef/wake/test/remote/RemoteTest.java | 68 ++--- .../wake/test/remote/SmallMessagesTest.java | 48 ++-- .../apache/reef/wake/test/remote/TestEvent.java | 2 +- .../reef/wake/test/remote/TestEvent1.java | 2 +- .../reef/wake/test/remote/TestEvent2.java | 2 +- .../reef/wake/test/remote/TestEventCodec.java | 10 +- .../reef/wake/test/remote/TestRemote.java | 22 +- .../wake/test/remote/TestRemoteIdentifier.java | 6 +- .../wake/test/remote/TransportRaceTest.java | 22 +- .../reef/wake/test/remote/TransportTest.java | 25 +- .../org/apache/reef/wake/test/rx/RxTest.java | 12 +- .../wake/test/rx/RxThreadPoolStageTest.java | 30 +-- .../reef/wake/test/rx/TimeoutSubjectTest.java | 22 +- .../apache/reef/wake/test/time/ClockTest.java | 12 +- .../reef/wake/test/util/PassThroughEncoder.java | 2 +- .../reef/wake/test/util/TimeoutHandler.java | 4 +- .../webserver/HttpServerReefEventHandler.java | 2 +- .../reef/webserver/ReefEventStateManager.java | 2 +- .../reef/webserver/TestAvroHttpSerializer.java | 4 +- 380 files changed, 2907 insertions(+), 2876 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/LocalClient.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/LocalClient.java b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/LocalClient.java index 2d72965..0a508b4 100644 --- a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/LocalClient.java +++ b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/LocalClient.java @@ -117,11 +117,11 @@ public class LocalClient { } private static Configuration getRuntimeConfiguration( - int numberOfEvaluators, - String runtimeRootFolder, - int tcpBeginPort, - int tcpRangeCount, - int tcpTryCount) { + final int numberOfEvaluators, + final String runtimeRootFolder, + final int tcpBeginPort, + final int tcpRangeCount, + final int tcpTryCount) { final Configuration runtimeConfiguration = getRuntimeConfiguration(numberOfEvaluators, runtimeRootFolder); final Configuration userproviderConfiguration = Tang.Factory.getTang().newConfigurationBuilder() .bindSetEntry(DriverConfigurationProviders.class, TcpPortConfigurationProvider.class) @@ -132,7 +132,7 @@ public class LocalClient { return Configurations.merge(runtimeConfiguration, userproviderConfiguration); } - private static Configuration getRuntimeConfiguration(int numberOfEvaluators, String runtimeRootFolder) { + private static Configuration getRuntimeConfiguration(final int numberOfEvaluators, final String runtimeRootFolder) { return LocalRuntimeConfiguration.CONF .set(LocalRuntimeConfiguration.MAX_NUMBER_OF_EVALUATORS, Integer.toString(numberOfEvaluators)) .set(LocalRuntimeConfiguration.RUNTIME_ROOT_FOLDER, runtimeRootFolder) http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java index 7ab512d..bb47834 100644 --- a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java +++ b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java @@ -156,11 +156,13 @@ public final class YarnJobSubmissionClient { } } - private static Configuration getRuntimeConfiguration(int tcpBeginPort, int tcpRangeCount, int tcpTryCount) { - Configuration yarnClientConfig = YarnClientConfiguration.CONF + private static Configuration getRuntimeConfiguration(final int tcpBeginPort, + final int tcpRangeCount, + final int tcpTryCount) { + final Configuration yarnClientConfig = YarnClientConfiguration.CONF .build(); - Configuration providerConfig = Tang.Factory.getTang().newConfigurationBuilder() + final Configuration providerConfig = Tang.Factory.getTang().newConfigurationBuilder() .bindSetEntry(DriverConfigurationProviders.class, TcpPortConfigurationProvider.class) .bindNamedParameter(TcpPortRangeBegin.class, Integer.toString(tcpBeginPort)) .bindNamedParameter(TcpPortRangeCount.class, Integer.toString(tcpRangeCount)) http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/AllocatedEvaluatorBridge.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/AllocatedEvaluatorBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/AllocatedEvaluatorBridge.java index 8417d10..4a89e87 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/AllocatedEvaluatorBridge.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/AllocatedEvaluatorBridge.java @@ -52,8 +52,8 @@ public class AllocatedEvaluatorBridge extends NativeBridge { if (taskConfigurationString.isEmpty()) { throw new RuntimeException("empty taskConfigurationString provided."); } - Configuration contextConfiguration; - Configuration taskConfiguration; + final Configuration contextConfiguration; + final Configuration taskConfiguration; try { contextConfiguration = serializer.fromString(contextConfigurationString, clrClassHierarchy); taskConfiguration = serializer.fromString(taskConfigurationString, clrClassHierarchy); @@ -69,7 +69,7 @@ public class AllocatedEvaluatorBridge extends NativeBridge { if (contextConfigurationString.isEmpty()) { throw new RuntimeException("empty contextConfigurationString provided."); } - Configuration contextConfiguration; + final Configuration contextConfiguration; try { contextConfiguration = serializer.fromString(contextConfigurationString, clrClassHierarchy); } catch (final Exception e) { @@ -89,8 +89,8 @@ public class AllocatedEvaluatorBridge extends NativeBridge { throw new RuntimeException("empty serviceConfigurationString provided."); } - Configuration contextConfiguration; - Configuration servicetConfiguration; + final Configuration contextConfiguration; + final Configuration servicetConfiguration; try { contextConfiguration = serializer.fromString(contextConfigurationString, clrClassHierarchy); servicetConfiguration = serializer.fromString(serviceConfigurationString, clrClassHierarchy); @@ -115,9 +115,9 @@ public class AllocatedEvaluatorBridge extends NativeBridge { if (taskConfigurationString.isEmpty()) { throw new RuntimeException("empty taskConfigurationString provided."); } - Configuration contextConfiguration; - Configuration servicetConfiguration; - Configuration taskConfiguration; + final Configuration contextConfiguration; + final Configuration servicetConfiguration; + final Configuration taskConfiguration; try { contextConfiguration = serializer.fromString(contextConfigurationString, clrClassHierarchy); servicetConfiguration = serializer.fromString(serviceConfigurationString, clrClassHierarchy); @@ -132,7 +132,8 @@ public class AllocatedEvaluatorBridge extends NativeBridge { } public String getEvaluatorDescriptorSring() { - String descriptorString = Utilities.getEvaluatorDescriptorString(jallocatedEvaluator.getEvaluatorDescriptor()); + final String descriptorString = + Utilities.getEvaluatorDescriptorString(jallocatedEvaluator.getEvaluatorDescriptor()); LOG.log(Level.INFO, "allocated evaluator - serialized evaluator descriptor: " + descriptorString); return descriptorString; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/ClosedContextBridge.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/ClosedContextBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/ClosedContextBridge.java index 6aeaf53..5cd2b6d 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/ClosedContextBridge.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/ClosedContextBridge.java @@ -70,7 +70,7 @@ public class ClosedContextBridge extends NativeBridge implements ClosedContext { } public String getEvaluatorDescriptorSring() { - String descriptorString = Utilities.getEvaluatorDescriptorString(evaluatorDescriptor); + final String descriptorString = Utilities.getEvaluatorDescriptorString(evaluatorDescriptor); LOG.log(Level.INFO, "Closed Context - serialized evaluator descriptor: " + descriptorString); return descriptorString; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/CompletedEvaluatorBridge.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/CompletedEvaluatorBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/CompletedEvaluatorBridge.java index c13a213..79143f6 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/CompletedEvaluatorBridge.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/CompletedEvaluatorBridge.java @@ -27,7 +27,7 @@ public class CompletedEvaluatorBridge extends NativeBridge implements Identifiab private final String evaluatorId; - public CompletedEvaluatorBridge(CompletedEvaluator completedEvaluator) { + public CompletedEvaluatorBridge(final CompletedEvaluator completedEvaluator) { jcompletedEvaluator = completedEvaluator; evaluatorId = completedEvaluator.getId(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/ContextMessageBridge.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/ContextMessageBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/ContextMessageBridge.java index 61e2e9e..3ba9f2d 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/ContextMessageBridge.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/ContextMessageBridge.java @@ -27,7 +27,7 @@ public class ContextMessageBridge extends NativeBridge implements ContextMessage private String messageSourceId; private byte[] message; - public ContextMessageBridge(ContextMessage contextMessage) { + public ContextMessageBridge(final ContextMessage contextMessage) { jcontextMessage = contextMessage; contextMessageId = contextMessage.getId(); messageSourceId = contextMessage.getMessageSourceID(); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedContextBridge.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedContextBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedContextBridge.java index 331040a..3f0bfce 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedContextBridge.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedContextBridge.java @@ -79,7 +79,7 @@ public final class FailedContextBridge extends NativeBridge implements ContextBa } public String getEvaluatorDescriptorSring() { - String descriptorString = Utilities.getEvaluatorDescriptorString(evaluatorDescriptor); + final String descriptorString = Utilities.getEvaluatorDescriptorString(evaluatorDescriptor); LOG.log(Level.INFO, "Failed Context - serialized evaluator descriptor: " + descriptorString); return descriptorString; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedEvaluatorBridge.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedEvaluatorBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedEvaluatorBridge.java index 898f670..9447185 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedEvaluatorBridge.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedEvaluatorBridge.java @@ -30,8 +30,10 @@ public class FailedEvaluatorBridge extends NativeBridge { private EvaluatorRequestorBridge evaluatorRequestorBridge; private String evaluatorId; - public FailedEvaluatorBridge(FailedEvaluator failedEvaluator, EvaluatorRequestor evaluatorRequestor, - boolean blockedForAdditionalEvaluator, final LoggingScopeFactory loggingScopeFactory) { + public FailedEvaluatorBridge(final FailedEvaluator failedEvaluator, + final EvaluatorRequestor evaluatorRequestor, + final boolean blockedForAdditionalEvaluator, + final LoggingScopeFactory loggingScopeFactory) { jfailedEvaluator = failedEvaluator; evaluatorId = failedEvaluator.getId(); evaluatorRequestorBridge = http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/InteropLogger.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/InteropLogger.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/InteropLogger.java index 9f6a813..76df191 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/InteropLogger.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/InteropLogger.java @@ -41,9 +41,9 @@ public class InteropLogger { levelHashMap.put(Level.ALL.intValue(), Level.ALL); } - public void log(int intLevel, String message) { + public void log(final int intLevel, final String message) { if (levelHashMap.containsKey(intLevel)) { - Level level = levelHashMap.get(intLevel); + final Level level = levelHashMap.get(intLevel); LOG.log(level, message); } else { LOG.log(Level.WARNING, "Level " + intLevel + " is not a valid Log level"); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/InteropReturnInfo.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/InteropReturnInfo.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/InteropReturnInfo.java index a257473..3a27f3a 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/InteropReturnInfo.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/InteropReturnInfo.java @@ -25,7 +25,7 @@ public class InteropReturnInfo { int returnCode; ArrayList<String> exceptionList = new ArrayList<String>(); - public void addExceptionString(String exceptionString) { + public void addExceptionString(final String exceptionString) { exceptionList.add(exceptionString); } @@ -41,7 +41,7 @@ public class InteropReturnInfo { return returnCode; } - public void setReturnCode(int rc) { + public void setReturnCode(final int rc) { returnCode = rc; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/JavaBridge.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/JavaBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/JavaBridge.java index c047475..6957608 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/JavaBridge.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/JavaBridge.java @@ -24,7 +24,7 @@ public class JavaBridge { static { try { System.loadLibrary(CPP_BRIDGE); - } catch (UnsatisfiedLinkError e) { + } catch (final UnsatisfiedLinkError e) { // TODO[JIRA REEF-383] Document/Refactor JavaBridge } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/LibLoader.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/LibLoader.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/LibLoader.java index 8ea50ad..5ec69c4 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/LibLoader.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/LibLoader.java @@ -116,7 +116,7 @@ public final class LibLoader { private static void loadAllManagedDLLs(final File folder) { LOG.log(Level.INFO, "Loading all managed DLLs from {0}", folder.getAbsolutePath()); final File[] files = folder.listFiles(new FilenameFilter() { - public boolean accept(File dir, String name) { + public boolean accept(final File dir, final String name) { return name.toLowerCase().endsWith(DLL_EXTENSION); } }); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeBridge.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeBridge.java index f448707..beb2f74 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeBridge.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeBridge.java @@ -25,7 +25,7 @@ public abstract class NativeBridge implements AutoCloseable { private static final Logger LOG = Logger.getLogger(ActiveContextBridge.class.getName()); - public void onError(String errorMessage) { + public void onError(final String errorMessage) { LOG.log(Level.SEVERE, "Bridge received error from CLR: " + errorMessage); throw new RuntimeException("Bridge received error from CLR: " + errorMessage); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeInterop.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeInterop.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeInterop.java index 2c11b7d..56306d7 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeInterop.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeInterop.java @@ -62,101 +62,101 @@ public final class NativeInterop { public static final int N_HANDLERS = 17; - public static native void loadClrAssembly(String filePath); + public static native void loadClrAssembly(final String filePath); - public static native void clrBufferedLog(int level, String message); + public static native void clrBufferedLog(final int level, final String message); public static native long[] callClrSystemOnStartHandler( - String dateTime, - String httpServerPortNumber, - EvaluatorRequestorBridge javaEvaluatorRequestorBridge); + final String dateTime, + final String httpServerPortNumber, + final EvaluatorRequestorBridge javaEvaluatorRequestorBridge); public static native void clrSystemAllocatedEvaluatorHandlerOnNext( - long handle, - AllocatedEvaluatorBridge javaEvaluatorBridge, - InteropLogger interopLogger + final long handle, + final AllocatedEvaluatorBridge javaEvaluatorBridge, + final InteropLogger interopLogger ); public static native void clrSystemActiveContextHandlerOnNext( - long handle, - ActiveContextBridge javaActiveContextBridge, - InteropLogger interopLogger + final long handle, + final ActiveContextBridge javaActiveContextBridge, + final InteropLogger interopLogger ); public static native void clrSystemTaskMessageHandlerOnNext( - long handle, - byte[] mesage, - TaskMessageBridge javaTaskMessageBridge, - InteropLogger interopLogger + final long handle, + final byte[] mesage, + final TaskMessageBridge javaTaskMessageBridge, + final InteropLogger interopLogger ); public static native void clrSystemFailedTaskHandlerOnNext( - long handle, - FailedTaskBridge failedTaskBridge, - InteropLogger interopLogger + final long handle, + final FailedTaskBridge failedTaskBridge, + final InteropLogger interopLogger ); public static native void clrSystemHttpServerHandlerOnNext( - long handle, - HttpServerEventBridge httpServerEventBridge, - InteropLogger interopLogger + final long handle, + final HttpServerEventBridge httpServerEventBridge, + final InteropLogger interopLogger ); public static native void clrSystemFailedEvaluatorHandlerOnNext( - long handle, - FailedEvaluatorBridge failedEvaluatorBridge, - InteropLogger interopLogger + final long handle, + final FailedEvaluatorBridge failedEvaluatorBridge, + final InteropLogger interopLogger ); public static native void clrSystemCompletedTaskHandlerOnNext( - long handle, - CompletedTaskBridge completedTaskBridge, - InteropLogger interopLogger + final long handle, + final CompletedTaskBridge completedTaskBridge, + final InteropLogger interopLogger ); public static native void clrSystemRunningTaskHandlerOnNext( - long handle, - RunningTaskBridge runningTaskBridge, - InteropLogger interopLogger + final long handle, + final RunningTaskBridge runningTaskBridge, + final InteropLogger interopLogger ); public static native void clrSystemSuspendedTaskHandlerOnNext( - long handle, - SuspendedTaskBridge suspendedTaskBridge + final long handle, + final SuspendedTaskBridge suspendedTaskBridge ); public static native void clrSystemCompletedEvaluatorHandlerOnNext( - long handle, - CompletedEvaluatorBridge completedEvaluatorBridge + final long handle, + final CompletedEvaluatorBridge completedEvaluatorBridge ); public static native void clrSystemClosedContextHandlerOnNext( - long handle, - ClosedContextBridge closedContextBridge + final long handle, + final ClosedContextBridge closedContextBridge ); public static native void clrSystemFailedContextHandlerOnNext( - long handle, - FailedContextBridge failedContextBridge + final long handle, + final FailedContextBridge failedContextBridge ); public static native void clrSystemContextMessageHandlerOnNext( - long handle, - ContextMessageBridge contextMessageBridge + final long handle, + final ContextMessageBridge contextMessageBridge ); public static native void clrSystemDriverRestartHandlerOnNext( - long handle + final long handle ); public static native void clrSystemDriverRestartActiveContextHandlerOnNext( - long handle, - ActiveContextBridge activeContextBridge + final long handle, + final ActiveContextBridge activeContextBridge ); public static native void clrSystemDriverRestartRunningTaskHandlerOnNext( - long handle, - RunningTaskBridge runningTaskBridge + final long handle, + final RunningTaskBridge runningTaskBridge ); /** http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/TaskMessageBridge.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/TaskMessageBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/TaskMessageBridge.java index 256acf8..2c92e96 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/TaskMessageBridge.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/TaskMessageBridge.java @@ -25,7 +25,7 @@ public class TaskMessageBridge extends NativeBridge { private String taskId; // we don't really need to pass this around, just have this as place holder for future. - public TaskMessageBridge(TaskMessage taskMessage) { + public TaskMessageBridge(final TaskMessage taskMessage) { jtaskMessage = taskMessage; taskId = taskMessage.getId(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/Utilities.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/Utilities.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/Utilities.java index 2578cf2..1dd3802 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/Utilities.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/Utilities.java @@ -32,7 +32,7 @@ import java.nio.file.Path; import java.nio.file.Paths; public final class Utilities { - public static ClassHierarchy loadClassHierarchy(String classHierarchyFile) { + public static ClassHierarchy loadClassHierarchy(final String classHierarchyFile) { // TODO The file should be created via AvroClassHierarchySerializer Path p = Paths.get(classHierarchyFile); if (!Files.exists(p)) { @@ -52,8 +52,8 @@ public final class Utilities { } } - public static String getEvaluatorDescriptorString(EvaluatorDescriptor evaluatorDescriptor) { - InetSocketAddress socketAddress = evaluatorDescriptor.getNodeDescriptor().getInetSocketAddress(); + public static String getEvaluatorDescriptorString(final EvaluatorDescriptor evaluatorDescriptor) { + final InetSocketAddress socketAddress = evaluatorDescriptor.getNodeDescriptor().getInetSocketAddress(); return "IP=" + socketAddress.getAddress() + ", Port=" + socketAddress.getPort() + ", HostName=" + socketAddress.getHostName() + ", Memory=" + evaluatorDescriptor.getMemory() + ", Core=" + evaluatorDescriptor.getNumberOfCores(); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobClient.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobClient.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobClient.java index da80dff..ba0d46a 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobClient.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobClient.java @@ -131,11 +131,11 @@ public class JobClient { * @return the driver-side configuration to be merged into the DriverConfiguration to enable the HTTP server. */ public static Configuration getHTTPConfiguration() { - Configuration httpHandlerConfiguration = HttpHandlerConfiguration.CONF + final Configuration httpHandlerConfiguration = HttpHandlerConfiguration.CONF .set(HttpHandlerConfiguration.HTTP_HANDLERS, HttpServerReefEventHandler.class) .build(); - Configuration driverConfigurationForHttpServer = DriverServiceConfiguration.CONF + final Configuration driverConfigurationForHttpServer = DriverServiceConfiguration.CONF .set(DriverServiceConfiguration.ON_EVALUATOR_ALLOCATED, ReefEventStateManager.AllocatedEvaluatorStateHandler.class) .set(DriverServiceConfiguration.ON_CONTEXT_ACTIVE, ReefEventStateManager.ActiveContextStateHandler.class) @@ -166,7 +166,7 @@ public class JobClient { .set(DriverConfiguration.DRIVER_JOB_SUBMISSION_DIRECTORY, this.jobSubmissionDirectory); - Path globalLibFile = Paths.get(NativeInterop.GLOBAL_LIBRARIES_FILENAME); + final Path globalLibFile = Paths.get(NativeInterop.GLOBAL_LIBRARIES_FILENAME); if (!Files.exists(globalLibFile)) { LOG.log(Level.FINE, "Cannot find global classpath file at: {0}, assume there is none.", globalLibFile.toAbsolutePath()); @@ -179,7 +179,7 @@ public class JobClient { } for (final String s : globalLibString.split(",")) { - File f = new File(s); + final File f = new File(s); this.driverConfigModule = this.driverConfigModule.set(DriverConfiguration.GLOBAL_LIBRARIES, f.getPath()); } } @@ -204,7 +204,7 @@ public class JobClient { if (submitDriver) { this.reef.submit(this.driverConfiguration); } else { - File driverConfig = new File(System.getProperty("user.dir") + "/driver.config"); + final File driverConfig = new File(System.getProperty("user.dir") + "/driver.config"); try { new AvroConfigurationSerializer().toFile(Configurations.merge(this.driverConfiguration, clientConfig), driverConfig); @@ -256,7 +256,7 @@ public class JobClient { } else if (waitTime < 0) { waitTillDone(); } - long endTime = System.currentTimeMillis() + waitTime * 1000; + final long endTime = System.currentTimeMillis() + waitTime * 1000; close(endTime); } @@ -321,7 +321,7 @@ public class JobClient { final class WakeErrorHandler implements EventHandler<Throwable> { @Override - public void onNext(Throwable error) { + public void onNext(final Throwable error) { LOG.log(Level.SEVERE, "Error communicating with job driver, exiting... ", error); stopAndNotify(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java index 35dab6d..e4c6860 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java @@ -178,7 +178,7 @@ public final class JobDriver { try { libLoader.loadLib(); - } catch (IOException e) { + } catch (final IOException e) { throw new RuntimeException("Fail to load CLR libraries"); } @@ -191,10 +191,10 @@ public final class JobDriver { } LOG.log(Level.INFO, "StartTime: {0}", new Object[]{startTime}); - String portNumber = httpServer == null ? null : Integer.toString((httpServer.getPort())); - EvaluatorRequestorBridge evaluatorRequestorBridge = + final String portNumber = httpServer == null ? null : Integer.toString((httpServer.getPort())); + final EvaluatorRequestorBridge evaluatorRequestorBridge = new EvaluatorRequestorBridge(JobDriver.this.evaluatorRequestor, false, loggingScopeFactory); - long[] handlers = + final long[] handlers = NativeInterop.callClrSystemOnStartHandler(startTime.toString(), portNumber, evaluatorRequestorBridge); if (handlers != null) { if (handlers.length != NativeInterop.N_HANDLERS) { @@ -245,7 +245,7 @@ public final class JobDriver { } private CLRBufferedLogHandler getCLRBufferedLogHandler() { - for (Handler handler : Logger.getLogger("").getHandlers()) { + for (final Handler handler : Logger.getLogger("").getHandlers()) { if (handler instanceof CLRBufferedLogHandler) { return (CLRBufferedLogHandler) handler; } @@ -261,7 +261,7 @@ public final class JobDriver { if (JobDriver.this.allocatedEvaluatorHandler == 0) { throw new RuntimeException("Allocated Evaluator Handler not initialized by CLR."); } - AllocatedEvaluatorBridge allocatedEvaluatorBridge = + final AllocatedEvaluatorBridge allocatedEvaluatorBridge = new AllocatedEvaluatorBridge(eval, JobDriver.this.nameServerInfo); NativeInterop.clrSystemAllocatedEvaluatorHandlerOnNext(JobDriver.this.allocatedEvaluatorHandler, allocatedEvaluatorBridge, this.interopLogger); @@ -277,7 +277,7 @@ public final class JobDriver { if (JobDriver.this.activeContextHandler == 0) { throw new RuntimeException("Active Context Handler not initialized by CLR."); } - ActiveContextBridge activeContextBridge = activeContextBridgeFactory.getActiveContextBridge(context); + final ActiveContextBridge activeContextBridge = activeContextBridgeFactory.getActiveContextBridge(context); NativeInterop.clrSystemActiveContextHandlerOnNext(JobDriver.this.activeContextHandler, activeContextBridge, JobDriver.this.interopLogger); } catch (final Exception ex) { @@ -340,7 +340,7 @@ public final class JobDriver { LOG.log(Level.INFO, "No CLR handler bound to handle completed task."); } else { LOG.log(Level.INFO, "CLR CompletedTaskHandler handler set, handling things with CLR handler."); - CompletedTaskBridge completedTaskBridge = new CompletedTaskBridge(task, activeContextBridgeFactory); + final CompletedTaskBridge completedTaskBridge = new CompletedTaskBridge(task, activeContextBridgeFactory); NativeInterop.clrSystemCompletedTaskHandlerOnNext(JobDriver.this.completedTaskHandler, completedTaskBridge, JobDriver.this.interopLogger); } @@ -358,7 +358,7 @@ public final class JobDriver { synchronized (JobDriver.this) { LOG.log(Level.SEVERE, "FailedEvaluator", eval); for (final FailedContext failedContext : eval.getFailedContextList()) { - String failedContextId = failedContext.getId(); + final String failedContextId = failedContext.getId(); LOG.log(Level.INFO, "removing context " + failedContextId + " from job driver contexts."); JobDriver.this.contexts.remove(failedContextId); } @@ -399,7 +399,7 @@ public final class JobDriver { JobDriver.this.isRestarted, loggingScopeFactory); NativeInterop.clrSystemFailedEvaluatorHandlerOnNext(JobDriver.this.failedEvaluatorHandler, failedEvaluatorBridge, JobDriver.this.interopLogger); - int additionalRequestedEvaluatorNumber = failedEvaluatorBridge.getNewlyRequestedEvaluatorNumber(); + final int additionalRequestedEvaluatorNumber = failedEvaluatorBridge.getNewlyRequestedEvaluatorNumber(); if (additionalRequestedEvaluatorNumber > 0) { LOG.log(Level.INFO, "number of additional evaluators requested after evaluator failure: " + additionalRequestedEvaluatorNumber); @@ -419,7 +419,7 @@ public final class JobDriver { return uriSpecification; } - public void setUriSpecification(String s) { + public void setUriSpecification(final String s) { uriSpecification = s; } @@ -465,7 +465,7 @@ public final class JobDriver { throw new RuntimeException("Failed Task Handler not initialized by CLR."); } try { - FailedTaskBridge failedTaskBridge = new FailedTaskBridge(task, activeContextBridgeFactory); + final FailedTaskBridge failedTaskBridge = new FailedTaskBridge(task, activeContextBridgeFactory); NativeInterop.clrSystemFailedTaskHandlerOnNext(JobDriver.this.failedTaskHandler, failedTaskBridge, JobDriver.this.interopLogger); } catch (final Exception ex) { @@ -637,11 +637,11 @@ public final class JobDriver { public final class TaskMessageHandler implements EventHandler<TaskMessage> { @Override public void onNext(final TaskMessage taskMessage) { - String msg = new String(taskMessage.get()); + final String msg = new String(taskMessage.get()); LOG.log(Level.INFO, "Received TaskMessage: {0} from CLR", msg); //try (LoggingScope ls = loggingScopeFactory.taskMessageReceived(new String(msg))) { if (JobDriver.this.taskMessageHandler != 0) { - TaskMessageBridge taskMessageBridge = new TaskMessageBridge(taskMessage); + final TaskMessageBridge taskMessageBridge = new TaskMessageBridge(taskMessage); // if CLR implements the task message handler, handle the bytes in CLR handler NativeInterop.clrSystemTaskMessageHandlerOnNext(JobDriver.this.taskMessageHandler, taskMessage.get(), taskMessageBridge, JobDriver.this.interopLogger); @@ -660,7 +660,7 @@ public final class JobDriver { LOG.log(Level.INFO, message); try (final LoggingScope ls = loggingScopeFactory.taskSuspended(task.getId())) { if (JobDriver.this.suspendedTaskHandler != 0) { - SuspendedTaskBridge suspendedTaskBridge = new SuspendedTaskBridge(task, activeContextBridgeFactory); + final SuspendedTaskBridge suspendedTaskBridge = new SuspendedTaskBridge(task, activeContextBridgeFactory); // if CLR implements the suspended task handler, handle it in CLR LOG.log(Level.INFO, "Handling the event of suspended task in CLR bridge."); NativeInterop.clrSystemSuspendedTaskHandlerOnNext(JobDriver.this.suspendedTaskHandler, suspendedTaskBridge); @@ -679,7 +679,7 @@ public final class JobDriver { LOG.log(Level.INFO, " Completed Evaluator {0}", evaluator.getId()); try (final LoggingScope ls = loggingScopeFactory.evaluatorCompleted(evaluator.getId())) { if (JobDriver.this.completedEvaluatorHandler != 0) { - CompletedEvaluatorBridge completedEvaluatorBridge = new CompletedEvaluatorBridge(evaluator); + final CompletedEvaluatorBridge completedEvaluatorBridge = new CompletedEvaluatorBridge(evaluator); // if CLR implements the completed evaluator handler, handle it in CLR LOG.log(Level.INFO, "Handling the event of completed evaluator in CLR bridge."); NativeInterop.clrSystemCompletedEvaluatorHandlerOnNext(completedEvaluatorHandler, completedEvaluatorBridge); @@ -699,7 +699,7 @@ public final class JobDriver { LOG.log(Level.INFO, "Completed Context: {0}", context.getId()); try (final LoggingScope ls = loggingScopeFactory.closedContext(context.getId())) { if (JobDriver.this.closedContextHandler != 0) { - ClosedContextBridge closedContextBridge = new ClosedContextBridge(context, activeContextBridgeFactory); + final ClosedContextBridge closedContextBridge = new ClosedContextBridge(context, activeContextBridgeFactory); // if CLR implements the closed context handler, handle it in CLR LOG.log(Level.INFO, "Handling the event of closed context in CLR bridge."); NativeInterop.clrSystemClosedContextHandlerOnNext(JobDriver.this.closedContextHandler, closedContextBridge); @@ -722,7 +722,7 @@ public final class JobDriver { LOG.log(Level.SEVERE, "FailedContext", context); try (final LoggingScope ls = loggingScopeFactory.evaluatorFailed(context.getId())) { if (JobDriver.this.failedContextHandler != 0) { - FailedContextBridge failedContextBridge = new FailedContextBridge(context, activeContextBridgeFactory); + final FailedContextBridge failedContextBridge = new FailedContextBridge(context, activeContextBridgeFactory); // if CLR implements the failed context handler, handle it in CLR LOG.log(Level.INFO, "Handling the event of failed context in CLR bridge."); NativeInterop.clrSystemFailedContextHandlerOnNext(JobDriver.this.failedContextHandler, failedContextBridge); @@ -730,7 +730,7 @@ public final class JobDriver { synchronized (JobDriver.this) { JobDriver.this.contexts.remove(context.getId()); } - Optional<byte[]> err = context.getData(); + final Optional<byte[]> err = context.getData(); if (err.isPresent()) { JobDriver.this.jobMessageObserver.sendMessageToClient(err.get()); } @@ -747,7 +747,7 @@ public final class JobDriver { LOG.log(Level.SEVERE, "Received ContextMessage:", message.get()); try (final LoggingScope ls = loggingScopeFactory.contextMessageReceived(message.get().toString())) { if (JobDriver.this.contextMessageHandler != 0) { - ContextMessageBridge contextMessageBridge = new ContextMessageBridge(message); + final ContextMessageBridge contextMessageBridge = new ContextMessageBridge(message); // if CLR implements the context message handler, handle it in CLR LOG.log(Level.INFO, "Handling the event of context message in CLR bridge."); NativeInterop.clrSystemContextMessageHandlerOnNext(JobDriver.this.contextMessageHandler, http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/Launch.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/Launch.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/Launch.java index 8cc3c84..4392758 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/Launch.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/Launch.java @@ -147,7 +147,7 @@ public final class Launch { throw new IllegalArgumentException("No arguments provided, at least a clrFolder should be supplied."); } final File dotNetFolder = new File(args[0]).getAbsoluteFile(); - String[] removedArgs = Arrays.copyOfRange(args, 1, args.length); + final String[] removedArgs = Arrays.copyOfRange(args, 1, args.length); final Configuration config = getClientConfiguration(removedArgs); final Injector commandLineInjector = Tang.Factory.getTang().newInjector(parseCommandLine(removedArgs)); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/LaunchHeadless.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/LaunchHeadless.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/LaunchHeadless.java index ef3fc15..18abc1a 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/LaunchHeadless.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/LaunchHeadless.java @@ -83,7 +83,7 @@ public final class LaunchHeadless { } driverConfigModule = result; - Configuration driverConfiguration = + final Configuration driverConfiguration = Configurations.merge(driverConfigModule.build(), JobClient.getHTTPConfiguration()); LOG.log(Level.INFO, "Running on YARN"); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/util/logging/CLRBufferedLogHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/util/logging/CLRBufferedLogHandler.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/util/logging/CLRBufferedLogHandler.java index 26e91d2..abbb8ec 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/util/logging/CLRBufferedLogHandler.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/util/logging/CLRBufferedLogHandler.java @@ -73,7 +73,7 @@ public class CLRBufferedLogHandler extends Handler { * the driver has already been initialized, flush the buffer of the logs. */ @Override - public void publish(LogRecord record) { + public void publish(final LogRecord record) { if (record == null) { return; } @@ -154,7 +154,7 @@ public class CLRBufferedLogHandler extends Handler { * Returns the integer value of the log record's level to be used * by the CLR Bridge log function. */ - private int getLevel(Level recordLevel) { + private int getLevel(final Level recordLevel) { if (recordLevel.equals(Level.OFF)) { return 0; } else if (recordLevel.equals(Level.SEVERE)) { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/fs/FSCheckpointID.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/fs/FSCheckpointID.java b/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/fs/FSCheckpointID.java index a5a018d..f43cc67 100644 --- a/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/fs/FSCheckpointID.java +++ b/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/fs/FSCheckpointID.java @@ -37,7 +37,7 @@ public class FSCheckpointID implements CheckpointID { public FSCheckpointID() { } - public FSCheckpointID(Path path) { + public FSCheckpointID(final Path path) { this.path = path; } @@ -51,17 +51,17 @@ public class FSCheckpointID implements CheckpointID { } @Override - public void write(DataOutput out) throws IOException { + public void write(final DataOutput out) throws IOException { Text.writeString(out, path.toString()); } @Override - public void readFields(DataInput in) throws IOException { + public void readFields(final DataInput in) throws IOException { this.path = new Path(Text.readString(in)); } @Override - public boolean equals(Object other) { + public boolean equals(final Object other) { return other instanceof FSCheckpointID && path.equals(((FSCheckpointID) other).path); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/fs/FSCheckpointService.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/fs/FSCheckpointService.java b/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/fs/FSCheckpointService.java index 15e2ee5..369fb16 100644 --- a/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/fs/FSCheckpointService.java +++ b/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/fs/FSCheckpointService.java @@ -84,7 +84,7 @@ public class FSCheckpointService implements CheckpointService { return createInternal(new Path(base, p)); } - CheckpointWriteChannel createInternal(Path name) throws IOException { + CheckpointWriteChannel createInternal(final Path name) throws IOException { //create a temp file, fail if file exists return new FSCheckpointWriteChannel(name, fs.create(tmpfile(name), replication)); @@ -129,7 +129,7 @@ public class FSCheckpointService implements CheckpointService { if (!fs.delete(tmp, false)) { throw new IOException("Failed to delete checkpoint during abort"); } - } catch (FileNotFoundException e) { + } catch (final FileNotFoundException e) { // IGNORE } } @@ -141,10 +141,10 @@ public class FSCheckpointService implements CheckpointService { throw new IllegalArgumentException( "Mismatched checkpoint type: " + id.getClass()); } - Path tmp = ((FSCheckpointID) id).getPath(); + final Path tmp = ((FSCheckpointID) id).getPath(); try { return fs.delete(tmp, false); - } catch (FileNotFoundException e) { + } catch (final FileNotFoundException e) { // IGNORE } return true; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/io/WorkingDirectoryTempFileCreator.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/WorkingDirectoryTempFileCreator.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/WorkingDirectoryTempFileCreator.java index c51dfc6..9367a39 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/io/WorkingDirectoryTempFileCreator.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/WorkingDirectoryTempFileCreator.java @@ -67,7 +67,7 @@ public final class WorkingDirectoryTempFileCreator implements TempFileCreator { } @Override - public File createTempDirectory(String prefix) throws IOException { + public File createTempDirectory(final String prefix) throws IOException { final File result = Files.createTempDirectory(this.tempFolderAsPath, prefix).toFile(); if (LOG.isLoggable(Level.FINEST)) { LOG.log(Level.FINEST, "Created temporary folder: {0}", result.getAbsolutePath()); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/REEFLauncher.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/REEFLauncher.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/REEFLauncher.java index d818513..41214b4 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/REEFLauncher.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/REEFLauncher.java @@ -92,7 +92,7 @@ public final class REEFLauncher { private static REEFLauncher getREEFLauncher(final String clockConfigPath) { final Injector injector; try { - Configuration clockArgConfig = Tang.Factory.getTang().newConfigurationBuilder() + final Configuration clockArgConfig = Tang.Factory.getTang().newConfigurationBuilder() .bindNamedParameter(ClockConfigurationPath.class, clockConfigPath).build(); injector = Tang.Factory.getTang().newInjector(clockArgConfig); } catch (final BindException e) { @@ -101,7 +101,7 @@ public final class REEFLauncher { try { return injector.getInstance(REEFLauncher.class); - } catch (InjectionException e) { + } catch (final InjectionException e) { throw fatal("Unable to run REEFLauncher.", e); } } @@ -171,7 +171,7 @@ public final class REEFLauncher { } catch (final Throwable ex) { try (final REEFErrorHandler errorHandler = launcher.getErrorHandlerFromConfig()) { throw fatal(errorHandler, "Unable to instantiate the clock", ex); - } catch (InjectionException e) { + } catch (final InjectionException e) { throw fatal("Unable to instantiate the clock and the ErrorHandler", e); } } @@ -239,7 +239,7 @@ public final class REEFLauncher { private Clock getClockFromConfig() throws InjectionException { final Injector clockInjector = Tang.Factory.getTang().newInjector(this.clockConfig); if (this.isProfilingEnabled) { - WakeProfiler profiler = new WakeProfiler(); + final WakeProfiler profiler = new WakeProfiler(); ProfilingStopHandler.setProfiler(profiler); clockInjector.bindAspect(profiler); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobStatusMessageHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobStatusMessageHandler.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobStatusMessageHandler.java index 3496812..47a5baa 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobStatusMessageHandler.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobStatusMessageHandler.java @@ -44,7 +44,7 @@ final class JobStatusMessageHandler implements EventHandler<RemoteMessage<ReefSe } @Override - public void onNext(RemoteMessage<ReefServiceProtos.JobStatusProto> jobStatusProtoRemoteMessage) { + public void onNext(final RemoteMessage<ReefServiceProtos.JobStatusProto> jobStatusProtoRemoteMessage) { this.runningJobs.onJobStatusMessage(jobStatusProtoRemoteMessage); } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobsImpl.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobsImpl.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobsImpl.java index 0fea008..fd89e98 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobsImpl.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobsImpl.java @@ -89,7 +89,8 @@ final class RunningJobsImpl implements RunningJobs { } @Override - public synchronized void onRuntimeErrorMessage(RemoteMessage<ReefServiceProtos.RuntimeErrorProto> runtimeFailure) { + public synchronized void onRuntimeErrorMessage( + final RemoteMessage<ReefServiceProtos.RuntimeErrorProto> runtimeFailure) { try { this.remove(runtimeFailure.getMessage().getIdentifier()); } finally { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/NodeDescriptorHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/NodeDescriptorHandler.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/NodeDescriptorHandler.java index 42b0ff6..2435806 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/NodeDescriptorHandler.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/NodeDescriptorHandler.java @@ -34,7 +34,7 @@ public final class NodeDescriptorHandler implements EventHandler<NodeDescriptorE private final ResourceCatalogImpl resourceCatalog; @Inject - public NodeDescriptorHandler(ResourceCatalogImpl resourceCatalog) { + public NodeDescriptorHandler(final ResourceCatalogImpl resourceCatalog) { this.resourceCatalog = resourceCatalog; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/ResourceManagerStatus.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/ResourceManagerStatus.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/ResourceManagerStatus.java index a04ade5..500509a 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/ResourceManagerStatus.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/ResourceManagerStatus.java @@ -145,7 +145,7 @@ public final class ResourceManagerStatus implements EventHandler<RuntimeStatusEv } - private synchronized void setState(ReefServiceProtos.State state) { + private synchronized void setState(final ReefServiceProtos.State state) { // TODO: Add state transition check this.state = state; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/ResourceStatusHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/ResourceStatusHandler.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/ResourceStatusHandler.java index c661d7b..70a3cce 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/ResourceStatusHandler.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/ResourceStatusHandler.java @@ -57,7 +57,7 @@ public final class ResourceStatusHandler implements EventHandler<ResourceStatusE evaluatorManager.get().onResourceStatusMessage(resourceStatusEvent); } else { if (resourceStatusEvent.getIsFromPreviousDriver().get()) { - EvaluatorManager previousEvaluatorManager = + final EvaluatorManager previousEvaluatorManager = this.evaluatorManagerFactory.createForEvaluatorFailedDuringDriverRestart(resourceStatusEvent); previousEvaluatorManager.onResourceStatusMessage(resourceStatusEvent); } else { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorRuntime.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorRuntime.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorRuntime.java index 1f6974f..ec4b6db 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorRuntime.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorRuntime.java @@ -159,7 +159,7 @@ final class EvaluatorRuntime implements EventHandler<EvaluatorControlProto> { } @Override - public void onNext(EvaluatorControlProto evaluatorControlProto) { + public void onNext(final EvaluatorControlProto evaluatorControlProto) { this.onEvaluatorControlMessage(evaluatorControlProto); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/CLRLaunchCommandBuilder.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/CLRLaunchCommandBuilder.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/CLRLaunchCommandBuilder.java index 0b7899d..0ffc559 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/CLRLaunchCommandBuilder.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/CLRLaunchCommandBuilder.java @@ -42,7 +42,7 @@ public class CLRLaunchCommandBuilder implements LaunchCommandBuilder { @Override public List<String> build() { final List<String> result = new LinkedList<>(); - File f = new File(EVALUATOR_PATH); + final File f = new File(EVALUATOR_PATH); if (!f.exists()) { LOG.log(Level.WARNING, "file can NOT be found: {0}", f.getAbsolutePath()); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/util/EnvironmentUtils.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/EnvironmentUtils.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/EnvironmentUtils.java index 2ff1c5e..e496a19 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/util/EnvironmentUtils.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/EnvironmentUtils.java @@ -107,11 +107,12 @@ public final class EnvironmentUtils { */ @Deprecated public static <P extends Param> ConfigurationModule addAll( - ConfigurationModule config, final P param, final Iterable<String> values) { + final ConfigurationModule config, final P param, final Iterable<String> values) { + ConfigurationModule conf = config; for (final String val : values) { - config = config.set(param, val); + conf = conf.set(param, val); } - return config; + return conf; } /** http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/util/REEFVersion.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/REEFVersion.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/REEFVersion.java index 817eda8..46942fd 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/util/REEFVersion.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/REEFVersion.java @@ -75,7 +75,7 @@ public final class REEFVersion { final Properties properties = new Properties(); properties.load(is); version = properties.getProperty(VERSION_KEY, VERSION_DEFAULT); - } catch (IOException e) { + } catch (final IOException e) { LOG.log(Level.WARNING, "Could not find REEF version"); version = VERSION_DEFAULT; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LogParser.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LogParser.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LogParser.java index 8192a10..b49922b 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LogParser.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LogParser.java @@ -122,7 +122,7 @@ public final class LogParser { */ public static ArrayList<String> filter(final ArrayList<String> original, final String filter, final String token) { final ArrayList<String> result = new ArrayList<String>(); - for (String line : original) { + for (final String line : original) { if (line.contains(filter)) { final String[] p = line.split(token); if (p.length > 1) { @@ -140,10 +140,10 @@ public final class LogParser { * @return */ public static ArrayList<String> findStages(final ArrayList<String> lines, final String[] stageIndicators) { - ArrayList<String> stages = new ArrayList<String>(); + final ArrayList<String> stages = new ArrayList<String>(); int i = 0; - for (String line: lines) { + for (final String line: lines) { if (line.contains(stageIndicators[i])){ stages.add(stageIndicators[i]); if (i < stageIndicators.length - 1) { @@ -154,10 +154,10 @@ public final class LogParser { return stages; } - public static ArrayList<String> mergeStages(ArrayList<String> startStages, ArrayList<String> endStages) { - ArrayList<String> mergeStage = new ArrayList<String>(); + public static ArrayList<String> mergeStages(final ArrayList<String> startStages, final ArrayList<String> endStages) { + final ArrayList<String> mergeStage = new ArrayList<String>(); for (int i = 0; i < startStages.size(); i++) { - String end = startStages.get(i).replace(LoggingScopeImpl.START_PREFIX, LoggingScopeImpl.EXIT_PREFIX); + final String end = startStages.get(i).replace(LoggingScopeImpl.START_PREFIX, LoggingScopeImpl.EXIT_PREFIX); if (endStages.contains(end)) { mergeStage.add(startStages.get(i) + " " + end); } else { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/resources/checkstyle.xml ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/resources/checkstyle.xml b/lang/java/reef-common/src/main/resources/checkstyle.xml index 17f4534..1ab4b3e 100644 --- a/lang/java/reef-common/src/main/resources/checkstyle.xml +++ b/lang/java/reef-common/src/main/resources/checkstyle.xml @@ -184,6 +184,7 @@ <module name="MissingSwitchDefault"/> <module name="SimplifyBooleanExpression"/> <module name="SimplifyBooleanReturn"/> + <module name="FinalParameters"/> <!-- Checks for class design --> <!-- See http://checkstyle.sf.net/config_design.html -->
