TheR1sing3un commented on code in PR #6100:
URL: https://github.com/apache/rocketmq/pull/6100#discussion_r1113844700
##########
broker/src/main/java/org/apache/rocketmq/broker/controller/ReplicasManager.java:
##########
@@ -108,10 +124,23 @@ public long getConfirmOffset() {
enum State {
INITIAL,
FIRST_TIME_SYNC_CONTROLLER_METADATA_DONE,
+
+ FIRST_TIME_REGISTER_TO_CONTROLLER_DONE,
+
RUNNING,
SHUTDOWN,
}
Review Comment:
> Could the enum name be changed to make it more semantically expressive
Yep! I think rename it to `REGISTER_TO_CONTROLLER_DONE` will be more
expressive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
