TheR1sing3un commented on code in PR #6100:
URL: https://github.com/apache/rocketmq/pull/6100#discussion_r1113845982
##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/header/namesrv/BrokerHeartbeatRequestHeader.java:
##########
@@ -29,7 +29,7 @@ public class BrokerHeartbeatRequestHeader implements
CommandCustomHeader {
private String brokerAddr;
@CFNotNull
private String brokerName;
- @CFNullable
+ @CFNotNull
Review Comment:
>
BrokerHeartbeatRequestHeader在controller中被用到，在Broker发给nameserver的轻量级心跳中也被用到（详见[RIP-32](https://github.com/apache/rocketmq/wiki/RIP-32-Slave-Acting-Master-Mode)），为了保持兼容性，建议仍然是CFNullable，在controller处对没有brokerId的进行拦截（提醒用户升级）
done~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
