TheR1sing3un commented on code in PR #6100:
URL: https://github.com/apache/rocketmq/pull/6100#discussion_r1113846632


##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RequestCode.java:
##########
@@ -275,5 +275,11 @@ public class RequestCode {
      */
     public static final int CLEAN_BROKER_DATA = 1011;
 
+    public static final int GET_NEXT_BROKER_ID = 1012;
+
+    public static final int APPLY_BROKER_ID = 1013;
+
+    public static final int REGISTER_SUCCESS = 1014;

Review Comment:
   > 1.建议RequestCode前都增加一个CONTROLLER_的前缀
   > 
   > 2.REGISTER_SUCCESS能不能不新增,用之前的CONTROLLER_REGISTER_BROKER
   
   1. done~
   2. I will reuse `CONTROLLER_REGISTER_BROKER` as request code!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to