[GitHub] [rocketmq] superhx commented on a diff in pull request #6606: optimized tips when sending large size message

Mon, 17 Apr 2023 18:17:41 -0700 


superhx commented on code in PR #6606:
URL: https://github.com/apache/rocketmq/pull/6606#discussion_r1169395437


##########
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java:
##########
@@ -534,6 +535,13 @@ public void executeAsyncMessageSend(Runnable runnable, 
final Message msg, final
         boolean isSemaphoreAsyncNumAquired = false;
         boolean isSemaphoreAsyncSizeAquired = false;
         int msgLen = msg.getBody() == null ? 1 : msg.getBody().length;
+        if (msgLen > 
this.getDefaultMQProducer().getBackPressureForAsyncSendSize()) {

Review Comment:
   
![image](https://user-images.githubusercontent.com/5719209/232643791-4089b569-9797-40a2-972c-0e667685e055.png)
   
   Inflight messages sum size is large than backPressureForAsyncSendSize 
doesn't mean MESSAGE_ILLEGAL.
   
   MESSAGE_ILLEGAL is usually used when serialized Message size large than 
maxMessageSize or serialized Message properties size large than 65536 or other 
Message property conflict condition.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to