dugenkui03 commented on code in PR #6606:
URL: https://github.com/apache/rocketmq/pull/6606#discussion_r1174385957
##########
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java:
##########
@@ -534,6 +535,13 @@ public void executeAsyncMessageSend(Runnable runnable,
final Message msg, final
boolean isSemaphoreAsyncNumAquired = false;
boolean isSemaphoreAsyncSizeAquired = false;
int msgLen = msg.getBody() == null ? 1 : msg.getBody().length;
+ if (msgLen >
this.getDefaultMQProducer().getBackPressureForAsyncSendSize()) {
Review Comment:
原来的消息`send message tryAcquire semaphoreAsyncSize timeout`并没有说明获取` tryAcquire
semaphoreAsyncSize`的确切原因、重试是否有可能成功 或 总是失败,失败时重试则毫无意义。
PR异常消息 1. 标识消息不合法所以发送终是失败 2. 给出了 最大消息阈值(backPressureForAsyncSendSize一定程度上承担了
maxMessageSize 的作用
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]