superhx commented on code in PR #6606:
URL: https://github.com/apache/rocketmq/pull/6606#discussion_r1170723615
##########
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java:
##########
@@ -534,6 +535,13 @@ public void executeAsyncMessageSend(Runnable runnable,
final Message msg, final
boolean isSemaphoreAsyncNumAquired = false;
boolean isSemaphoreAsyncSizeAquired = false;
int msgLen = msg.getBody() == null ? 1 : msg.getBody().length;
+ if (msgLen >
this.getDefaultMQProducer().getBackPressureForAsyncSendSize()) {
Review Comment:
I think origin checks is correct:
- when inflight messages buffer is larger than backPressureForAsyncSendSize,
it suggests client send too fast than broker can take , client should fast
return RemotingTooMuchRequestException.
- when single message serialized size is larger than maxMessageSize, client
should return MESSAGE_ILLEGAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
