zjncs opened a new pull request, #5689:
URL: https://github.com/apache/rocketmq-dashboard/pull/5689

   ### Problem
   
   `ConsumerGroupUpdateToolHandler` — the `rmq.group.update` mutation tool — 
had **no test**.
   
   ### Change
   
   Add `ConsumerGroupUpdateToolHandlerTest` with seven tests:
   
   | Contract | Pinned behaviour |
   | --- | --- |
   | upsert | execute on an **absent** group takes the create path; execute on 
an existing group takes the update path with a **sparse merge** — a one-field 
input (`retryMaxTimes`) updates that field and leaves subscription mode, 
consume type, subscription data type, delivery order type and name untouched 
(captured on the argument handed to `updateConsumerGroup`) |
   | instance stamp | the persisted row **carries the context's instance** even 
on the create path with a null input instanceId — without the stamp the row 
would be written without an owner |
   | preview | an absent group has no before state; an **identical** 
configuration warns; a sparse input merges onto the current state with 
untouched fields keeping the **current** values in the after state, not 
defaults |
   | identity | the tool name and input type round-trip |
   
   ### Verification
   
   - New tests: **7/7 green** against unmodified code.
   - Discriminating mutations on the handler (build result verified): the 
absent-group create path dropped (**red**); the context-instance stamp dropped 
(**red**); the identical-config warning dropped (**red**); the execute merge 
replaced with the input-only configuration (**red**).
   - Restored: 7/7 green. No product code changed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to