zjncs opened a new pull request, #5681: URL: https://github.com/apache/rocketmq-dashboard/pull/5681
### Problem `GroupDetailToolHandler` — the `rmq.group.detail` tool, a pure composition of `MetadataService` reads (decision 11) — had **no test**. ### Change Add `GroupDetailToolHandlerTest` with nine tests: - the handler composes the runtime view, subscriptions, configurations and progress into the aggregated output under the context's instance id and the input's group name; - **the health classifier, one branch at a time**: | State | Classification | | --- | --- | | broker consume statistics unavailable | `UNKNOWN` | | connection inventory unavailable (`onlineInstances < 0`), even with lag | `UNKNOWN` — the answer is unknown rather than bad | | accumulated messages **with no online consumer** | `UNHEALTHY` — the one truly bad state | | no online consumer, no lag | `WARNING` | | online consumers, accumulated messages | `WARNING` | | online consumers, no lag | `HEALTHY` with an empty reasons list | - the `topicName` filter is forwarded **verbatim**: a two-topic progress list filtered to the requested topic keeps exactly that queue; - the tool name and input type round-trip. ### Verification - New tests: **9/9 green** against unmodified code. - Discriminating mutations on the handler (build result verified): stats-unavailable branch dropped (**red**); the UNHEALTHY demotion (**red**); the connection-inventory branch dropped (**red**); the lag-warning dropped (**red**); the topic filter replaced with null (**red after strengthening** — a first draft asserted only the group name and let the null-filter mutation through, so the pin was strengthened until the mutation redden). - Restored: 9/9 green. No product code changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
