zjncs opened a new pull request, #5692:
URL: https://github.com/apache/rocketmq-dashboard/pull/5692

   ### Problem
   
   `UserDeleteToolHandler` — the `rmq.user.delete` mutation tool — had **no 
test**.
   
   ### Change
   
   Add `UserDeleteToolHandlerTest` with four tests:
   
   | Contract | Pinned behaviour |
   | --- | --- |
   | execute | deletes the user by id **under the context's instance** — the 
two-argument `deleteUser(id, instanceId)`, never with the arguments flipped 
(`AclService` takes the id first, unlike several sibling services that take the 
instance first) |
   | preview | fetches the user through `getUser(id, instanceId)` with the same 
argument order and shows it as the before diff — the numeric user id renders as 
its string form, the username and clusters survive — with **no after state** |
   | plan impact | the impact lines carry the generated-credentials deletion 
consequence |
   | identity | the tool name and input type round-trip |
   
   ### Verification
   
   - New tests: **4/4 green** against unmodified code.
   - Discriminating mutations (build result verified): the delete arguments 
flipped (**red**); the preview fetch arguments flipped (**red**); the before 
diff dropped (**red**).
   - Restored: 4/4 green. No product code changed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to