zjncs opened a new pull request, #5834:
URL: https://github.com/apache/rocketmq-dashboard/pull/5834

   ### What
   
   `GeneralSettingsUpdateDTO` carries a general-settings update. It had no 
test. This adds 4 tests.
   
   ### What is pinned
   
   - **`toSettings()` maps every field**;
   - **the Lombok-generated `toString` never exposes the API key or the 
DingTalk signing secret** (`@ToString.Exclude`);
   - the **session timeout is bounded between 5 and 1440 minutes**;
   - the nine core preference fields are required.
   
   ### Verification
   
   - New tests on unmodified code: **4/4 green**, checkstyle clean.
   - Discriminating mutation: `@ToString.Exclude` dropped from `apiKey` so 
`toString` leaked it (red).
   - Restored: 4/4 green. Test-only change; no product code touched.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to