Aditya Sharma commented on ROL-2138:

Ahh, Got that. I missed between *by* and *at.* Indeed that makes a huge 
difference. I will update the PR.
{quote}As to the other comments, the N&L files need to relate to the content of 
the bundles to which they apply.
e.g. if the binary contains a copy of product xyz version 1.2.3, but the source 
does not, then only the N&L files for the binary should contain the relevant 
You mean to say is we need to only have entries in N&L for directly available 
dependencies & need not to inherit their N&Ls. I will check them and update the 
PR accordingly.

> NOTICE file does not have standard content
> ------------------------------------------
>                 Key: ROL-2138
>                 URL: https://issues.apache.org/jira/browse/ROL-2138
>             Project: Apache Roller
>          Issue Type: Bug
>            Reporter: Sebb
>            Assignee: Aditya Sharma
>            Priority: Critical
>          Time Spent: 10m
>  Remaining Estimate: 0h
> The NOTICE file in the 5.2.2 release does not have the standard format [1] 
> for a NOTICE file
> It does not have the standard header.
> It also contains material which should not be present.
> Note that the NOTICE and LICENSE files must only include details of software 
> which is actually included in the bundle to which they relate. In this case, 
> the binary bundle contains 3rd party (and other ASF) software, so the NOTICE 
> and LICENSE files should be different.
> Furthermore, the text of all relevant licenses must be included in the 
> bundle; links to external licenses are not sufficient. The license text can 
> either be appended to the LICENSE file, or included in separate files linked 
> from the LICENSE file.
> [1] 
> http://www.apache.org/dev/licensing-howto.html#assembling-license-and-notice

This message was sent by Atlassian JIRA

Reply via email to