shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r272677610
########## File path: samza-core/src/main/java/org/apache/samza/coordinator/metadatastore/NamespaceAwareCoordinatorStreamStore.java ########## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.samza.coordinator.metadatastore; + +import com.google.common.annotations.VisibleForTesting; +import java.util.Collections; +import java.util.HashMap; +import java.util.Map; +import java.util.Objects; +import org.apache.samza.coordinator.metadatastore.CoordinatorStreamStore.CoordinatorMessageKey; +import org.apache.samza.metadatastore.MetadataStore; + +/** + * Provides a namespace aware read/write operations on top of {@link CoordinatorStreamStore}. + */ +public class NamespaceAwareCoordinatorStreamStore implements MetadataStore { + + private final CoordinatorStreamStore coordinatorStreamStore; + private final String namespace; + + /** + * Instantiates the {@link NamespaceAwareCoordinatorStreamStore} based upon the provided + * CoordinatorStreamStore and namespace. + * + * @param coordinatorStreamStore the coordinator stream store. + * @param namespace the namespace to use for keys for storing them in coordinator store. + */ + public NamespaceAwareCoordinatorStreamStore(CoordinatorStreamStore coordinatorStreamStore, String namespace) { + this.coordinatorStreamStore = coordinatorStreamStore; + this.namespace = namespace; + } + + @Override + public void init() { + coordinatorStreamStore.init(); + } + + @Override + public byte[] get(String key) { + Map<String, byte[]> bootstrappedMessages = readMessagesFromCoordinatorStore(); + return bootstrappedMessages.get(key); + } + + @Override + public void put(String key, byte[] value) { + String coordinatorMessageKeyAsJson = getCoordinatorMessageKey(key); + coordinatorStreamStore.put(coordinatorMessageKeyAsJson, value); + } + + @Override + public void delete(String key) { + String coordinatorMessageKeyAsJson = getCoordinatorMessageKey(key); + coordinatorStreamStore.delete(coordinatorMessageKeyAsJson); + } + + @Override + public Map<String, byte[]> all() { + Map<String, byte[]> bootstrappedMessages = readMessagesFromCoordinatorStore(); + return Collections.unmodifiableMap(bootstrappedMessages); + } + + @Override + public void flush() { + coordinatorStreamStore.flush(); + } + + @Override + public void close() { + coordinatorStreamStore.close(); Review comment: Done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
