shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the
redunant coordinator stream reads in the ApplicationMaster startup sequence.
URL: https://github.com/apache/samza/pull/987#discussion_r272680128
##########
File path:
samza-core/src/main/java/org/apache/samza/startpoint/StartpointManager.java
##########
@@ -78,6 +77,14 @@ public StartpointManager(MetadataStoreFactory
metadataStoreFactory, Config confi
LOG.info("StartpointManager created with metadata store: {}",
metadataStore.getClass().getCanonicalName());
}
+ /**
+ * Constructs a {@link StartpointManager} instance.
+ */
+ public StartpointManager(CoordinatorStreamStore metadataStore) {
Review comment:
1. This was meant to be used in the tests alone. Not meant to be a public
API. Will change the visibility of it.
2. Other util classes are not even having a constructor that can instantiate
a meta-store.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
