shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r272677565
########## File path: samza-core/src/main/java/org/apache/samza/coordinator/metadatastore/CoordinatorStreamStore.java ########## @@ -65,19 +70,18 @@ private final SystemProducer systemProducer; private final SystemConsumer systemConsumer; private final SystemAdmin systemAdmin; - private final String type; - private final CoordinatorStreamKeySerde keySerde; - private final Map<String, byte[]> bootstrappedMessages = new HashMap<>(); + // Namespaced key to the message byte array. + private final Map<String, byte[]> bootstrappedMessages = new ConcurrentHashMap<>(); + private final Object bootstrapLock = new Object(); private final AtomicBoolean isInitialized = new AtomicBoolean(false); + private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper(); Review comment: Done. Moved the statics to top. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
