dnishimura commented on a change in pull request #990: SAMZA-2161: Move
ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.
URL: https://github.com/apache/samza/pull/990#discussion_r274045955
##########
File path:
samza-core/src/main/scala/org/apache/samza/checkpoint/CheckpointTool.scala
##########
@@ -126,8 +127,9 @@ object CheckpointTool {
}
def apply(config: Config, offsets: TaskNameToCheckpointMap): CheckpointTool
= {
- val coordinatorStreamManager = new CoordinatorStreamManager(config, new
MetricsRegistryMap())
- new CheckpointTool(offsets, coordinatorStreamManager)
+ val metadataStore: CoordinatorStreamStore = new
CoordinatorStreamStore(config, new MetricsRegistryMap())
+ metadataStore.init()
Review comment:
Any reason to instantiate and init the metadata store here if it'll be just
used once and closed in the `CheckpointTool#run()` method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
